Fix version comparison algorithm #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using a string-based comparison to handle this, which is rather error-prone since it considers '1.10.0' <= '1.9.0'. This makes sure we use integers to perform the comparison in the correct hierarchy of the semver rules. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
bendavies
reviewed
Feb 25, 2021
Comment on lines
+92
to
+102
| private function compare(self $other): int | ||
| { | ||
| $comparison = $this->major <=> $other->major; | ||
|
|
||
| if ($comparison !== 0) { | ||
| return $comparison; | ||
| } | ||
|
|
||
| $comparison = $this->minor <=> $other->minor; | ||
|
|
||
| return $comparison !== 0 ? $comparison : $this->patch <=> $other->patch; |
There was a problem hiding this comment.
this can all be condensed to:
return [$this->major, $this->minor, $this->patch] <=> [$other->major, $other->minor, $other->patch];There was a problem hiding this comment.
@bendavies cool, didn't know. Would you like to send a patch?
There was a problem hiding this comment.
Why not use something like:
it's been battle-tested since 2013 or so being part of the composer package.
There was a problem hiding this comment.
Could be done, but this code was supposed to work on a very isolated scenario, so IMO, since it is tested and relatively well protected from mutants, introducing a dependency here will likely raise more issues due to the use-case scenario being widened (while it is intentionally narrow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were using a string-based comparison to handle this, which is rather error-prone since it considers '1.10.0' <= '1.9.0'.
This makes sure we use integers to perform the comparison in the correct hierarchy of the semver rules.
This seems to be the root cause of #74.