Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce semver version comparison complexity #117

Merged

Conversation

bendavies
Copy link
Contributor

@bendavies bendavies commented Feb 25, 2021

REF: #116 (comment)

This is not a bug fix. Let me know if you want a different branch.

@bendavies bendavies changed the base branch from 1.11.x to 1.9.x February 25, 2021 16:14
@bendavies bendavies force-pushed the reduce-semver-version-comparison-complixity branch from 1f0e9fb to 45370dc Compare February 25, 2021 16:17
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@Ocramius Ocramius added this to the 1.11.0 milestone Feb 25, 2021
@Ocramius Ocramius self-assigned this Feb 25, 2021
@Ocramius Ocramius changed the base branch from 1.9.x to 1.11.x February 25, 2021 16:19
@Ocramius
Copy link
Member

@bendavies could you rebase this?

Signed-off-by: Ben Davies <ben.davies@gmail.com>
@bendavies bendavies force-pushed the reduce-semver-version-comparison-complixity branch from 45370dc to 3f18927 Compare February 25, 2021 16:34
@bendavies
Copy link
Contributor Author

rebased on 1.11.x

@Ocramius
Copy link
Member

Thanks!

@Ocramius Ocramius merged commit ece2ca8 into laminas:1.11.x Feb 25, 2021
@Ocramius Ocramius changed the title reduce semver version comparison complixity reduce semver version comparison complexity Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants