-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Mezzio development config discovery and injection #68
Conversation
Signed-off-by: matt <matt@claritum.com>
@@ -18,16 +18,14 @@ final class ConfigAggregatorInjector extends AbstractInjector | |||
{ | |||
use ConditionalDiscoveryTrait; | |||
|
|||
/** @var non-empty-string */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constants do not need types as they're constant and thus inferred anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Sorry for the late feedback, had a bunch of other stuff todo...
@kynx did you used this PR in a project to actually verify integrative functionality? I do not have time for it, but I am not 100% sure from reviewing the PR if the installer is actually asking for adding it either to the |
@boesing Yes I've verified it works. If you've got time, give this a try:
That's a minimal version of mezzio skeleton with
Selecting 1 has added the
Note that this does require there to be a |
LGTM, lets ship this. |
Description
This PR adds support for injecting config providers into Mezzio's
config/development.config.php.dist
, following the recommendations from @boesing on mezzio/mezzio-tooling#25. This is useful when adding--dev
tools that shouldn't be shipped in production.If merged a separate PR will be needed against the Mezzio skeleton so the development config looks something like:
Existing applications that do not have this development config will continue to inject only to the main
config/config.php
.