-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch development config to use ConfigAggregator #122
base: 3.16.x
Are you sure you want to change the base?
Conversation
fc84369
to
12a0827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think naming for autoloaded files would be better if shortened a bit.
Local dev configs need to be added to gitignore same as regular local config files.
4d447d1
to
cb85ca5
Compare
You might want to rebase |
Signed-off-by: matt <matt@claritum.com>
Signed-off-by: matt <matt@claritum.com>
Signed-off-by: matt <matt@claritum.com>
cb85ca5
to
e404ba9
Compare
Grrr.... done. |
Hey @Xerkus I ended up using |
@kynx Do you plan to continue working on this? |
@alexmerlin Yeah, checks are passing - remind me, what do I need to do? |
I think this should use "local" in the filename - the (And/or) The |
Description
This PR changes
development.config.php.dist
to use aConfigAggregator
so laminas/laminas-component-installer#68 can inject--dev
-only config providers. It also adds the ability to load dev-only configuration from{,*.}{global,local}-development.php
files - like MVC does - so settings in the development config providers can be overridden.I'm not sure what I can do to test these changes. As far as I can tell the existing tests don't cover the structure of the config files, but if anyone's got any pointers...