PHP 8.3 support added

[glo71317]

Q	A
Documentation	yes/no
Bugfix	yes/no
BC Break	yes/no
New Feature	yes/no
RFC	yes/no
QA	yes/no

Description

[samsonasik]

laminas-file should no longer be supported imo

[froschdesign]

@samsonasik
When someone provides a pull request and their help, we merge it - just like before.

[glo71317]

@froschdesign Can you take a look the PR if all looks fine to you please proceed for merging?

[weierophinney]

My recommendation is to not do any CS changes in this PR, and we can open a new PR to do CS changes later.

If the proposed changes fail the CS rules already present in this PR, then they need to follow and use the existing rules present here to keep it focused.

[gsteel]

@glo71317
If you can avoid upgrading laminas-coding-standard in this patch - i.e. if ~1.0.0 is installable on 8.1 through 8.3, then reverting those changes would be the easiest course of action.

If this is not possible, we'll need to upgrade laminas-coding-standard to ~2.5.0 in a separate patch and fix all of the coding standard violations before attempting to add support for PHP 8.3

[Ocramius]

@gsteel what about removing the dependency, and re-introducing it in a new PR later?

[gsteel]

@Ocramius - I guess removing the dep here would also work, but as @weierophinney suggested that the patch should pass existing CS rules, it would make sense to just keep with version 1.0 here - CS wasn't failing - it's the schema validation that's failing - CS was running fine on 8.0 as far as I could tell, so it's less work to just stay on 1.0 right?

[glo71317]

@Ocramius @gsteel I have updated laminas-coding-standard:"~1.0.0" instead of "~2.5.0", Now PHPCodeSniffer checks are failing. earlier was also same failure then i decided to update laminas-coding-standard:"~2.5.0". So, Can you please suggest?

[glo71317]

@Ocramius @gsteel As you suggested to avoid to suppress the CS Changes, I have updated now Can you please guide us how to proceed on this PR?

[gsteel]

@Ocramius and @weierophinney

I've just looked into this - it's not possible to run phpcs@2.7 on PHP 8.0 anyway, leave alone 8.1.

Last year, almost to the day #13 was merged without CS running either.

Given that tests are passing, do you think we can merge this as-is, and defer CS tooling upgrades for another year, or perhaps discuss continued maintenance of this component in the next TSC meet?

[froschdesign]

@localheinz

Given that tests are passing, do you think we can merge this as-is, and defer CS tooling upgrades for another year, or perhaps discuss continued maintenance of this component in the next TSC meet?

You are a maintainer for this package; what are your thoughts?

[Ocramius]

Even with red CI CS checks, I'm happy with this, as CS is not as relevant here, IMO.

Will squash-merge, as a warning to PR authors.

Thanks @glo71317!

[localheinz]

@froschdesign

Apologies for the delay, I’m traveling in Canada right now and only have my phone with me.