Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 support added #21

Merged
merged 4 commits into from
Nov 21, 2023
Merged

PHP 8.3 support added #21

merged 4 commits into from
Nov 21, 2023

Conversation

glo71317
Copy link
Contributor

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

@glo71317
Copy link
Contributor Author

glo71317 commented Nov 10, 2023 •
edited
Loading

@Ocramius @gsteel Can you review this PR if changes looks fine to you then please proceed for merging?

@Ocramius Ocramius added this to the 2.6.0 milestone Nov 14, 2023
Ocramius
Ocramius reviewed Nov 14, 2023
View reviewed changes
phpcs.xml.dist Outdated
Comment on lines 10 to 306
<exclude-pattern>src/Http/AccessToken.php</exclude-pattern>
<exclude-pattern>src/Http.php</exclude-pattern>
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
<exclude-pattern>src/Consumer.php</exclude-pattern>
<exclude-pattern>src/Token/AuthorizedRequest.php</exclude-pattern>
<exclude-pattern>src/Token/Access.php</exclude-pattern>
<exclude-pattern>src/Token/AbstractToken.php</exclude-pattern>
</rule>
<rule ref="WebimpressCodingStandard.Arrays.DoubleArrow.AtTheEnd">
<exclude-pattern>src/Client.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators.DisallowedEqualOperator">
<exclude-pattern>src/Client.php</exclude-pattern>
<exclude-pattern>src/Http.php</exclude-pattern>
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
<exclude-pattern>src/Signature/AbstractSignature.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing">
<exclude-pattern>src/Client.php</exclude-pattern>
<exclude-pattern>src/Http/Utility.php</exclude-pattern>
<exclude-pattern>src/Http.php</exclude-pattern>
<exclude-pattern>src/Consumer.php</exclude-pattern>
<exclude-pattern>src/Token/AuthorizedRequest.php</exclude-pattern>
<exclude-pattern>src/Token/Request.php</exclude-pattern>
<exclude-pattern>src/Token/Access.php</exclude-pattern>
<exclude-pattern>src/Token/AbstractToken.php</exclude-pattern>
</rule>
<rule ref="Squiz.Commenting.FunctionComment.ThrowsNoFullStop">
<exclude-pattern>src/Client.php</exclude-pattern>
<exclude-pattern>src/Http.php</exclude-pattern>
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
<exclude-pattern>src/Consumer.php</exclude-pattern>
</rule>
<rule ref="Generic.Arrays.ArrayIndent.KeyIncorrect">
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
</rule>
<rule ref="Generic.Formatting.MultipleStatementAlignment.Incorrect">
<exclude-pattern>src/Client.php</exclude-pattern>
</rule>
<rule ref="Squiz.Commenting.FunctionComment.ThrowsNotCapital">
<exclude-pattern>src/Client.php</exclude-pattern>
<exclude-pattern>src/Http.php</exclude-pattern>
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
<exclude-pattern>src/Consumer.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.UselessAnnotation">
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
<exclude-pattern>src/Http.php</exclude-pattern>
<exclude-pattern>src/Http/Utility.php</exclude-pattern>
<exclude-pattern>src/Consumer.php</exclude-pattern>
<exclude-pattern>src/Token/Access.php</exclude-pattern>
<exclude-pattern>src/Token/AbstractToken.php</exclude-pattern>
</rule>
<rule ref="WebimpressCodingStandard.PHP.CorrectClassNameCase.InvalidInPhpDocs">
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
<exclude-pattern>src/Token/AbstractToken.php</exclude-pattern>
</rule>
<rule ref="Generic.Arrays.ArrayIndent.CloseBraceIncorrect">
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.Variables.UselessVariable.UselessVariable">
<exclude-pattern>src/Http/RequestToken.php</exclude-pattern>
<exclude-pattern>src/Http/AccessToken.php</exclude-pattern>
<exclude-pattern>src/Signature/Plaintext.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators.DisallowedNotEqualOperator">
<exclude-pattern>src/Http/Utility.php</exclude-pattern>
</rule>
<rule ref="PSR12.ControlStructures.ControlStructureSpacing.FirstExpressionLine">
<exclude-pattern>src/Http.php</exclude-pattern>
<exclude-pattern>src/Config/StandardConfig.php</exclude-pattern>
<exclude-pattern>src/Signature/AbstractSignature.php</exclude-pattern>
<exclude-pattern>src/Token/Access.php</exclude-pattern>
<exclude-pattern>src/Token/AbstractToken.php</exclude-pattern>
</rule>
<rule ref="Squiz.Commenting.FunctionComment.MissingParamName">
<exclude-pattern>src/Http.php</exclude-pattern>
<exclude-pattern>src/Consumer.php</exclude-pattern>
</rule>
<rule ref="PSR12.Properties.ConstantVisibility.NotFound">
<exclude-pattern>src/OAuth.php</exclude-pattern>
<exclude-pattern>src/Token/AbstractToken.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.Commenting.RequireOneLinePropertyDocComment.MultiLinePropertyComment">
<exclude-pattern>src/Consumer.php</exclude-pattern>
<exclude-pattern>src/Token/AuthorizedRequest.php</exclude-pattern>
<exclude-pattern>src/Token/AbstractToken.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.Commenting.DocCommentSpacing.IncorrectLinesCountBetweenDescriptionAndAnnotations">
<exclude-pattern>src/Signature/AbstractSignature.php</exclude-pattern>
</rule>
<rule ref="PSR12.ControlStructures.ControlStructureSpacing.FirstExpressionLine">
<exclude-pattern>src/Token/AuthorizedRequest.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse">
<exclude-pattern>src/Token/TokenInterface.php</exclude-pattern>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingAnyTypeHint">
<exclude-pattern>src/Token/AbstractToken.php</exclude-pattern>
</rule>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar question to laminas/laminas-file#15 (review)

/cc @laminas/technical-steering-committee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius @gsteel
I have addressed in this PR similar queries laminas/laminas-file#15 (review), Now can you please guide now how to proceed on this?

@Ocramius Ocramius mentioned this pull request Nov 14, 2023
Merged
@Ocramius Ocramius self-assigned this Nov 21, 2023
Ocramius
Ocramius approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with a red CI job for CS checks, I'd say this is good to go.

Will squash-merge, just as a warning to involved contributors.

Thanks @glo71317!

@Ocramius Ocramius merged commit 7c82c5c into laminas:2.6.x Nov 21, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
No open projects
PHP 8.3
Status: Done
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@glo71317 @Ocramius