split up batch llm calls into separate runs #5804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
reviewed
Jun 7, 2023
nfcampos
reviewed
Jun 7, 2023
nfcampos
reviewed
Jun 7, 2023
nfcampos
reviewed
Jun 7, 2023
Co-authored-by: Nuno Campos <nuno@boringbits.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
vowelparrot
reviewed
Jun 23, 2023
vowelparrot
reviewed
Jun 23, 2023
nfcampos
reviewed
Jun 23, 2023
langchain/chat_models/base.py
Outdated
| if new_arg_supported | ||
| else self._generate(m, stop=stop) | ||
| for m in messages | ||
| ] | ||
| except (KeyboardInterrupt, Exception) as e: | ||
| run_manager.on_llm_error(e) | ||
| for run_manager in run_managers: |
There was a problem hiding this comment.
same comment as in js. We can do better error handling and send the error only into the one that errored
nfcampos
reviewed
Jun 23, 2023
vowelparrot
force-pushed
the
ankush/batch-llm-fix
branch
from
691930f to
17f4006
Compare
|
Is there any explanation available for the goal of this PR? My app breaks when I update from 0.0.214 to 0.0.215, so I'm assuming this PR is the cause. I'm just getting into trying to figure out why, but all I have to go on here is the title of the PR. UPDATE: the problem seems to be that llm_output is not set when I'm making a batch request to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Before submitting
Who can review?
Tag maintainers/contributors who might be interested: