Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in the async methods and link the run id #5810

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Add in the async methods and link the run id #5810

merged 2 commits into from
Jun 7, 2023

Conversation

vowelparrot
Copy link
Contributor

No description provided.

@vowelparrot vowelparrot requested review from agola11 and hwchase17 June 7, 2023 04:57
agola11
agola11 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@agola11 agola11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine since you are only dealing with chains here but just heads up I am changing the way run info is stored for LLMs here: #5804

@vowelparrot vowelparrot merged commit d9fcc45 into master Jun 7, 2023
@vowelparrot vowelparrot deleted the vwp/async_eval branch June 7, 2023 15:27
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
@vowelparrot @Undertone0809
Add in the async methods and link the run id (langchain-ai#5810)
1d8226b
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agola11 agola11 agola11 approved these changes

@hwchase17 hwchase17 Awaiting requested review from hwchase17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vowelparrot @agola11