Fixed a link typo /-/route -> /-/routes. and change endpoint format #6186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lf.anyscale_service_url}/{self.anyscale_service_route} to {self.anyscale_service_url}{self.anyscale_service_route}
eyurtsev
reviewed
Jun 15, 2023
| @@ -102,7 +102,7 @@ def _call( | |||
| """ | |||
|
|
|||
| anyscale_service_endpoint = ( | |||
| f"{self.anyscale_service_url}/{self.anyscale_service_route}" | |||
| f"{self.anyscale_service_url}{self.anyscale_service_route}" | |||
There was a problem hiding this comment.
What happens if the user provides a URL with no trailing slash?
There was a problem hiding this comment.
Good point. Even though the provided anyscale_service_url and anyscale_service_service format should have correct format, I'm adding some validation code to ensure it
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@hwchase17 is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
hwchase17
added
the
lgtm
tconkling
added a commit
to tconkling/langchain
that referenced
this pull request
Jun 20, 2023
* master: (101 commits) add FunctionMessage support to `_convert_dict_to_message()` in OpenAI chat model (langchain-ai#6382) bump version to 206 (langchain-ai#6465) fix neo4j schema query (langchain-ai#6381) Update serpapi.py Support baidu list type answer_box (langchain-ai#6386) fix: llm caching for replicate (langchain-ai#6396) feat: use latest duckduckgo_search API to call (langchain-ai#6409) Harrison/unstructured page number (langchain-ai#6464) Improve error message (langchain-ai#6275) Fix the issue where ANTHROPIC_API_URL set in environment is not takin… (langchain-ai#6400) Fix broken links in autonomous agents docs (langchain-ai#6398) Update SinglStoreDB vectorstore (langchain-ai#6423) Fix for langchain-ai#6431 - chatprompt template with partial variables giing validation error (langchain-ai#6456) Harrison/functions in retrieval (langchain-ai#6463) Incorrect argument count handling (langchain-ai#5543) Fixed a link typo /-/route -> /-/routes. and change endpoint format (langchain-ai#6186) docs `retrievers` fixes (langchain-ai#6299) Update introduction.mdx (langchain-ai#6425) Fix Custom LLM Agent example (langchain-ai#6429) Remove backticks without clear purpose from docs (langchain-ai#6442) Update web_base.ipynb (langchain-ai#6430) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a link typo from
/-/routeto/-/routes.and change endpoint format
from
f"{self.anyscale_service_url}/{self.anyscale_service_route}"tof"{self.anyscale_service_url}{self.anyscale_service_route}"Also adding documentation about the format of the endpoint
Before submitting
Who can review?
Tag maintainers/contributors who might be interested: