Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use latest duckduckgo_search API to call #6409

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

Undertone0809
Copy link
Contributor

Provider the latest duckduckgo_search API

The Git commit contents involve two files related to some DuckDuckGo query operations, and an upgrade of the DuckDuckGo module to version 3.8.3. A suitable commit message could be "Upgrade DuckDuckGo module to version 3.8.3, including query operations". Specifically, in the duckduckgo_search.py file, a DDGS() class instance is newly added to replace the previous ddg() function, and the time parameter name in the get_snippets() and results() methods is changed from "time" to "timelimit" to accommodate recent changes. In the pyproject.toml file, the duckduckgo-search module is upgraded to version 3.8.3.

duckduckgo_search readme attention: Versions before v2.9.4 no longer work as of May 12, 2023

Who can review?

@vowelparrot

@vercel
Copy link

vercel bot commented Jun 19, 2023

@Undertone0809 is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@Undertone0809
Copy link
Contributor Author

Undertone0809 commented Jun 19, 2023

@vowelparrot I run poetry lock command. But I have been running for a long time without any results. Is this normal?

image

@rrcgat
Copy link

rrcgat commented Jun 19, 2023

Consider using the -v|vv|vvv option to gather more information, maybe it's a network issue.

Additionally, if you are using a generator, the type annotation for get_snippets() should be Generator[str, None, None]. Don't forget to update the results() function to use the latest API.

@Undertone0809
Copy link
Contributor Author

@rrcgat Thanks

@Undertone0809
Copy link
Contributor Author

@vowelparrot plz review

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 20, 2023
@hwchase17 hwchase17 merged commit 8a604b9 into langchain-ai:master Jun 20, 2023
tconkling added a commit to tconkling/langchain that referenced this pull request Jun 20, 2023
* master: (101 commits)
  add FunctionMessage support to `_convert_dict_to_message()` in OpenAI chat model (langchain-ai#6382)
  bump version to 206 (langchain-ai#6465)
  fix neo4j schema query (langchain-ai#6381)
  Update serpapi.py Support baidu list type answer_box (langchain-ai#6386)
  fix: llm caching for replicate (langchain-ai#6396)
  feat: use latest duckduckgo_search API to call (langchain-ai#6409)
  Harrison/unstructured page number (langchain-ai#6464)
  Improve error message (langchain-ai#6275)
  Fix the issue where ANTHROPIC_API_URL set in environment is not takin… (langchain-ai#6400)
  Fix broken links in autonomous agents docs (langchain-ai#6398)
  Update SinglStoreDB vectorstore (langchain-ai#6423)
  Fix for langchain-ai#6431 - chatprompt template with partial variables giing validation error (langchain-ai#6456)
  Harrison/functions in retrieval (langchain-ai#6463)
  Incorrect argument count handling (langchain-ai#5543)
  Fixed a link typo /-/route -> /-/routes. and change endpoint format (langchain-ai#6186)
  docs `retrievers` fixes (langchain-ai#6299)
  Update introduction.mdx (langchain-ai#6425)
  Fix Custom LLM Agent example (langchain-ai#6429)
  Remove backticks without clear purpose from docs (langchain-ai#6442)
  Update web_base.ipynb (langchain-ai#6430)
  ...
bdonkey added a commit to bdonkey/langchain that referenced this pull request Jun 20, 2023
* master: (158 commits)
  Fix link (langchain-ai#6501)
  docs/fix links (langchain-ai#6498)
  Update notebook for MD header splitter and create new cookbook (langchain-ai#6399)
  Vector store support for Cassandra (langchain-ai#6426)
  improve documentation on base chain (langchain-ai#6468)
  fix: change ddg to DDGS (langchain-ai#6480)
  release 207 (langchain-ai#6488)
  Add Alibaba Cloud OpenSearch as a new vector store (langchain-ai#6154)
  fix openai qa chain (langchain-ai#6487)
  add FunctionMessage support to `_convert_dict_to_message()` in OpenAI chat model (langchain-ai#6382)
  bump version to 206 (langchain-ai#6465)
  fix neo4j schema query (langchain-ai#6381)
  Update serpapi.py Support baidu list type answer_box (langchain-ai#6386)
  fix: llm caching for replicate (langchain-ai#6396)
  feat: use latest duckduckgo_search API to call (langchain-ai#6409)
  Harrison/unstructured page number (langchain-ai#6464)
  Improve error message (langchain-ai#6275)
  Fix the issue where ANTHROPIC_API_URL set in environment is not takin… (langchain-ai#6400)
  Fix broken links in autonomous agents docs (langchain-ai#6398)
  Update SinglStoreDB vectorstore (langchain-ai#6423)
  ...
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants