Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fixed aggregate queries #14793

Merged
merged 2 commits into from
Aug 12, 2016
Merged

[5.1] Fixed aggregate queries #14793

merged 2 commits into from
Aug 12, 2016

Conversation

GrahamCampbell
Copy link
Member

No description provided.

* @return float|int
* @param string $function
* @param array $columns
* @return mixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may now become int|float

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeh, oops, Meant to put that :)

@taylorotwell
Copy link
Member

Can you describe whats going on here?

@JoostK
Copy link
Contributor

JoostK commented Aug 12, 2016

I like that you try to do something with my earlier comments in #14781 but really doubt if we should go this way. Has there been any practical issues with aggregate how it always behaved?

@GrahamCampbell
Copy link
Member Author

Yeh, it'll break if you have strict types turned on and you were expecting a float instead of a string without these changes.

@JoostK
Copy link
Contributor

JoostK commented Aug 12, 2016

Ah, in a PHP 7 context that makes sense. With formattedAggregate having been changed to numericalAggregate this is then okay with me.

@taylorotwell taylorotwell merged commit 73ee91b into 5.1 Aug 12, 2016
@GrahamCampbell GrahamCampbell deleted the aggregate branch August 12, 2016 18:24
@segadora
Copy link
Contributor

I might have posted a comment in the wrong place.

I have issues since this change with the min and max method. I am trying to get the maximum value if a date time field like 2016-08-24 00:00:00, but the max() method only returns 2016. Is this the expected behavior and if so, how to get the min and max values of a date time field?

@GrahamCampbell
Copy link
Member Author

Basically reverted this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants