[5.6] Math DB functions should return numeric type #22640
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found one interesting thing when started to declare static types in one of my packages. Maybe I'm missing something, but it's not right that database query math functions like
avg
andsum
returnsstring
instead offloat
orint
.I understand that
min
&max
functions are math too, but they could be used to getDATE
&TIMESTAMP
types. Is there any use cases foravg
orsum
functions where string could be returned?Average dates are getting by converting them to Unix timestamps, calculating average value and then converting them to date value back.
Notice that we don't need this check:
return $result ?: 0;
. It's done innumericAggregate
method.