[5.5] add date and cast check for dirty #18400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
GrahamCampbell
changed the title
|
Your tests fail. |
|
Hm... |
golubkovden
commented
Mar 23, 2017
|
|
||
| // When check rich this check and current attribute value not equals with original, we should skip next steps | ||
| // if current is null | ||
| if (is_null($current)) { |
There was a problem hiding this comment.
This check for nullable may be should move to fromDateTime method as like castAttribute method.
This hack check looked from setAttribute
There was a problem hiding this comment.
Fully agree, either that or should to include the original value in the check too:
if (is_null($current) || is_null($original)) {
is_null($current)covers updating filled column with NULLis_null($original)covers updating NULL with filling
There was a problem hiding this comment.
The missing is_null($original) causes problems for deleted_at which is NULL before a model is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened PR from #18385
add tests