[5.5] Route: simplify RouteCollection. #18417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@themsaid any idea why this Travis build is failing? It seems like our requirements are fine? @crynobone |
| return isset($this->nameList[$name]) ? $this->nameList[$name] : null; | ||
| return $this->collection->first(function (Route $route) use ($name) { | ||
| return Arr::get($route->getAction(), 'as') === $name; | ||
| }); |
There was a problem hiding this comment.
Isn't this much slower than looking it up in a map? People may have many route(...) calls in their views.
| return $this->collection->mapWithKeys(function (Route $route) { | ||
| foreach ($route->methods() as $method) { | ||
| return [$method => [$route->domain().$route->uri() => $route]]; | ||
| } |
There was a problem hiding this comment.
Wouldn't this only return for the first method the route supports?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
RouteCollectionusing only one collection for the route storage.There is no need to handle
$allRoutes,$nameListand$actionListanymore.This also makes the lookup refresh useless, as it's not necessary anymore.
Note:
the Travis build is failing because of another reason, related to
orchestra/testbench, as in #18229, #18313 , #18400 & #18403