Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symfony mailer docblocks #38773

Merged
merged 2 commits into from
Sep 12, 2021
Merged

Update symfony mailer docblocks #38773

merged 2 commits into from
Sep 12, 2021

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Sep 12, 2021

This PR removes some old references to Swift_Mailer and replaces it with the Symfony Mailer equivalent.

Even though the Symfony's TransportFactories annotate TransportInterface as the return type, Some of Laravels docblocks have a specific return type annotated.

Example:
EsmtpTransportFactory returns an Object of TransportInterface but in the Laravel DocBlocks the real class will be annotated, which is here EsmtpTransport

Therefor all @return annotations have the most specific class.

@GrahamCampbell GrahamCampbell changed the title [Symfony-Mailer] Update docblocks Update symfony mailer docblocks Sep 12, 2021
@driesvints driesvints merged commit f7324d1 into laravel:symfony-mailer Sep 12, 2021
@driesvints
Copy link
Member

Thanks @Jubeki

driesvints pushed a commit that referenced this pull request Sep 12, 2021
* Update docblocks from Swift Mailer to Symfony Mailer

* Make TransportInterface more specific
@Jubeki Jubeki deleted the update-symfony-mailer-docblocks branch September 12, 2021 18:29
taylorotwell added a commit that referenced this pull request Sep 14, 2021
* Implement Symfony Mailer

* Apply fixes from StyleCI

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update src/Illuminate/Mail/Message.php

Co-authored-by: michael-rubel <contact@observer.name>

* Update Array and Log transports

* Apply fixes from StyleCI

* Fix interface implementation

* Update Mailer

* Apply fixes from StyleCI

* Rename

* Remove method

* Fix tests

* Apply fixes from StyleCI

* Work on Mailer tests

* type-hint

* Fix Mailer tests

* Fix more tests

* Apply fixes from StyleCI

* Migrate Mailgun transport

* Migrate Postmark transport

* Replace SesTransport

* Remove transports from dev dependencies

* Allow setting options on esmtp transport

* Fix Postmark transport

* Fix embedding files

* Clarify API transports

* Apply fixes from StyleCI

* Fix SES transport setup

* Add MessageStreamId to Postmark Transport again (#38748)

* Update symfony mailer docblocks (#38773)

* Update docblocks from Swift Mailer to Symfony Mailer

* Make TransportInterface more specific

* Add Session Token to SES Transport (#38797)

* Update src/Illuminate/Mail/Transport/ArrayTransport.php

Co-authored-by: Julius Kiekbusch <jubeki99@gmail.com>

* fix docblock

* Add Wrapper for Symfony SentMessage (#38803)

* Create SentMessage wrapper for Symfony's SentMessage

* Wrap Symfony SentMessage

* Update Docblocks to Illuminate\Mail\SentMessage

* Fix sendMailable

* Update SentMessage.php

Co-authored-by: Dries Vints <dries@vints.io>

Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
Co-authored-by: michael-rubel <contact@observer.name>
Co-authored-by: Julius Kiekbusch <jubeki99@gmail.com>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
Co-authored-by: Taylor Otwell <taylorotwell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants