[1.x] Allow ignoring route registration #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
changed the title
timacdonald
approved these changes
Dec 4, 2023
|
Has conflicts. |
Resolved, there seems to be an issue with the static code analysis from the 1.x branch right now |
Signed-off-by: Tobias Oitzinger <tobiasoitzinger@gmail.com>
|
rebased this one against a fix version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similiar to other first pary packages i thought it would be great to allow ignoring route registration, in order to be able to register the routes yourself. A more practical use case might be if you use something like tenancy for laravel where registring the routes only on central domains, etc.. can be beneficial and easir to be created that way