-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Make migrations publishable #81
Conversation
This will also be useful for skipping the migration in test Example, by wrapping the if (app()->runningUnitTests()) |
@SRWieZ If you want to disable Pulse during tests, you should set the env - otherwise it'll be doing work during the test still - but just swallowing exceptions. <server name="PULSE_ENABLED" value="false"/> |
Publishing migrations is also nice as it gives the apps control over the indexes, which may be optimized further for specific applications. |
@timacdonald @jessarcher we are moving most of our first party packages to only publishing migrations (never running them behind the scenes). We are making this change for Sanctum and maybe others in Laravel 11. It may be good to go ahead and just take this approach here? |
@taylorotwell dig it. Updated this one and updated the docs over here: laravel/docs#9176 |
Conflicts. 😅 |
@taylorotwell I've resolved the conflicts. |
Signed-off-by: Tobias Oitzinger <tobiasoitzinger@gmail.com>
Similiar to other first pary packages i thought it would be great to allow publishing migrations. Same as in this pr #80: a more practical use case might be if you use something like tenancy for laravel where you might want to have those migrations for your tenant databases as well