Merge pull request #610 from roberto-aguilar/feature/phpunit

Fix PHPUnit 8 warnings
laravel · Apr 10, 2019 · 69ba357 · 69ba357
2 parents f5d5bb3 + a669608
commit 69ba357
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/tests/Watchers/DumpWatcherTest.php b/tests/Watchers/DumpWatcherTest.php
@@ -28,6 +28,6 @@ public function test_dump_watcher_register_entry()
         $entry = $this->loadTelescopeEntries()->first();
 
         $this->assertSame(EntryType::DUMP, $entry->type);
-        $this->assertContains($var, $entry->content['dump']);
+        $this->assertStringContainsString($var, $entry->content['dump']);
     }
 }
diff --git a/tests/Watchers/EventWatcherTest.php b/tests/Watchers/EventWatcherTest.php
@@ -45,7 +45,9 @@ public function test_event_watcher_stores_payloads()
         $this->assertSame(EntryType::EVENT, $entry->type);
         $this->assertSame(DummyEvent::class, $entry->content['name']);
         $this->assertArrayHasKey('data', $entry->content['payload']);
-        $this->assertArraySubset(['Telescope', 'Laravel', 'PHP'], $entry->content['payload']['data']);
+        $this->assertContains('Telescope', $entry->content['payload']['data']);
+        $this->assertContains('Laravel', $entry->content['payload']['data']);
+        $this->assertContains('PHP', $entry->content['payload']['data']);
     }
 }
 

diff --git a/tests/Watchers/MailWatcherTest.php b/tests/Watchers/MailWatcherTest.php
@@ -41,7 +41,7 @@ public function test_mail_watcher_registers_entry()
         $this->assertSame(['bcc@laravel.com'], array_keys($entry->content['bcc']));
         $this->assertSame('Check this out!', $entry->content['subject']);
         $this->assertSame('Telescope is amazing!', $entry->content['html']);
-        $this->assertContains('Telescope is amazing!', $entry->content['raw']);
+        $this->assertStringContainsString('Telescope is amazing!', $entry->content['raw']);
         $this->assertEmpty($entry->content['replyTo']);
     }
 }
diff --git a/tests/Watchers/NotificationWatcherTest.php b/tests/Watchers/NotificationWatcherTest.php
@@ -32,7 +32,7 @@ public function test_notification_watcher_registers_entry()
         $this->assertSame(EntryType::NOTIFICATION, $entry->type);
         $this->assertSame(BoomerangNotification::class, $entry->content['notification']);
         $this->assertSame(false, $entry->content['queued']);
-        $this->assertContains('telescope@laravel.com', $entry->content['notifiable']);
+        $this->assertStringContainsString('telescope@laravel.com', $entry->content['notifiable']);
         $this->assertSame('mail', $entry->content['channel']);
         $this->assertNull($entry->content['response']);
     }