Merge with https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations #10
Labels
Comments
vorburger
added a commit
to vorburger/eclipse-null-eea-augments
that referenced
this issue
Sep 14, 2017
These are only the ones which we didn't have at all yet; more next. https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java lastnpe#10
This was referenced Sep 14, 2017
vorburger
added a commit
to vorburger/eclipse-null-eea-augments
that referenced
this issue
Sep 15, 2017
These are the ones I had to indivdually review and in many cases had to manually resolve merges; that's a PITA (and lead me to open lastnpe#16), thus I skipped merged java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass' from https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java for lastnpe#10
vorburger
added a commit
that referenced
this issue
Sep 15, 2017
These are only the ones which we didn't have at all yet; more next. https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java #10
vorburger
added a commit
to vorburger/eclipse-null-eea-augments
that referenced
this issue
Sep 15, 2017
These are the ones I had to indivdually review and in many cases had to manually resolve merges; that's a PITA (and lead me to open lastnpe#16), thus I skipped merged java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass' from https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java for lastnpe#10
|
@kwin or anyone else interested (@maggu2810 ?) - terribly sorry for replying only now, but finally picking this project up... We would love to get these in. LICENSE should not be an issue, as both projects are EPL. I've made a start with the JDK ones in #15 and #17 (NB due to #16 I skipped merging java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass' - review feedback on #17 would be welcome!). Would you like to add the other ones? Specifically tracecompass' Guava, Apache Commons would be interesting, useful and very welcome! BTW: As per README, you can become a committer on this project with x3 PRs! ;-) |
kaikreuzer
pushed a commit
that referenced
this issue
Sep 15, 2017
These are the ones I had to indivdually review and in many cases had to manually resolve merges; that's a PITA (and lead me to open #16), thus I skipped merged java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass' from https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java for #10
vorburger
added a commit
to vorburger/eclipse-null-eea-augments
that referenced
this issue
Sep 29, 2017
vorburger
added a commit
that referenced
this issue
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tracecompass has also maintained some external annotations for quite some libraries in the past. It seems right now much more extensive than this approach. Could you just merge all changes from https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations?
Not sure whether the license would allow that though.
The text was updated successfully, but these errors were encountered: