Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracecompass' java.* EEAs (2/2) #17

Merged
merged 2 commits into from
Sep 15, 2017

Conversation

vorburger
Copy link
Member

@vorburger vorburger commented Sep 15, 2017

These are the ones I had to indivdually review and in many cases had to manually resolve merges; that's a PITA (and lead me to open ttps://github.com//issues/16), thus I skipped merged java.lang.String, java.util.Collections and java.util.Map and kept my original ones, and did not merge with tracecompass'

from
https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java

for #10

These are the ones I had to indivdually review and in many cases had to
manually resolve merges; that's a PITA (and lead me to open
lastnpe#16), thus I
skipped merged java.lang.String, java.util.Collections and java.util.Map
and kept my original ones, and did not merge with tracecompass'

from
https://github.com/tracecompass/tracecompass/tree/master/common/org.eclipse.tracecompass.common.core/annotations/java

for lastnpe#10
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaikreuzer kaikreuzer merged commit af3beec into lastnpe:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants