add eea for string and map method(s) #21
Conversation
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
| entrySet | ||
| ()Ljava/util/Set<Ljava/util/Map$Entry<TK;TV;>;>; | ||
| ()Ljava/util/Set<L1java/util/Map$Entry<TK;TV;>;>; | ||
| get | ||
| (Ljava/lang/Object;)TV; | ||
| (Ljava/lang/Object;)T0+V; | ||
| (L1java/lang/Object;)T0V; |
There was a problem hiding this comment.
@maggu2810 do you happen to know what this change means?
I'm not yet used to reading this syntax.. ;) In an ideal world, we should have #16, one day...
| remove | ||
| (Ljava/lang/Object;)TV; | ||
| (Ljava/lang/Object;)T0V; | ||
| (L1java/lang/Object;)T0V; |
There was a problem hiding this comment.
and also this, as above, do you happen to know what this changes?
There was a problem hiding this comment.
@Nullable T remove(@NonNull Object);
It states that the argument must not be null and the return value could be null.
The JavaDoc states:
Returns the value to which this map previously associated the key, or null if the map contained no mapping for the key.
But it also states:
NullPointerException - if the specified key or value is null, and this map does not permit null keys or values (optional)
So, a Map itself does not forbid a nullable key (correct?).
I will close this PR. I was not aware that the Map interface allows null keys.
Sorry.
There was a problem hiding this comment.
So, a Map itself does not forbid a nullable key (correct?).
Yeah I think what that means is basically "it depends on the implementation" - PITA.
Sorry. I will close this PR. I was not aware that the Map interface allows null keys.
don't be sorry - thanks a lot for taking time to contribute to this at all - community appreciates it!
I thought your other contributions here, the additions apart from the suggested changes, would still be very useful - don't you want to re-open this and just undo the changes instead? Then I'd love the merge it with just the proposed additions! (With a comment like in #23.)
There was a problem hiding this comment.
I have already other annotations added in my local copy, so also the topic needs to be changed.
I will create another PR later with a bunch of files.
No description provided.