Add annotations of java.time.Instant #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Reimann <jreimann@redhat.com>
|
@ctron thanks for this contribution! Due to #16, I'm not able to really review this intelligently (could perhaps locally pull and view in Eclipse somehow, but that's much too cumbersome for reviews), so am planning to just merge this in 48h if nobody else has any objections - it's better than not having anything for Instant at all - and it can always be appealed and rectified later if it's not 100% accurate. @maggu2810 do you have any interest in reviewing this? |
This was referenced Sep 19, 2017
|
I checked some of them and it seems to be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jens Reimann jreimann@redhat.com