prepare 3.1.8 release #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy method for multi-environment, not sure about SettableFuture null vs null for return type of Future<Void>, both type check and pass tests
…maryKey separation everywhere but the builder. Add getRequestBuilderFor a specific environment. Add static method to LDClient to get all environment names so that environments can be iterated over. Add accessor to retrieve LDClient specific UserManager. Iterate over all environments in PollingUpdater. Add environment argument to UserManager constructor, removing singleton and creating replacing init with newInstance static method.
…Manager may not be able to do the same so removed the environment from the constructor.
…imaryInstance null when offline in init, fixed primaryEnvironmentName being added to secondaryMobileKeys
… authorization header key.
…y cleared once all environments have a copy in LDClient
Circlecimigrate
…ersion, replaced with method that returns requested instance
Relates to #60 Cleaned up timber logging messages to use string formatting rather than concatenation. Log messages should remain the same as before. Also replaced Log with Timber in the example app.
Added version and flagVersion retrieval from ping events if available
Fix crash when example app is backgrounded twice.
attempt a provider update when TLSv1.2 is not available.
* fix(SharedPreferences): added more SharedPreferences first time migration and differentiated SharedPreferences by mobile key * fix(UserLocalSharePreference.java): added missing mobileKey additions to getSharedPreferences, cleaned up debugging code
remove short publishing timeout, use defaults of 60 retries & 10 seconds
don't create a new executor just to trigger a flush
# Conflicts: # testharness-suppressions.txt
fix URL path concatenation to avoid double slashes
fix NPE in edge case where variation is null but value isn't
…64297/secure-random
…ct-tests-31-33 disable contract tests for API 31/33
use SecureRandom instead of Random, just to make scanners happier
* clean up instances map on close * improve atomicity of access to instances, ensure they can't be modified via closed clients * update more methods that iterate over instances
…-close-client ensure timed-out clients get closed in contract tests
aengelberg
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[3.1.8] - 2022-08-23
Changed:
java.util.Randomto usejava.security.SecureRandom. Even though in this case it is not being used for any cryptographic purpose, but only to produce a pseudo-random delay, static analysis tools may still report every use ofjava.util.Randomas a security risk by default. The purpose of this change is simply to avoid such warnings; it has no practical effect on the behavior of the SDK.Fixed:
LDClientinstances was not being cleared after callingclose(). (#108)ExecutorServiceobject to be unnecessarily created whenflush()was called.baseUriorstreamUrito a URI with a trailing slash could cause requests to fail. Now the SDK works correctly regardless of whether these URIs have a trailing slash or not."anonymous": falsein analytics event data for users where theanonymousproperty had not been set at all. In the current user model,"anonymous": falseis subtly different from not setting the property (flag rules referencinganonymouswill only work if it is explicitly set), so the event data should accurately represent this by omitting the property if it was omitted.variationmethods, in an edge case where the SDK received inconsistent data of a kind that the LaunchDarkly services would not normally send (an evaluation result with a value but no variation). This should not be possible in practice, but could happen in test scenarios.