prepare 2.6.0 release #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add time threshold for backoff reset
add interface for customizing requests
# Conflicts: # src/main/java/com/launchdarkly/eventsource/EventSource.java
allow endpoint to be specified as either URI or HttpUrl
# Conflicts: # CHANGELOG.md # gradle.properties
remove JSR305
replace SSL-specific config method with general-purpose HTTP config method
add end-to-end EventSource tests
# Conflicts: # src/main/java/com/launchdarkly/eventsource/EventSource.java
avoid trailing period in logger name
omit default header value if there's a custom value
fix logic for shutting down after an unrecoverable error
use newer HTTP test helpers
use new stream-reading implementation to support CR-only line endings
* Bounded queue for the EventHandler thread The unbounded queue fronting the 'event' thread can cause trouble when the EventHandler is unable to keep up with the workload. This can lead to heap exhaustion, GC issues and failure modes that are generally considered "bad". Band-aid over this with a semaphore to limit the number of tasks in the queue. The semaphore is opt-in and disabled by default to avoid any nasty surprises for folks upgrading. Also add 'EventSource.awaitClosed()' to allow users to wait for underlying thread pools to completely shut down. We can't know if it's safe to clean up resources used by the EventHandler thread if we can't be certain that it has completely terminated. * Address checkstyle griping in StubServer * Fix JavaDoc issue * Tighten up exception handling Co-authored-by: Eli Bishop <eli@launchdarkly.com>
…into eb/sc-137152/handler-queue
…red-fields add option to ensure that expected fields are always read
louis-launchdarkly
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.6.0] - 2022-06-28
Added:
EventSource.Builder.streamEventDataandEventSource.Builder.expectFields, for enabling a new event parsing mode in which event data can be consumed directly from the stream without holding it all in memory. This may be useful in applications where individual events are extremely large.MessageEvent.getDataReaderandMessageEvent.isStreamingData, for use with the new mode described above.MessageEvent.getEventName, providing access to the event name from the event object; previously the event name was only available as a parameter ofEventHandler.onMessage.Changed: