prepare 4.0.1 release #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add time threshold for backoff reset
add interface for customizing requests
# Conflicts: # src/main/java/com/launchdarkly/eventsource/EventSource.java
allow endpoint to be specified as either URI or HttpUrl
# Conflicts: # CHANGELOG.md # gradle.properties
remove JSR305
replace SSL-specific config method with general-purpose HTTP config method
add end-to-end EventSource tests
# Conflicts: # src/main/java/com/launchdarkly/eventsource/EventSource.java
avoid trailing period in logger name
omit default header value if there's a custom value
remove SLF4J dependency, use only com.launchdarkly.logging
use SecureRandom instead of Random, just to make scanners happier
# Conflicts: # src/main/java/com/launchdarkly/eventsource/EventSource.java
# Conflicts: # CHANGELOG.md # gradle.properties
… 2.x # Conflicts: # .ldrelease/config.yml # src/main/java/com/launchdarkly/eventsource/EventSource.java
remove usage of Duration for Android compatibility in new major version
# Conflicts: # gradle.properties
update doc comments regarding thread behavior in Android
update Gradle to 7.6 + fix snapshot releases
… an event (#68) * in streaming data mode, throw an exception if stream is closed during an event * one more unit test
louis-launchdarkly
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.0.1] - 2023-01-09
Added:
StreamClosedWithIncompleteMessageException(see below).Fixed:
EventSource.Builder.streamEventData), if the stream connection was lost before theMessageEventwas fully read-- that is, before encountering a blank line-- theReaderreturned byMessageEvent.getDataReader()was treating this as a regular EOF condition. That was incorrect; the SSE specification says that in such a case, the incomplete message is invalid and its contents should not be used. Therefore, in this case reading from theReaderwill throw aStreamClosedWithIncompleteMessageException. The caller should handle this by simply throwing away theMessageEvent.