Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from original repo #2

Merged
merged 78 commits into from
Aug 9, 2019
Merged

Commits on Jun 29, 2017

  1. Configuration menu
    Copy the full SHA
    3aa542a View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2018

  1. Added delegate callback to detect when panning is finished, to potent…

    …ially allow users to manually reset the hightlight values once panning is complete
    AntonTheDev committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    767d03d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3d3ed7 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Configuration menu
    Copy the full SHA
    3d40b00 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2018

  1. Add Parameters Section

    ```
    (\n[ ]+)(((/// - parameter \w+:.*\s+)(///((\s+)|( \s+.+\s+)))?)*/// - parameter \w+:.*)
    ```
    
    ```
    $1/// - Parameters:$1$2
    ```
    kemchenj committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    08820aa View commit details
    Browse the repository at this point in the history
  2. Remove parameter prefix

    ```
    /// - parameter (\w+):(.*)(\s+///(\n))*(\s+)
    ```
    
    ```
    ///   - $1:$2$4$5
    ```
    kemchenj committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    576d7af View commit details
    Browse the repository at this point in the history
  3. Remove property’s returns section

    ```
    /// - returns: (.+\s+((override|@IBOutlet|@objc|weak|unowned|lazy|static|class|open|public|private|fileprivate|internal)(\(set\))? )*(var|let))
    ```
    
    ```
    /// $1
    ```
    kemchenj committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    849acbe View commit details
    Browse the repository at this point in the history
  4. Add missing -

    ```
    /// (note|return|parameters|throws):
    ```
    
    ```
    /// - $1:
    ```
    kemchenj committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    bad3eef View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2018

  1. Sort sections

    ```
    ((///)[ ]+[^-\n]+(\s+))?(((((/// - Parameters:\s+(/// (( - \w+:)|([^-]{1})).*\s+)+)\s+)|(/// - Returns:.*\s+(/// [^-]{1}.*\s+)*)|(/// - Note:.*\s+(/// [^-]{1}.*\s+)*)|(/// - Throws:.*\s+(/// [^-]{1}.*\s+)*))(///\n\s+)?)+)
    ```
    
    ```
    $1$2$3$15$7$17$13
    ```
    kemchenj committed Sep 23, 2018
    Configuration menu
    Copy the full SHA
    f3fa752 View commit details
    Browse the repository at this point in the history
  2. Uppercased the section title

    kemchenj committed Sep 23, 2018
    Configuration menu
    Copy the full SHA
    0edceea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c68ed07 View commit details
    Browse the repository at this point in the history
  4. Remove duplicated section

    kemchenj committed Sep 23, 2018
    Configuration menu
    Copy the full SHA
    033bb11 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. Update ChartViewBase.swift

    Updated documentation in the code based on feedback
    AntonTheDev authored Oct 10, 2018
    Configuration menu
    Copy the full SHA
    33e8eb1 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Configuration menu
    Copy the full SHA
    a4cae71 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3654 from 417-72KI/accesibility_element_initializer

    Make NSUIAccessibilityElement initializer public.
    pmairoldi authored Oct 21, 2018
    Configuration menu
    Copy the full SHA
    3b07904 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2018

  1. Configuration menu
    Copy the full SHA
    d59b2d8 View commit details
    Browse the repository at this point in the history
  2. Remove meaningless comment

    kemchenj committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    a435669 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Merge pull request #3721 from ggirotto/axis-base-bugfix

    Fix wrong assignment to axisMaxLabels property
    fix #3656
    liuxuan30 authored Nov 1, 2018
    Configuration menu
    Copy the full SHA
    69e433a View commit details
    Browse the repository at this point in the history
  2. improvements in barRect height calculation (#3650)

    * fixed barRectCaculation
    
    * fixed offset calculation
    
    * Fix the  mess caused by the setting the min&min value of the y-axis by error :
    Just simply swap their values
    
    * Fix the mess caused by the setting the min&min value of the y-axis by error
    
    * Revert "Fix the mess caused by the setting the min&min value of the y-axis by error"
    
    This reverts commit 526a73a.
    
    * Fix the mess caused by the setting the min&min value of the y-axis by error
    
    * update offset calculation
    
    * update code style
    
    * update code style
    
    * update offset calculation
    
    * keep barRect calculation untouched
    
    try to simply the calculation. keep barRect calculation untouched
    
    * After the correction of min and max ,  they should be assigned back to  _axisMinimum and _axisMaximum
    
    * add demo for bar chart unit test
    
    * update unit test
    
    * revert last commit
    
    * update unit test
    
    * make sure max is greater than min &
    turnoff record mode for barchartest
    
    * add new UT and fix some issues.
    
    1. add more bar chart UT
    2. code style fix
    3. manually add chart.notifyDataSetChanged() - some old UT and new ones forget to call this method, leading the test images to be wrong.
    
    Notice:
    some test images diff shows slight pixel shift, not sure why, but both old and new image seems drawing correctly
    
    * update tvOS images
    
    * update tolerance to 1% & more swift-y
    
    * update tvOS images, removing "Description Label", (not rendered anymore)
    
    changing tolerance will trigger "Description Label" detection
    
    * update iOS test images, "Description Label" no longer rendered.
    
    * fixed offset calculation in some cases.
    moved those codes into the for loop. because the offset of each bar may be different.
    (detail in comments)
    
    * Update Source/Charts/Renderers/BarChartRenderer.swift
    
    Co-Authored-By: potato04 <shiww@outlook.com>
    potato04 authored and jjatie committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    c01a765 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2018

  1. Add missing properties to copy(with:) methods (#3715)

    * #3578 Add missing properties to copy(with:) methods
    
    * Add NSCopying conformance
    dstranz authored and jjatie committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    076f260 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. Merge pull request #3621 from kemchenj/master

    Update document to latest format
    liuxuan30 authored Nov 7, 2018
    Configuration menu
    Copy the full SHA
    ce0d809 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee7a218 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. Fix applying lineCap value for line chart data sets (Fixes #3739)

    DataSets for line chart have lineCap property which is supposed to be applied to the chart line. But it was applied only if dataSet is drawn in linear/stepped mode. This commit makes lineCap work for any existing mode.
    Anton Filimonov committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    44ba57d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. Merge pull request #3736 from SvenMuc/fix_horbarchart_legend_offset

    Fix legend offset bug for horizontal bar chart (Fixes #3301)
    liuxuan30 authored Nov 15, 2018
    Configuration menu
    Copy the full SHA
    271606e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3740 from anton-filimonov/bugfixes/lineChart_line…

    …CapForAll
    
    Fix applying lineCap value for line chart data sets (Fixes #3739)
    liuxuan30 authored Nov 15, 2018
    Configuration menu
    Copy the full SHA
    9971afc View commit details
    Browse the repository at this point in the history
  3. Update README.md (#3737)

    Replace a confusing sentence with a clear one. Fix grammatical errors.
    justinlew authored and jjatie committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    9f2c130 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. fix #3719

    liuxuan30 committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    2927f76 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e2301d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0749a2e View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2018

  1. Remove delegate method call for translation when no translation reall…

    …y occured
    Anton Filimonov committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    7d2e2db View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2019

  1. Configuration menu
    Copy the full SHA
    0d99003 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Merge pull request #3804 from anton-filimonov/bugfixes/scrolling_fixes

    Fix condition that is checked before `chartTranslated` delegate method call
    liuxuan30 authored Jan 14, 2019
    Configuration menu
    Copy the full SHA
    bd3d1eb View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Fixed addEntry implementation

    jjatie committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    290fd88 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3612 from AntonTheDev/master

    Feature - ChartView Pan Ended Delegate Call
    liuxuan30 authored Jan 22, 2019
    Configuration menu
    Copy the full SHA
    f2795b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. Configuration menu
    Copy the full SHA
    5e8c9b1 View commit details
    Browse the repository at this point in the history
  2. BarLineScatterCandleBubbleRenderer.XBounds conformance to RangeExpres…

    …sion and Sequence
    
    Sequence conformance simplifies for-in loops
    Looking forward to when data types conforming to Collection, RangeExpression conformance by XBounds allows for slicing of the collections further simplifying algorithms on data/datasets.
    jjatie committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    2a1ecb4 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. Merge pull request #3815 from danielgindi/dataset-collection-conformance

    Add Collection conformances to ChartDataSet types
    liuxuan30 authored Jan 28, 2019
    Configuration menu
    Copy the full SHA
    8d38438 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2019

  1. Draws the line chart the same way regardless of the number of colors …

    …for the data set (#3764)
    stokatyan authored and jjatie committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    d73b552 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Multiple colors for valueline (Fixes #3480) (#3709)

    * Multiple colors for valueline (Fixes #3480)
    
    This change adds a flag matchValueLineColorToPieSlice to PieChartDataSet and IPieChartDataSet protocol.
    When enabled, valuelines will have the same color as slices they attached to.
    matchValueLineColorToPieSlice is set to false by default, so colors won't be changed in old projects that use Charts.
    
    * Changed variable name from matchValueLineColorToPieSlice to valueLineAutoColor
    
    * Changed variable name from valueLineAutoColor to useValueColorForLine
    
    * Changed variable name from valueLineAutoColor to useValueColorForLine
    
    * fix code style
    
    fix code style
    
    * Changed check for useValueColorForLine with suggested
    
    * fix code style
    
    * Added name DrawLine: to do{} section
    Alexei authored and jjatie committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    2fedfc6 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. bump version to 3.2.2

    liuxuan30 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    deae185 View commit details
    Browse the repository at this point in the history
  2. update change log

    liuxuan30 committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    cf36285 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2019

  1. Renamed values to entries to reflect the property's type

    Removed arbitrary setter access to `entries` to encourage use of `Collection` mechanics
    Added `replaceEntries`
    jjatie committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    9b99d1b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2019

  1. Fixed tests

    jjatie committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    636f623 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Create "chartViewDidEndAnimate" callback function in "ChartViewBase" …

    …that is called when Animator stops animating
    Lcsmarcal committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    af7a4a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a323ad0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d096474 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2019

  1. Replace AnyObject with Any

    This is in line with how Objc interfaces are now imported
    jjatie committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    d59fe25 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Configuration menu
    Copy the full SHA
    46a3018 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Merge pull request #3847 from danielgindi/dataset-values-accessors

    Renamed `values` to `entries` to reflect the property's type
    liuxuan30 authored Feb 27, 2019
    Configuration menu
    Copy the full SHA
    ad26e63 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. Configuration menu
    Copy the full SHA
    8e2b8c8 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Merge pull request #3864 from danielgindi/fix-objc-imports-anyobject

    Replace AnyObject with Any
    liuxuan30 authored Mar 6, 2019
    Configuration menu
    Copy the full SHA
    fe66742 View commit details
    Browse the repository at this point in the history
  2. Velocity samples calculation (#3883)

    * Updated `PieRadarChartViewBase.sampleVelocity(touchLocation:)` algorithm.
    
    * Updated `PieRadarChartViewBase.calculateVelocity` algorithm
    
    * Updated naming for `_velocitySamples`
    jjatie authored Mar 6, 2019
    Configuration menu
    Copy the full SHA
    10057bf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4f5cbf7 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Merge pull request #3884 from danielgindi/cleanup-pound-if

    Removed unnecessary #if statements and unified style to align with Xc…
    liuxuan30 authored Mar 7, 2019
    Configuration menu
    Copy the full SHA
    b4e300a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Configuration menu
    Copy the full SHA
    a969c46 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53f7c3a View commit details
    Browse the repository at this point in the history
  3. Align ChartLimit.LabelPosition naming with UIRectCorner (#3846)

    * Align `ChartLimit.LabelPosition` naming with `UIRectCorner`
    
    * Fixed Demos
    
    * fix indent after replacing if with guard
    
    * reverted mistaken changes
    
    * Removed unused #if statements
    jjatie authored Mar 9, 2019
    Configuration menu
    Copy the full SHA
    34dafbc View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. add animator reference to animatorDidStop ChartViewBase delegate call…

    …back.
    Lucas Marçal Fernandes committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    e1f28b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Merge pull request #3852 from Lcsmarcal/didFinishAnimate

    Create `chartViewDidEndAnimate` in ChartViewDelegate
    liuxuan30 authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    b1df472 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3854 from chaaarly/master

    HorizontalBarChar value label offset calculation
    liuxuan30 authored Mar 20, 2019
    Configuration menu
    Copy the full SHA
    5d0b99a View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Minor updates for Swift 5 (#3874)

    * Minor updates for Swift 5
    
    Need FBSnapshotTestCase to be updated
    
    * Updated testing Framework for Swift 5
    
    bumped minimum deployment version to 8.4
    
    * Bumped Travis Xcode version
    
    * Fix test failures. add a new extension to only use 64bit arch. This is the companion commit that only has code change regards fixing test failures.
    
    * delete unused test images with specific screen size. this is a companion commit to only have deleted files
    
    * rename the in-use test images. this is a companion commit to only have renamed files.
    
    * change image diff to 0.001 tolerance
    make clipValuesToContentEnabled to true to fix BarTests:testPositiveValuesWithCustomAxisMaximum() failure
    
    * 1. merge master to fix xBounds iterator() to match the behavior of `stride(from: _xBounds.min, through: _xBounds.range + _xBounds.min, by: 1)`
    this fix issues from 2a1ecb4
    
    2. revert clipValuesToContentEnabled to false by default. but enable it for bar chart test - testPositiveValuesWithCustomAxisMaximum()
    
    3. update tvOS test image for testPositiveValuesWithCustomAxisMaximum. After changing tolerance to 0.001, it fails while the same iOS test pass.
    I looked into the image diff, it shows the intersect of bar top edge and axis line at value 50 has diff, but I suppose the image is the same. safe to merge.
    jjatie authored Apr 11, 2019
    Configuration menu
    Copy the full SHA
    b155c2f View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Configuration menu
    Copy the full SHA
    6fb075f View commit details
    Browse the repository at this point in the history
  2. Reassess convenience initializers (#3862)

    * Reassess convenience initializers
    
    The only data required to initialize an entry is an x and y value (or y in the case of Pie and Radar). All other data can easily be updated by initializing and assigning properties on the entry. Therefor, those initializers should be the ones marked as convenience.
    Made initializer declarations consistent.
    
    * Modernize BarChartDataEntry internal calculations
    
    * Style updated for PR
    jjatie authored and liuxuan30 committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    2896791 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3900 from danielgindi/3860

    fix #3860. maxHeight didn't count the last label
    liuxuan30 authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    13623d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. Fix horizontal bar chart not drawing values and add unit tests (#3906)

    * fix horizontal bar chart drawValues not correctly drawing and add testNotDrawValueAboveBars UT
    
    * add unit tests for horizontal bar chart, including default tests and drawValues and drawValuesAboveBars
    default data entries included positive and negative values
    
    * add tvOS test images
    
    * add stacked bar tests for bar chart unit tests
    
    * fix typo
    
    * change to guard statement for shouldDrawValues
    
    * update test images to match master branch
    liuxuan30 authored Apr 15, 2019
    Configuration menu
    Copy the full SHA
    c6b4c67 View commit details
    Browse the repository at this point in the history
  2. Data as any (#3863)

    * `ChartEntry.data` is now of type `Any`
    
    There is no need to restrict `ChartEntry.data` to `AnyObject`. This PR loosens that restriction. As a result we cannot compare `data`, though this should never have been the case in the first place.
    
    * Updated `ChartDataEntry` initializers to accept `Any` for `data`
    
    * Updated test
    jjatie authored and liuxuan30 committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    1b08577 View commit details
    Browse the repository at this point in the history
  3. bump version to 3.3

    liuxuan30 committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    2bde78f View commit details
    Browse the repository at this point in the history
  4. update change log

    liuxuan30 committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    a1f52c9 View commit details
    Browse the repository at this point in the history
  5. update gemfile

    liuxuan30 committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    4fef53c View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. correct 3.3 to 3.3.0.

    liuxuan30 committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    cd1120b View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. For #3917. make init(label: String?) convenient initializer (#3973)

    * fix #3917. make `init(label: String?)` to be a convenient init to enable auto inheritance.
    
    * add UT for default dataSet label
    liuxuan30 authored and jjatie committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    899fe1d View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. Configuration menu
    Copy the full SHA
    03616c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Update Info.plist

    liuxuan30 authored Jun 5, 2019
    Configuration menu
    Copy the full SHA
    e6b01f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Merge pull request #4006 from UberNick/master

    Added a safety check before an unsafe array operation
    liuxuan30 authored Jun 10, 2019
    Configuration menu
    Copy the full SHA
    e850593 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Update License

    Changed year in license file
    jobinsjohn authored Jul 2, 2019
    Configuration menu
    Copy the full SHA
    acb436a View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Merge pull request #4055 from jobinsjohn/patch-1

    Update License
    liuxuan30 authored Jul 12, 2019
    Configuration menu
    Copy the full SHA
    2d80b44 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. fixed stacked chart bug when there are different stacks on columns. (#…

    …4029)
    
    fix #3659
    * fixed stacked chart bug when there are different stacks on columns.
    * added empty array check
    Scalman authored and liuxuan30 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    8c28cfa View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Merge pull request #2568 from chiahan1123/master

    Avoid passing NaN to CoreGraphics API (Fixes #1626)
    fix #4043, fix #1626
    liuxuan30 authored Aug 7, 2019
    Configuration menu
    Copy the full SHA
    8a98ee2 View commit details
    Browse the repository at this point in the history