-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(RingTheory/Morita/Basic): Define Morita Equivalence #20640
Conversation
PR summary 84846a1273
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Algebra.Category.ModuleCat.ChangeOfRings | 1189 | 1192 | +3 (+0.25%) |
Import changes for all files
Files | Import difference |
---|---|
6 filesMathlib.Algebra.Category.ModuleCat.Differentials.Basic Mathlib.Algebra.Category.ModuleCat.Differentials.Presheaf Mathlib.Algebra.Category.ModuleCat.EnoughInjectives Mathlib.AlgebraicGeometry.Modules.Presheaf Mathlib.AlgebraicGeometry.Modules.Sheaf Mathlib.AlgebraicGeometry.Modules.Tilde |
2 |
20 filesMathlib.Algebra.Category.ModuleCat.ChangeOfRings Mathlib.Algebra.Category.ModuleCat.Presheaf.Abelian Mathlib.Algebra.Category.ModuleCat.Presheaf.ChangeOfRings Mathlib.Algebra.Category.ModuleCat.Presheaf.Colimits Mathlib.Algebra.Category.ModuleCat.Presheaf.EpiMono Mathlib.Algebra.Category.ModuleCat.Presheaf.Limits Mathlib.Algebra.Category.ModuleCat.Presheaf.Pushforward Mathlib.Algebra.Category.ModuleCat.Presheaf.Sheafification Mathlib.Algebra.Category.ModuleCat.Presheaf.Sheafify Mathlib.Algebra.Category.ModuleCat.Presheaf Mathlib.Algebra.Category.ModuleCat.Pseudofunctor Mathlib.Algebra.Category.ModuleCat.Sheaf.Abelian Mathlib.Algebra.Category.ModuleCat.Sheaf.ChangeOfRings Mathlib.Algebra.Category.ModuleCat.Sheaf.Colimits Mathlib.Algebra.Category.ModuleCat.Sheaf.Free Mathlib.Algebra.Category.ModuleCat.Sheaf.Generators Mathlib.Algebra.Category.ModuleCat.Sheaf.Limits Mathlib.Algebra.Category.ModuleCat.Sheaf.PushforwardContinuous Mathlib.Algebra.Category.ModuleCat.Sheaf.Quasicoherent Mathlib.Algebra.Category.ModuleCat.Sheaf |
3 |
Mathlib.RingTheory.Morita.Basic (new file) |
1194 |
Declarations diff
+ IsMoritaEquivalent
+ MoritaEquivalence
+ instance : Linear S (ModuleCat.{v} S) := ModuleCat.Algebra.instLinear
+ instance {A : Type u₁} [Ring A] [Algebra R A] {B : Type u₂} [Ring B] [Algebra R B]
+ instance {R S} [Ring R] [Ring S] (f : R →+* S) : (restrictScalars f).Additive
+ instance {R₀ R S} [CommSemiring R₀] [Ring R] [Ring S] [Algebra R₀ R] [Algebra R₀ S]
+ ofAlgEquiv
+ of_algEquiv
+ restrictScalarsEquivalenceOfRingEquiv_additive
+ restrictScalarsEquivalenceOfRingEquiv_linear
++ refl
++ symm
++ trans
- instance : Linear S (ModuleCat.{v} S)
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
I think it's quite important to add a base ring into the story: when Also, even in the general setup, I think it would be better to always assume a Morita equivalence to be additive, and add a constructor from a bare equivalence. |
@ADedecker can you check the newest commit 273aaa7 to see if this is what you mean (modulo the factor a bunch of other stuff in mathlib is broken) |
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
scoped instance : SMulCommClass S S₀ M where | ||
smul_comm s s₀ n := | ||
show s • algebraMap S₀ S s₀ • n = algebraMap S₀ S s₀ • s • n by | ||
rw [← smul_assoc, smul_eq_mul, ← Algebra.commutes, mul_smul] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should give IsScalarTower
instead. And use IsScalarTower.of_algebraMap_smul
in the proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still gives a large-import label. Perhaps add both IsScalarTower
and SMulCommClass
by hand?
Thanks! |
🚀 Pull request has been placed on the maintainer queue by erdOne. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Co-authored by: @jjaassoonn Co-authored-by: zjj <zjj@zjj> Co-authored-by: Whysoserioushah <109107491+Whysoserioushah@users.noreply.github.com> Co-authored-by: Whysoserioushah <yx3021@ic.ac.uk> Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Pull request successfully merged into master. Build succeeded: |
Co-authored by: @jjaassoonn