Add some convenience operators to observable #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem like they would be used frequently enough for an observable type, especially the comparison operators which are critical to the
jdonald
reviewed
Sep 27, 2016
| auto operator/(const T& rhs) -> decltype(val * rhs) { return val / rhs; } | ||
| auto operator+(const T& rhs) -> decltype(val * rhs) { return val + rhs; } | ||
| auto operator-(const T& rhs) -> decltype(val * rhs) { return val - rhs; } | ||
| }; |
There was a problem hiding this comment.
These operators don't seem to be hit at all via the unit test. I mean, I can remove them and the test still compiles and runs.
I suspect it's because operator const T&(void) const { return val; } already does everything we need.
Still investigating.
yeswalrus
reviewed
Sep 29, 2016
| @@ -100,3 +99,16 @@ struct marshaller<observable<T>> : | |||
| }; | |||
|
|
|||
| } | |||
|
|
|||
| namespace std { | |||
There was a problem hiding this comment.
Nice addition, this will be handy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem like they would be used frequently enough for an observable type, especially the comparison operators which are critical to the
@jdonald update: It seems we need only the hash function.