-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some convenience operators to observable #994
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8611822
Add some convenience operators to observable
codemercenary 6835082
Fix broken test
codemercenary 15e4852
Fix clang build
codemercenary bcb86f3
Add unit tests for basic operators
jdonald c429bb4
Remove operator overloads that appear unnecessary
jdonald 2c36e8a
Use const
jdonald a851a7d
Add newline at EOF
jdonald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// Copyright (C) 2012-2015 Leap Motion, Inc. All rights reserved. | ||
// Copyright (C) 2012-2016 Leap Motion, Inc. All rights reserved. | ||
#pragma once | ||
#include "marshaller.h" | ||
#include "signal.h" | ||
|
@@ -74,7 +74,6 @@ class observable { | |
} | ||
}; | ||
|
||
|
||
template<typename T> | ||
struct marshaller<observable<T>> : | ||
marshaller_base | ||
|
@@ -100,3 +99,16 @@ struct marshaller<observable<T>> : | |
}; | ||
|
||
} | ||
|
||
namespace std { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice addition, this will be handy |
||
template<typename T> | ||
struct hash<autowiring::observable<T>> { | ||
hash(void) = default; | ||
|
||
hash<T> interior; | ||
|
||
auto operator()(const autowiring::observable<T>& value) const -> decltype(interior(value.get())) { | ||
return interior(value.get()); | ||
} | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These operators don't seem to be hit at all via the unit test. I mean, I can remove them and the test still compiles and runs.
I suspect it's because
operator const T&(void) const { return val; }
already does everything we need.Still investigating.