-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facility command and task improvements #7187
Facility command and task improvements #7187
Conversation
_namespace_locks = {} | ||
|
||
|
||
class NamespacedCacheProxy(BaseCache): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rtibbles I created this proxy class to generically handle tracking cache keys and clearing them.
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two potential issues with the new namespaced cache class.
Summary
NamespacedCacheProxy
to enable efficient clearing of cache keys related to Facility dataset data200
and makes them not cancellablesync
command to not aggregate progress tracking totalmorango
to0.5.1
which has deserialization improvementsReviewer guidance
kolibri manage sync
command pulling from the firstkolibri manage deletefacility
command deleting the facilitykolibri manage sync
command pulling again to pull the same facilityReferences
learningequality/morango#84
#7127
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)