-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deserialization improvements #84
Deserialization improvements #84
Conversation
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 83.46% 82.85% -0.62%
==========================================
Files 31 37 +6
Lines 2316 2385 +69
Branches 297 301 +4
==========================================
+ Hits 1933 1976 +43
- Misses 286 309 +23
- Partials 97 100 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing that confused me initially was that _deserialize_store_model
catches and re-raises the error.
Yeah, not immediately obvious from looking at the code what's going on there. I'll add a couple more comments to that section. |
Summary
Some records at times fail to deserialize on KDP (due to missing data, specifically foreign key referents). Added some tests that uncovered a potential cause, and fixed that, and then also added a column called
deserialization_error
on theStore
model to track issues with deserialization, to support debugging and to be able to skip them for a "lighter weight" deserialization as desired.TODO
Issues addressed
Addresses issues with bulk deserialization seen on KDP.