Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show fiat value for BRC-20 balances #4408

Closed
markmhendrickson opened this issue Oct 23, 2023 · 8 comments · Fixed by #5179
Closed

Show fiat value for BRC-20 balances #4408

markmhendrickson opened this issue Oct 23, 2023 · 8 comments · Fixed by #5179
Assignees
@fbwoolf
Labels
area:balances area:brc20 effort:large Expected to take over 1 week of integration work enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Milestone
Redesign tokens UX

Comments

@markmhendrickson
Copy link
Collaborator

No description provided.

@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p2 Critical functionality needed by few users, with no clear alternatives area:balances area:brc20 labels Oct 23, 2023
@markmhendrickson
Copy link
Collaborator Author

Prices can be found via the Best in Slot API

@markmhendrickson markmhendrickson added this to the Redesign tokens UX milestone Mar 15, 2024
@fbwoolf
Copy link
Contributor

fbwoolf commented Mar 26, 2024

Prices can be found via the Best in Slot API

Think this one might be on hold too after starting it? Doesn't get logged with the response, and confirmed in docs...

Screenshot 2024-03-26 at 11 47 44 AM

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 8, 2024

@markmhendrickson any movement here or should I move back into backlog?

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 8, 2024 •
edited
Loading

@alter-eggo can you update me on why this method and getBrc20TickerData are unused for BIS atm? https://github.com/leather-wallet/extension/blob/1cd26250dde7b46146e5da48fbe355e682b8c966/src/app/query/bitcoin/bitcoin-client.ts#L129

Were we waiting for the pro tier to remove Hiro completely?

EDIT: It does appear to work just by swapping out the apis and using https://leatherapi.bestinslot.xyz/v3 ...but let me know if I am supposed to completely remove use of Hiro api here? PR is up here: #5179

fbwoolf added a commit that referenced this issue Apr 8, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
0b840b3
@fbwoolf fbwoolf linked a pull request Apr 8, 2024 that will close this issue
feat: brc-20 token balances as fiat #5179
Merged
fbwoolf added a commit that referenced this issue Apr 8, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
abbe247
@alter-eggo
Copy link
Contributor

alter-eggo commented Apr 9, 2024 •
edited
Loading

@fbwoolf yeah, waiting for pro tier, as free one is too tight for our needs...
we prob want to leave hiro api as is? in case we need a fallback for BiS?

fbwoolf added a commit that referenced this issue Apr 10, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
52f1a7a
fbwoolf added a commit that referenced this issue Apr 10, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
245dd8d
fbwoolf added a commit that referenced this issue Apr 10, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
0a572fc
fbwoolf added a commit that referenced this issue Apr 16, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
17023b9
fbwoolf added a commit that referenced this issue Apr 16, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
6d30989
fbwoolf added a commit that referenced this issue Apr 18, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
90ace9d
fbwoolf added a commit that referenced this issue Apr 18, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
f1c8927
fbwoolf added a commit that referenced this issue Apr 19, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
693cde4
fbwoolf added a commit that referenced this issue Apr 20, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
d59662f
@fbwoolf fbwoolf added the effort:large Expected to take over 1 week of integration work label Apr 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 21, 2024
@fbwoolf
feat: brc-20 token balances as fiat, #4408
0942131
@alter-eggo alter-eggo mentioned this issue Apr 23, 2024
Merged
kyranjamie pushed a commit that referenced this issue Apr 24, 2024
@semantic-release-bot
chore(release): 6.36.0
b2922eb 
## [6.36.0](v6.35.1...v6.36.0) (2024-04-24)

### Features

* brc-20 token balances as fiat, [#4408](#4408) ([0942131](0942131))
* decrease num of addresses to fetch ([b0276ec](b0276ec))
* increase hiro rate limiter ([51cf2c0](51cf2c0))

### Bug Fixes

* allow virtuoso to resize dynamically, ref [#5242](#5242) ([5d618aa](5d618aa))
* prevent form submit on tooltip click, ref [#5258](#5258) ([8735380](8735380))
* problem with endless loading of balances and names ([15202f4](15202f4))
* rpc send transfer params network validation, closes [#5284](#5284) ([a6f774c](a6f774c))
* rpc send transfer recipient default network ([4410185](4410185))
* show hash formatting, ref [#5261](#5261) ([5264a99](5264a99))

### Internal

* post-release merge back ([6a53bff](6a53bff))
* price as market data ([773421b](773421b))
* remove unneeded logger errors ([b4d73f8](b4d73f8))
@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 24, 2024 •
edited
Loading

@markmhendrickson @kyranjamie is it possible the price data provided by BiS is in sats and not USD? I may have messed this up bc @brandonmarshall-tm believes the values are off (high). It seems like if I use sats it is more accurate?

Screenshot 2024-04-24 at 3 24 48 PM

EDIT: I asked in the TG channel.

@brandonmarshall-tm
Copy link

Screenshot 2024-04-24 at 2 01 45 PM

For example:
1 TRIO is worth ~0.00005440 BTC so my USD balance should be ~$6960 and unfortunately not the over $100k listed 😉

Price comparisons:
https://www.coingecko.com/en/coins/sats-ordinals
https://www.coingecko.com/en/coins/zbit-ordinals
https://www.coingecko.com/en/coins/trio-ordinals

@fbwoolf fbwoolf mentioned this issue Apr 24, 2024
Merged
@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 25, 2024

It looks like we should be taking advantage of more pricing data from coingecko? Do we have an api key?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbwoolf fbwoolf

Labels
area:balances area:brc20 effort:large Expected to take over 1 week of integration work enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Milestone
Redesign tokens UX
Development

Successfully merging a pull request may close this issue.

feat: brc-20 token balances as fiat leather-io/extension
5 participants
@markmhendrickson @kyranjamie @fbwoolf @alter-eggo @brandonmarshall-tm