Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't scroll to last couple of accounts on the account selection screen #5242

Closed
314159265359879 opened this issue Apr 16, 2024 · 3 comments · Fixed by #5289
Closed

Can't scroll to last couple of accounts on the account selection screen #5242

314159265359879 opened this issue Apr 16, 2024 · 3 comments · Fixed by #5289
Assignees
@pete-watters
Labels
bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds effort:medium Expected to take 2-5 days of integration work

Comments

@314159265359879
Copy link
Contributor

I can reproduce this sometimes the last 5 accounts are not displayed. when scrolling the select account screen.

See the issue after clicking account 1 (or any)
to open the account selection page
then add account
switch account again scroll up then down
try this on an wallet with 50 or more accounts (that is what the user was testing with, and I saw it on a wallet with 500 accounts too).

leather.mp4
@314159265359879 314159265359879 added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds labels Apr 16, 2024
@314159265359879
Copy link
Contributor Author

workaround, add some additional accounts so you can always scroll to the one you want to reach anyway.

@brandonmarshall-tm
Copy link

+1 another user report of the same issue

@pete-watters pete-watters self-assigned this Apr 17, 2024
@pete-watters pete-watters linked a pull request Apr 17, 2024 that will close this issue
fix: allow users access all accounts in account switcher #5171
Closed
@pete-watters
Copy link
Contributor

pete-watters commented Apr 17, 2024 •
edited
Loading

Thanks for the report, I'll fix this ASAP. I had to add an urgent fix on top for #5171 which resulted in this.

It also relates to historical issues we have had here #4764

pete-watters added a commit that referenced this issue Apr 17, 2024
@pete-watters
fix: improve dynamic sizing of virtuoso lists, ref #5149, #5242
942c3ba
pete-watters added a commit that referenced this issue Apr 17, 2024
@pete-watters
fix: improve dynamic sizing of virtuoso lists, ref #5149, #5242
7d79b2c
pete-watters added a commit that referenced this issue Apr 17, 2024
@pete-watters
fix: improve dynamic sizing of virtuoso lists, ref #5149, #5242
5db7626
pete-watters added a commit that referenced this issue Apr 17, 2024
@pete-watters
fix: improve dynamic sizing of virtuoso lists, ref #5149, #5242
1a970b6
pete-watters added a commit that referenced this issue Apr 17, 2024
@pete-watters
fix: improve dynamic sizing of virtuoso lists, ref #5149, #5242
ab7af8c
pete-watters added a commit that referenced this issue Apr 17, 2024
@pete-watters
fix: improve dynamic sizing of virtuoso lists, ref #5149, #5242
d507b50
@pete-watters pete-watters added the effort:medium Expected to take 2-5 days of integration work label Apr 19, 2024
This was referenced Apr 22, 2024
Closed
Closed
pete-watters added a commit that referenced this issue Apr 22, 2024
@pete-watters
fix: allow virtuoso to resize dynamically, ref #5242
4497e18
pete-watters added a commit that referenced this issue Apr 22, 2024
@pete-watters
fix: allow virtuoso to resize dynamically, ref #5242
94d01c6
@pete-watters pete-watters mentioned this issue Apr 22, 2024
Merged
pete-watters added a commit that referenced this issue Apr 22, 2024
@pete-watters
fix: allow virtuoso to resize dynamically, ref #5242
ab6dd7b
pete-watters added a commit that referenced this issue Apr 23, 2024
@pete-watters
fix: allow virtuoso to resize dynamically, ref #5242
26b5fc1
pete-watters added a commit that referenced this issue Apr 23, 2024
@pete-watters
fix: allow virtuoso to resize dynamically, ref #5242
6e6765d
@pete-watters pete-watters linked a pull request Apr 23, 2024 that will close this issue
fix: allow virtuoso to resize dynamically, ref #5242 #5289
Merged
pete-watters added a commit that referenced this issue Apr 23, 2024
@pete-watters
fix: allow virtuoso to resize dynamically, ref #5242
6f242c3
github-merge-queue bot pushed a commit that referenced this issue Apr 24, 2024
@pete-watters
fix: allow virtuoso to resize dynamically, ref #5242
5d618aa
kyranjamie pushed a commit that referenced this issue Apr 24, 2024
@semantic-release-bot
chore(release): 6.36.0
b2922eb 
## [6.36.0](v6.35.1...v6.36.0) (2024-04-24)

### Features

* brc-20 token balances as fiat, [#4408](#4408) ([0942131](0942131))
* decrease num of addresses to fetch ([b0276ec](b0276ec))
* increase hiro rate limiter ([51cf2c0](51cf2c0))

### Bug Fixes

* allow virtuoso to resize dynamically, ref [#5242](#5242) ([5d618aa](5d618aa))
* prevent form submit on tooltip click, ref [#5258](#5258) ([8735380](8735380))
* problem with endless loading of balances and names ([15202f4](15202f4))
* rpc send transfer params network validation, closes [#5284](#5284) ([a6f774c](a6f774c))
* rpc send transfer recipient default network ([4410185](4410185))
* show hash formatting, ref [#5261](#5261) ([5264a99](5264a99))

### Internal

* post-release merge back ([6a53bff](6a53bff))
* price as market data ([773421b](773421b))
* remove unneeded logger errors ([b4d73f8](b4d73f8))
@pete-watters pete-watters mentioned this issue Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds effort:medium Expected to take 2-5 days of integration work
Projects
None yet
Milestone
No milestone
3 participants
@pete-watters @314159265359879 @brandonmarshall-tm