Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow users to click into text input fields when ::before border #4584

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: allow users to click into text input fields when ::before border #4584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3a900d
fix: allow users to click input when populated, closes #4582
pete-watters Nov 28, 2023
74e3af1
fix: remove not working onFocusborder, to be fixed in #4583
pete-watters Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/app/components/text-input-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { Ref, useRef } from 'react';

import { SendCryptoAssetSelectors } from '@tests/selectors/send.selectors';
import { useField } from 'formik';
import { css } from 'leather-styles/css';
import { Box, Flex, FlexProps, HStack, styled } from 'leather-styles/jsx';

import { useShowFieldError } from '@app/common/form-utils';
Expand Down Expand Up @@ -59,11 +58,6 @@ export function TextInputField({
}}
border="default"
borderRadius="sm"
className={css({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just got rid of this as it wasn't working and hasn't been for a while. I opened a task for it #4583

'& :has(:focus)::before': {
border: '2px solid #bfc6ff',
},
})}
cursor="text"
flexDirection="column"
justifyContent="center"
Expand Down Expand Up @@ -124,6 +118,7 @@ export function TextInputField({
spellCheck="false"
textStyle="body.02"
width="100%"
zIndex={1}
{...field}
onBlur={e => {
onBlur?.();
Expand Down
Loading