Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TabArray class #50

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Implement TabArray class #50

merged 1 commit into from
Oct 21, 2023

Conversation

PromyLOPh
Copy link
Contributor

I’ve tested it with pangocairocffi and it works.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c4fa079) 99.25% compared to head (77ad71d) 98.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   99.25%   98.90%   -0.36%     
==========================================
  Files          19       20       +1     
  Lines         940     1004      +64     
==========================================
+ Hits          933      993      +60     
- Misses          7       11       +4     
Files Coverage Δ
pangocffi/__init__.py 86.04% <100.00%> (+0.33%) ⬆️
pangocffi/enums.py 100.00% <100.00%> (ø)
pangocffi/tabarray.py 97.87% <97.87%> (ø)
pangocffi/layout.py 97.24% <62.50%> (-2.76%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leifgehrmann
Copy link
Owner

Nice work! I've tested that these changes works locally and this all looks good to me. There's some lines of code not covered, but it's nothing significant that should stop this code from being merged in.

I've also run the GitHub actions and they seem to have failed for reasons that are likely unrelated to your changes. It's been a while since they have been run, so I'll do a quick investigation first why they might be broken. I'll be merging this in today even if I don't figure it out.

Hopefully I'll be able to make a release by tomorrow.

@leifgehrmann leifgehrmann merged commit 1d12c01 into leifgehrmann:master Oct 21, 2023
1 of 19 checks passed
@PromyLOPh
Copy link
Contributor Author

Thanks! I see my tests were somewhat lacking, sorry about that :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants