Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional tests for TabArray #52

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Conversation

leifgehrmann
Copy link
Owner

  • Tests were missing for three lines of code in Implement TabArray class #50:
    • Testing that the the setter/getter methods for Layout work.
    • Checking that IndexError is raised when setting an incorrect number of decimal_point values.
  • Updated _get_tab in Layout to return an optional TabArray if none is set.
  • Updated _set_tab in Layout to allow passing in None.
  • Added an acceptance test to demonstrate how TabArrays work.
  • Renamed the files and variable names tabarray to tab_array, just for consistency with how other object files are named. This should not impact how the code is actually used.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d12c01) 98.90% compared to head (feba606) 99.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   98.90%   99.30%   +0.40%     
==========================================
  Files          20       20              
  Lines        1004     1008       +4     
==========================================
+ Hits          993     1001       +8     
+ Misses         11        7       -4     
Files Coverage Δ
pangocffi/__init__.py 86.04% <100.00%> (ø)
pangocffi/layout.py 100.00% <100.00%> (+2.75%) ⬆️
pangocffi/tab_array.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leifgehrmann leifgehrmann merged commit 98331f3 into master Oct 21, 2023
36 checks passed
@leifgehrmann leifgehrmann deleted the add-tab-array-tests branch October 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant