Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (ble): Add ClearFile #1188

Merged
merged 3 commits into from
Dec 13, 2022
Merged

✨ (ble): Add ClearFile #1188

merged 3 commits into from
Dec 13, 2022

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Dec 7, 2022

  • Validated on the robot

Need

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Dec 7, 2022
@YannLocatelli YannLocatelli added this to the v1.3.0 milestone Dec 7, 2022
@YannLocatelli YannLocatelli self-assigned this Dec 7, 2022
@YannLocatelli YannLocatelli linked an issue Dec 7, 2022 that may be closed by this pull request
@YannLocatelli YannLocatelli changed the title ✨ Add ResetFile ✨ (ble): Add ResetFile Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

File comparision analysis report

🔖 Info

  • base: develop / a254378 + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
  • head: yann/feature/ble/add-reset-file / a254378 + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: ON
Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 182804 (69%) 79340 (30%) 41648 (7%)
os 489388 (31%) 1075284 (68%) 93128 (17%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 489260 (23%)
489388 (23%)
📈
128 (0%)
93008 (17%)
93128 (17%)
📈
120 (0%)
bootloader ✔️ 182804 (8%) ø 41648 (7%) ø
functional_ut_boost_ut ✔️ 409212 (19%) ø 30608 (5%) ø
functional_ut_core_imu ✔️ 389196 (18%) ø 30584 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ 368140 (17%) ø 30560 (5%) ø
functional_ut_deep_sleep_core_motor ✔️ 376076 (17%) ø 30632 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ 378292 (18%) ø 30632 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ 365204 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ 366648 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ 386684 (18%) ø 30856 (5%) ø
functional_ut_imu_kit ✔️ 391388 (18%) ø 30576 (5%) ø
functional_ut_io_expander ✔️ 370896 (17%) ø 30576 (5%) ø
functional_ut_qdac ✔️ 372064 (17%) ø 30576 (5%) ø
spike_lk_accel_gyro ✔️ 94048 (4%) ø 22568 (4%) ø
spike_lk_audio ✔️ 137044 (6%) ø 25176 (4%) ø
spike_lk_behavior_kit ✔️ 199084 (9%) ø 58720 (11%) ø
spike_lk_ble ✔️ 237596 (11%)
237772 (11%)
📈
176 (0%)
39304 (7%)
39416 (7%)
📈
112 (0%)
spike_lk_bluetooth ✔️ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ 153608 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ 88480 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ 220276 (10%) ø 63104 (12%) ø
spike_lk_config_kit ✔️ 139244 (6%) ø 25136 (4%) ø
spike_lk_coreled ✔️ 88044 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ 92884 (4%) ø 22832 (4%) ø
spike_lk_event_queue ✔️ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ 154368 (7%) ø 25520 (4%) ø
spike_lk_file_reception ✔️ 339748 (16%) ø 38448 (7%) ø
spike_lk_flash_memory ✔️ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ 174440 (8%) ø 47992 (9%) ø
spike_lk_imu_kit ✔️ 97920 (4%) ø 22896 (4%) ø
spike_lk_lcd ✔️ 172652 (8%) ø 57496 (10%) ø
spike_lk_led_kit ✔️ 115772 (5%) ø 25184 (4%) ø
spike_lk_log_kit ✔️ 84776 (4%) ø 23408 (4%) ø
spike_lk_motion_kit ✔️ 106120 (5%) ø 24736 (4%) ø
spike_lk_motors ✔️ 86336 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ 91572 (4%) ø 22776 (4%) ø
spike_lk_reinforcer ✔️ 215940 (10%) ø 59776 (11%) ø
spike_lk_rfid ✔️ 84088 (4%) ø 22184 (4%) ø
spike_lk_sensors_battery ✔️ 87184 (4%) ø 23280 (4%) ø
spike_lk_sensors_light ✔️ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ 90400 (4%) ø 22192 (4%) ø
spike_lk_sensors_touch ✔️ 91672 (4%) ø 22456 (4%) ø
spike_lk_serial_number ✔️ 144900 (6%) ø 25256 (4%) ø
spike_lk_ticker_timeout ✔️ 82712 (3%) ø 22232 (4%) ø
spike_lk_update_process_app_base ✔️ 156876 (7%) ø 26288 (5%) ø
spike_lk_update_process_app_update ✔️ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ 87392 (4%) ø 24120 (4%) ø
spike_lk_wifi ✔️ 130832 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-12-13 12:45:55.771599283 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-12-13 12:45:56.131598343 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       682(+682) |     18(+18) |     232(+232) |
+| [fill]                     |       652(+652) |     18(+18) |     232(+232) |
 | [lib]/ActivityKit.a        |   19562(+19562) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1830(+1830) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         78(+78) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
-| [lib]/FileManagerKit.a     |     1754(+1754) |       0(+0) |         0(+0) |
+| [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/MotionKit.a          |       726(+726) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1636(+1636) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
-| [lib]/VideoKit.a           |       892(+892) |       0(+0) |       36(+36) |
+| [lib]/VideoKit.a           |       806(+806) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 181108(+181108) |   773(+773) | 19755(+19755) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10716(+10716) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               | 122594(+122594) |   548(+548) | 37394(+37394) |
-| Subtotals                  | 445284(+445284) | 3944(+3944) | 88696(+88696) |
-Total Static RAM memory (data + bss): 92640(+92640) bytes
-Total Flash memory (text + data): 449228(+449228) bytes
+| main.cpp.obj               | 122836(+122836) |   548(+548) | 37514(+37514) |
+| Subtotals                  | 445412(+445412) | 3944(+3944) | 88816(+88816) |
+Total Static RAM memory (data + bss): 92760(+92760) bytes
+Total Flash memory (text + data): 449356(+449356) bytes
 
Flash used: 489388 (23%) / total: 2097152
SRAM used: 93128 (17%) / total: 524288
spike_lk_ble (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-12-13 12:46:04.603576435 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-12-13 12:46:04.843575820 +0000
@@ -1,19 +1,19 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       428(+428) |     15(+15) |       86(+86) |
+| [fill]                  |       418(+418) |     15(+15) |       82(+82) |
 | [lib]/BLEKit.a          |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       122(+122) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
-| [lib]/FileManagerKit.a  |     1712(+1712) |       0(+0) |         0(+0) |
+| [lib]/FileManagerKit.a  |     1714(+1714) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   40860(+40860) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 145464(+145464) |   709(+709) | 19447(+19447) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9940(+9940) |     16(+16) |     204(+204) |
-| main.cpp.obj            |     7554(+7554) |     92(+92) | 15722(+15722) |
-| Subtotals               | 215252(+215252) | 3408(+3408) | 35584(+35584) |
-Total Static RAM memory (data + bss): 38992(+38992) bytes
-Total Flash memory (text + data): 218660(+218660) bytes
+| main.cpp.obj            |     7754(+7754) |     92(+92) | 15838(+15838) |
+| Subtotals               | 215444(+215444) | 3408(+3408) | 35696(+35696) |
+Total Static RAM memory (data + bss): 39104(+39104) bytes
+Total Flash memory (text + data): 218852(+218852) bytes
 
Flash used: 237772 (11%) / total: 2097152
SRAM used: 39416 (7%) / total: 524288

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

File comparision analysis report

🔖 Info

  • base: develop / a254378 + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
  • head: yann/feature/ble/add-reset-file / a254378 + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: OFF
Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 170348 (64%) 91796 (35%) 30952 (5%)
os 438096 (27%) 1126576 (72%) 81912 (15%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 437968 (20%)
438096 (20%)
📈
128 (0%)
81792 (15%)
81912 (15%)
📈
120 (0%)
bootloader ✔️ 170348 (8%) ø 30952 (5%) ø
functional_ut_boost_ut ✔️ 394076 (18%) ø 20456 (3%) ø
functional_ut_core_imu ✔️ 377068 (17%) ø 20432 (3%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ 360236 (17%) ø 20440 (3%) ø
functional_ut_deep_sleep_core_motor ✔️ 364476 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_core_pwm ✔️ 366612 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ 352504 (16%) ø 20408 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ 354216 (16%) ø 20408 (3%) ø
functional_ut_file_manager ✔️ 374864 (17%) ø 20696 (3%) ø
functional_ut_imu_kit ✔️ 382560 (18%) ø 20424 (3%) ø
functional_ut_io_expander ✔️ 359232 (17%) ø 20424 (3%) ø
functional_ut_qdac ✔️ 360400 (17%) ø 20424 (3%) ø
spike_lk_accel_gyro ✔️ 71184 (3%) ø 11808 (2%) ø
spike_lk_audio ✔️ 126924 (6%) ø 14600 (2%) ø
spike_lk_behavior_kit ✔️ 190520 (9%) ø 48144 (9%) ø
spike_lk_ble ✔️ 229344 (10%)
229600 (10%)
📈
256 (0%)
28360 (5%)
28472 (5%)
📈
112 (0%)
spike_lk_bluetooth ✔️ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ 145848 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ 65776 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ 209960 (10%) ø 52016 (9%) ø
spike_lk_config_kit ✔️ 127268 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ 76164 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ 80228 (3%) ø 12256 (2%) ø
spike_lk_event_queue ✔️ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ 139336 (6%) ø 14440 (2%) ø
spike_lk_file_reception ✔️ 335792 (16%) ø 27792 (5%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ 175144 (8%) ø 47904 (9%) ø
spike_lk_imu_kit ✔️ 87700 (4%) ø 12176 (2%) ø
spike_lk_lcd ✔️ 162732 (7%) ø 46664 (8%) ø
spike_lk_led_kit ✔️ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ 63288 (3%) ø 12256 (2%) ø
spike_lk_motion_kit ✔️ 101148 (4%) ø 14184 (2%) ø
spike_lk_motors ✔️ 62864 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ 78628 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ 207320 (9%) ø 49200 (9%) ø
spike_lk_rfid ✔️ 78956 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ 133020 (6%) ø 14304 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ 145100 (6%) ø 15584 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ 80068 (3%) ø 13272 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-12-13 12:45:50.761566426 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-12-13 12:45:51.121563718 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       672(+672) |     18(+18) |     211(+211) |
+| [fill]                     |       646(+646) |     18(+18) |     211(+211) |
 | [lib]/ActivityKit.a        |   19562(+19562) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1830(+1830) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         78(+78) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
-| [lib]/FileManagerKit.a     |     1754(+1754) |       0(+0) |         0(+0) |
+| [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/MotionKit.a          |       726(+726) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1636(+1636) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
-| [lib]/VideoKit.a           |       906(+906) |       0(+0) |       36(+36) |
+| [lib]/VideoKit.a           |       820(+820) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 179856(+179856) |   773(+773) | 19667(+19667) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10668(+10668) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               |   71970(+71970) |   548(+548) | 26287(+26287) |
-| Subtotals                  | 394468(+394468) | 3944(+3944) | 77480(+77480) |
-Total Static RAM memory (data + bss): 81424(+81424) bytes
-Total Flash memory (text + data): 398412(+398412) bytes
+| main.cpp.obj               |   72208(+72208) |   548(+548) | 26407(+26407) |
+| Subtotals                  | 394596(+394596) | 3944(+3944) | 77600(+77600) |
+Total Static RAM memory (data + bss): 81544(+81544) bytes
+Total Flash memory (text + data): 398540(+398540) bytes
 
Flash used: 438096 (20%) / total: 2097152
SRAM used: 81912 (15%) / total: 524288
spike_lk_ble (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-12-13 12:45:59.441496411 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-12-13 12:45:59.681494159 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       372(+372) |     15(+15) |       90(+90) |
+| [fill]                  |       414(+414) |     15(+15) |       86(+86) |
 | [lib]/BLEKit.a          |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       154(+154) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
-| [lib]/FileManagerKit.a  |     1712(+1712) |       0(+0) |         0(+0) |
+| [lib]/FileManagerKit.a  |     1714(+1714) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   42076(+42076) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 141468(+141468) |   709(+709) | 19323(+19323) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9520(+9520) |     16(+16) |     204(+204) |
-| main.cpp.obj            |     4530(+4530) |     92(+92) |   4898(+4898) |
-| Subtotals               | 208580(+208580) | 3408(+3408) | 24640(+24640) |
-Total Static RAM memory (data + bss): 28048(+28048) bytes
-Total Flash memory (text + data): 211988(+211988) bytes
+| main.cpp.obj            |     4742(+4742) |     92(+92) |   5014(+5014) |
+| Subtotals               | 208836(+208836) | 3408(+3408) | 24752(+24752) |
+Total Static RAM memory (data + bss): 28160(+28160) bytes
+Total Flash memory (text + data): 212244(+212244) bytes
 
Flash used: 229600 (10%) / total: 2097152
SRAM used: 28472 (5%) / total: 524288

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1188 (7ad22fc) into develop (12d6c23) will decrease coverage by 0.03%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##           develop    #1188      +/-   ##
===========================================
- Coverage    96.16%   96.12%   -0.04%     
===========================================
  Files          146      146              
  Lines         3548     3565      +17     
===========================================
+ Hits          3412     3427      +15     
- Misses         136      138       +2     
Impacted Files Coverage Δ
libs/FileManagerKit/include/FileReception.h 100.00% <ø> (ø)
libs/RobotKit/include/RobotController.h 93.84% <50.00%> (-0.69%) ⬇️
libs/BLEKit/include/BLEServiceFileExchange.h 100.00% <100.00%> (ø)
libs/FileManagerKit/source/FileReception.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YannLocatelli YannLocatelli marked this pull request as ready for review December 8, 2022 18:49
@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/add-reset-file branch 2 times, most recently from 2856052 to 7c89c61 Compare December 8, 2022 18:53
@YannLocatelli
Copy link
Member Author

YannLocatelli commented Dec 9, 2022

Suggested by @ladislas

  • Add a reset method in FileManagerKit::File

Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/add-reset-file branch 2 times, most recently from 49dc65f to 829d8e2 Compare December 12, 2022 16:14
@YannLocatelli YannLocatelli changed the title ✨ (ble): Add ResetFile ✨ (ble): Add ClearFile Dec 13, 2022
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ladislas ladislas force-pushed the yann/feature/ble/add-reset-file branch from 7ad22fc to 1f6cc06 Compare December 13, 2022 12:39
@ladislas ladislas merged commit a254378 into develop Dec 13, 2022
@ladislas ladislas deleted the yann/feature/ble/add-reset-file branch December 13, 2022 12:39
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - type: task Something to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚸 (FileExchange): Do not reset file on setFilePath
3 participants