hugo/feature/Use MotionKit in ReinforcerKit #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #1190 +/- ##
===========================================
+ Coverage 96.08% 96.17% +0.09%
===========================================
Files 146 146
Lines 3546 3528 -18
===========================================
- Hits 3407 3393 -14
+ Misses 139 135 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
d689996
to
c554e6f
Compare
HPezz
force-pushed
the
hugo/feature/Add-MotionKit
branch
from
0da22a1
to
dd59e8f
Compare
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
c554e6f
to
2563355
Compare
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
2563355
to
cbea707
Compare
HPezz
force-pushed
the
hugo/feature/Add-MotionKit
branch
4 times, most recently
from
7f8a751
to
6dcfede
Compare
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
cbea707
to
dbd4840
Compare
HPezz
force-pushed
the
hugo/feature/Add-MotionKit
branch
from
6dcfede
to
fc28e5c
Compare
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
dbd4840
to
cdc4b6b
Compare
ladislas
approved these changes
Dec 8, 2022
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
cdc4b6b
to
796e3ef
Compare
HPezz
changed the base branch from
develop
to
hugo/feature/Shut-unexpected-MotionKit-calls
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
796e3ef
to
2c4c9ac
Compare
YannLocatelli
approved these changes
Dec 9, 2022
Comment on lines
90
to
93
| EXPECT_CALL(mock_ears, setColor).Times(AnyNumber()); | ||
| EXPECT_CALL(mock_ears, show).Times(AnyNumber()); | ||
| EXPECT_CALL(mock_belt, setColor).Times(AnyNumber()); | ||
| EXPECT_CALL(mock_belt, show).Times(AnyNumber()); |
There was a problem hiding this comment.
Okay, I didn't understand how LEDs are related to MotionKit, but it is not. You just fix the UNEXPECTED_CALL there.
There was a problem hiding this comment.
@HPezz can you put those in a function like we do in other tests:
EXPECT_CALL(mock_ears, setColor).Times(AnyNumber());
EXPECT_CALL(mock_ears, show).Times(AnyNumber());
EXPECT_CALL(mock_belt, setColor).Times(AnyNumber());
EXPECT_CALL(mock_belt, show).Times(AnyNumber());
| static constexpr auto reinforcer_duration = 2700ms; | ||
| static constexpr auto reinforcer_duration = 5s; |
There was a problem hiding this comment.
Why did the duration double?
ladislas
requested changes
Dec 9, 2022
spikes/lk_reinforcer/main.cpp
Outdated
Comment on lines
86
to
87
| auto ears = CoreLED<LedKit::kNumberOfLedsEars> {spi::ears}; | ||
| auto belt = CoreLED<LedKit::kNumberOfLedsBelt> {spi::belt}; |
There was a problem hiding this comment.
I would prefer you keep this part as it is.
the old form is used everywhere.
if we want to refactor this, let's do it in another PR (not sure it's important now though)
Comment on lines
90
to
93
| EXPECT_CALL(mock_ears, setColor).Times(AnyNumber()); | ||
| EXPECT_CALL(mock_ears, show).Times(AnyNumber()); | ||
| EXPECT_CALL(mock_belt, setColor).Times(AnyNumber()); | ||
| EXPECT_CALL(mock_belt, show).Times(AnyNumber()); |
There was a problem hiding this comment.
@HPezz can you put those in a function like we do in other tests:
EXPECT_CALL(mock_ears, setColor).Times(AnyNumber());
EXPECT_CALL(mock_ears, show).Times(AnyNumber());
EXPECT_CALL(mock_belt, setColor).Times(AnyNumber());
EXPECT_CALL(mock_belt, show).Times(AnyNumber());
aeee3c5
to
94c5f4b
Compare
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
2c4c9ac
to
2b0da30
Compare
HPezz
force-pushed
the
hugo/feature/Shut-unexpected-MotionKit-calls
branch
from
94c5f4b
to
28387fe
Compare
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
2b0da30
to
1478752
Compare
HPezz
force-pushed
the
hugo/feature/Shut-unexpected-MotionKit-calls
branch
from
28387fe
to
2e45165
Compare
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
1478752
to
a2219bb
Compare
ladislas
force-pushed
the
hugo/feature/Shut-unexpected-MotionKit-calls
branch
from
2e45165
to
246d3ac
Compare
Base automatically changed from
hugo/feature/Shut-unexpected-MotionKit-calls
to
develop
December 9, 2022 15:02
HPezz
force-pushed
the
hugo/feature/Use-MotionKit-in-ReinforcerKit
branch
from
a2219bb
to
94c3859
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving reinforcers now use MotionKit to execute a perfect 1080 rotation