✨ (eventqueue): Add cancelLastCall #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1252 +/- ##
===========================================
- Coverage 96.21% 96.19% -0.02%
===========================================
Files 146 146
Lines 3617 3601 -16
===========================================
- Hits 3480 3464 -16
Misses 137 137
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
ladislas
requested changes
Jan 13, 2023
| } | ||
|
|
||
| void cancelLastCall() { _event_queue.cancel(_event_id); } |
There was a problem hiding this comment.
I would just use cancel
Suggested change
| void cancelLastCall() { _event_queue.cancel(_event_id); } | |
| void cancel() { _event_queue.cancel(_event_id); } |
in the future we could have call return the id to be able to cancel(id) and share an event queue between different callbacks
what happens if we call call_every multiple times? will the queue call all the callback at the desired interval?
if so, then we should first cancel before using _event_queue.call or _event_queue.call_every
_event_id can be an optional to handle the case where cancel is called before call_every has been called.
| @@ -18,19 +18,23 @@ class CoreEventQueue : public interface::EventQueue | |||
|
|
|||
| void dispatch_forever() final; | |||
|
|
|||
| void call(auto f, auto... params) { _event_queue.call(f, params...); } | |||
| void call(auto f, auto... params) { _event_id = _event_queue.call(f, params...); } | |||
There was a problem hiding this comment.
here, the _event_id is not really needed and could even introduce bugs.
_event_queue.call will dispatch the event as soon as it's called .
per mbed documentation, when the event is dispatched, the id is not valid anymore and
It is not safe to call cancel after an event has already been dispatched.
id must be valid i.e. event must have not finished executing.
so calling call and then cancel might break the program.
cancel is only really needed for call_every or call_in
YannLocatelli
force-pushed
the
yann/feature/coreeventqueue/add-cancel-last-call
branch
from
7df2d93
to
4c255da
Compare
YannLocatelli
force-pushed
the
yann/feature/coreeventqueue/add-cancel-last-call
branch
from
4c255da
to
f32cafb
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.