Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmyster/feature/add touch sensor kit #830

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

MMyster
Copy link
Contributor

@MMyster MMyster commented Jun 3, 2022

@MMyster MMyster marked this pull request as draft June 3, 2022 12:52
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #830 (af9b519) into develop (8d90b63) will decrease coverage by 0.06%.
The diff coverage is 95.83%.

❗ Current head af9b519 differs from pull request most recent head 32e6d8a. Consider uploading reports for the commit 32e6d8a to get more accurate results

@@             Coverage Diff             @@
##           develop     #830      +/-   ##
===========================================
- Coverage    96.21%   96.14%   -0.07%     
===========================================
  Files          146      148       +2     
  Lines         3617     3688      +71     
===========================================
+ Hits          3480     3546      +66     
- Misses         137      142       +5     
Impacted Files Coverage Δ
libs/TouchSensorKit/source/TouchSensorKit.cpp 95.29% <95.29%> (ø)
drivers/CoreEventQueue/include/CoreEventQueue.h 100.00% <100.00%> (ø)
libs/TouchSensorKit/include/TouchSensorKit.h 100.00% <100.00%> (ø)
libs/RobotKit/include/RobotController.h 94.13% <0.00%> (-0.51%) ⬇️
libs/BLEKit/source/BLEKit.cpp 100.00% <0.00%> (ø)
libs/BLEKit/source/CoreGap.cpp 100.00% <0.00%> (ø)
libs/RobotKit/include/StateMachine.h 100.00% <0.00%> (ø)
libs/BehaviorKit/source/BehaviorKit.cpp 100.00% <0.00%> (ø)
libs/BLEKit/source/CoreGapEventHandler.cpp 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

File comparision analysis report

🔖 Info

Target Flash Used (base/head) Fash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 170348 (64%) ø 91796 (35%)
91796 (35%)
30952 (5%) ø
os 434312 (27%) ø 1130360 (72%)
1130360 (72%)
83064 (15%) ø
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 434312 (20%) ø 83064 (15%) ø
bootloader ✔️ 170348 (8%) ø 30952 (5%) ø
functional_ut_boost_ut ✔️ 394076 (18%) ø 20456 (3%) ø
functional_ut_core_imu ✔️ 377068 (17%) ø 20432 (3%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ 360236 (17%) ø 20440 (3%) ø
functional_ut_deep_sleep_core_motor ✔️ 364476 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_core_pwm ✔️ 366612 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ 352504 (16%) ø 20408 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ 354216 (16%) ø 20408 (3%) ø
functional_ut_file_manager ✔️ 374864 (17%) ø 20696 (3%) ø
functional_ut_firmware_kit ✔️ 366540 (17%) ø 20688 (3%) ø
functional_ut_imu_kit ✔️ 382560 (18%) ø 20424 (3%) ø
functional_ut_io_expander ✔️ 359232 (17%) ø 20424 (3%) ø
functional_ut_qdac ✔️ 360400 (17%) ø 20424 (3%) ø
spike_lk_accel_gyro ✔️ 71184 (3%) ø 11808 (2%) ø
spike_lk_audio ✔️ 126924 (6%) ø 14600 (2%) ø
spike_lk_behavior_kit ✔️ 189000 (9%) ø 48080 (9%) ø
spike_lk_ble ✔️ 229600 (10%) ø 28472 (5%) ø
spike_lk_bluetooth ✔️ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ 145848 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ 65776 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ 209184 (9%) ø 52032 (9%) ø
spike_lk_config_kit ✔️ 127268 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ 76164 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ 80228 (3%) ø 12256 (2%) ø
spike_lk_event_queue ✔️ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ 139336 (6%) ø 14440 (2%) ø
spike_lk_file_reception ✔️ 335792 (16%) ø 27792 (5%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ 175144 (8%) ø 47904 (9%) ø
spike_lk_imu_kit ✔️ 87700 (4%) ø 12176 (2%) ø
spike_lk_lcd ✔️ 162732 (7%) ø 46664 (8%) ø
spike_lk_led_kit ✔️ 103360 (4%) ø 14528 (2%) ø
spike_lk_log_kit ✔️ 63288 (3%) ø 12256 (2%) ø
spike_lk_motion_kit ✔️ 101764 (4%) ø 14288 (2%) ø
spike_lk_motors ✔️ 62864 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ 78628 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ 206416 (9%) ø 49224 (9%) ø
spike_lk_rfid ✔️ 78956 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ 133020 (6%) ø 14304 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ 145100 (6%) ø 15584 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ 80068 (3%) ø 13272 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

File comparision analysis report

🔖 Info

Target Flash Used (base/head) Fash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 182804 (69%) ø 79340 (30%)
79340 (30%)
41648 (7%) ø
os 495284 (31%) ø 1069388 (68%)
1069388 (68%)
94280 (17%) ø
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 495284 (23%) ø 94280 (17%) ø
bootloader ✔️ 182804 (8%) ø 41648 (7%) ø
functional_ut_boost_ut ✔️ 409212 (19%) ø 30608 (5%) ø
functional_ut_core_imu ✔️ 389196 (18%) ø 30584 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ 368140 (17%) ø 30560 (5%) ø
functional_ut_deep_sleep_core_motor ✔️ 376076 (17%) ø 30632 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ 378292 (18%) ø 30632 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ 365204 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ 366648 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ 386684 (18%) ø 30856 (5%) ø
functional_ut_firmware_kit ✔️ 378068 (18%) ø 30840 (5%) ø
functional_ut_imu_kit ✔️ 391388 (18%) ø 30576 (5%) ø
functional_ut_io_expander ✔️ 370896 (17%) ø 30576 (5%) ø
functional_ut_qdac ✔️ 372064 (17%) ø 30576 (5%) ø
spike_lk_accel_gyro ✔️ 94048 (4%) ø 22568 (4%) ø
spike_lk_audio ✔️ 137044 (6%) ø 25176 (4%) ø
spike_lk_behavior_kit ✔️ 197564 (9%) ø 58656 (11%) ø
spike_lk_ble ✔️ 237916 (11%) ø 39416 (7%) ø
spike_lk_bluetooth ✔️ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ 153608 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ 88480 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ 219508 (10%) ø 63120 (12%) ø
spike_lk_config_kit ✔️ 139244 (6%) ø 25136 (4%) ø
spike_lk_coreled ✔️ 88044 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ 92884 (4%) ø 22832 (4%) ø
spike_lk_event_queue ✔️ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ 154368 (7%) ø 25520 (4%) ø
spike_lk_file_reception ✔️ 339748 (16%) ø 38448 (7%) ø
spike_lk_flash_memory ✔️ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ 174440 (8%) ø 47992 (9%) ø
spike_lk_imu_kit ✔️ 97920 (4%) ø 22896 (4%) ø
spike_lk_lcd ✔️ 172652 (8%) ø 57496 (10%) ø
spike_lk_led_kit ✔️ 115140 (5%) ø 25104 (4%) ø
spike_lk_log_kit ✔️ 84776 (4%) ø 23408 (4%) ø
spike_lk_motion_kit ✔️ 106736 (5%) ø 24840 (4%) ø
spike_lk_motors ✔️ 86336 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ 91572 (4%) ø 22776 (4%) ø
spike_lk_reinforcer ✔️ 215044 (10%) ø 59800 (11%) ø
spike_lk_rfid ✔️ 84088 (4%) ø 22184 (4%) ø
spike_lk_sensors_battery ✔️ 87184 (4%) ø 23280 (4%) ø
spike_lk_sensors_light ✔️ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ 90400 (4%) ø 22192 (4%) ø
spike_lk_sensors_touch ✔️ 91672 (4%) ø 22456 (4%) ø
spike_lk_serial_number ✔️ 144900 (6%) ø 25256 (4%) ø
spike_lk_ticker_timeout ✔️ 82712 (3%) ø 22232 (4%) ø
spike_lk_update_process_app_base ✔️ 156876 (7%) ø 26288 (5%) ø
spike_lk_update_process_app_update ✔️ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ 87392 (4%) ø 24120 (4%) ø
spike_lk_wifi ✔️ 130832 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@MMyster MMyster force-pushed the mmyster/feature/add-touch-sensor-kit branch from d4fa5bf to fcd035a Compare June 20, 2022 10:41
@MMyster MMyster marked this pull request as ready for review June 20, 2022 11:03
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficile de review en l'état

Ajoutes dans la description de la PR les autres PR qui doivent être merged avant de pouvoir merge celle-ci

spikes/lk_touch_sensor_kit/CMakeLists.txt Outdated Show resolved Hide resolved
libs/TouchSensorKit/CMakeLists.txt Show resolved Hide resolved
libs/TouchSensorKit/include/TouchSensorKit.h Show resolved Hide resolved
@ladislas ladislas added the 01 - type: task Something to do label Jun 23, 2022
@ladislas ladislas added this to the Next Release milestone Jun 23, 2022
@ladislas ladislas linked an issue Jun 23, 2022 that may be closed by this pull request
5 tasks
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

premier passage avant les rebases

libs/TouchSensorKit/include/TouchSensorKit.h Show resolved Hide resolved
libs/TouchSensorKit/include/internal/TouchSensorSystem.h Outdated Show resolved Hide resolved
libs/TouchSensorKit/include/internal/TouchSensorSystem.h Outdated Show resolved Hide resolved
@MMyster MMyster force-pushed the mmyster/feature/add-touch-sensor-kit branch 4 times, most recently from 4688799 to 2ac100d Compare June 28, 2022 13:18
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@MMyster MMyster force-pushed the mmyster/feature/add-touch-sensor-kit branch from 2ac100d to f1518e5 Compare July 13, 2022 14:10
@YannLocatelli YannLocatelli changed the base branch from develop to mmyster/feature/add-core-touch-sensor July 13, 2022 14:20
@MMyster MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch from cbb244c to 1991586 Compare July 13, 2022 15:42
@MMyster MMyster force-pushed the mmyster/feature/add-touch-sensor-kit branch from f1518e5 to fd4b484 Compare July 13, 2022 15:43
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un premier passage

libs/TouchSensorKit/include/TouchSensorKit.h Outdated Show resolved Hide resolved
libs/TouchSensorKit/include/TouchSensorKit.h Outdated Show resolved Hide resolved
@MMyster MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch from 1991586 to 1856439 Compare July 15, 2022 13:16
@MMyster MMyster force-pushed the mmyster/feature/add-touch-sensor-kit branch 2 times, most recently from 6459baa to b2ffa51 Compare July 19, 2022 13:46
@MMyster MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch 2 times, most recently from 9ce5128 to d4247be Compare July 20, 2022 09:39
@MMyster MMyster force-pushed the mmyster/feature/add-touch-sensor-kit branch 4 times, most recently from b66440a to 6655d87 Compare November 27, 2022 22:25
@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@YannLocatelli YannLocatelli force-pushed the mmyster/feature/add-touch-sensor-kit branch 3 times, most recently from db40cd6 to 0adc261 Compare January 12, 2023 16:46
@YannLocatelli
Copy link
Member

Usage of std::map seems to add 960 bytes

@YannLocatelli YannLocatelli force-pushed the mmyster/feature/add-touch-sensor-kit branch 2 times, most recently from e9d584c to d457dbc Compare January 12, 2023 17:37
@YannLocatelli YannLocatelli self-assigned this Jan 12, 2023
@YannLocatelli YannLocatelli force-pushed the mmyster/feature/add-touch-sensor-kit branch 4 times, most recently from c105912 to c5ad5bf Compare January 13, 2023 10:10
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

can the event queue changes be moved to another PR first?

}

void cancelLastCall() { _event_queue.cancel(_event_id); }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice change! could you make it in a separate PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YannLocatelli YannLocatelli force-pushed the mmyster/feature/add-touch-sensor-kit branch from c5ad5bf to 1368065 Compare January 13, 2023 13:33
@YannLocatelli YannLocatelli changed the base branch from develop to yann/feature/coreeventqueue/add-cancel-last-call January 13, 2023 13:34
@YannLocatelli YannLocatelli force-pushed the yann/feature/coreeventqueue/add-cancel-last-call branch 2 times, most recently from 4c255da to f32cafb Compare January 13, 2023 15:22
@YannLocatelli YannLocatelli force-pushed the mmyster/feature/add-touch-sensor-kit branch 2 times, most recently from a744141 to 88f9b6a Compare January 13, 2023 15:24
Base automatically changed from yann/feature/coreeventqueue/add-cancel-last-call to develop January 13, 2023 15:29
Co-Authored-By: YannL <yann.locatelli2@gmail.com>
@YannLocatelli YannLocatelli force-pushed the mmyster/feature/add-touch-sensor-kit branch from 88f9b6a to 32e6d8a Compare January 13, 2023 15:38
@ladislas ladislas merged commit 3ad9a78 into develop Jan 13, 2023
@ladislas ladislas deleted the mmyster/feature/add-touch-sensor-kit branch January 13, 2023 15:46
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - type: task Something to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TouchSensorKit - Make Touch Sensor works
3 participants