-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mmyster/feature/add touch sensor kit #830
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #830 +/- ##
===========================================
- Coverage 96.21% 96.14% -0.07%
===========================================
Files 146 148 +2
Lines 3617 3688 +71
===========================================
+ Hits 3480 3546 +66
- Misses 137 142 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
d4fa5bf
to
fcd035a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Difficile de review en l'état
Ajoutes dans la description de la PR les autres PR qui doivent être merged avant de pouvoir merge celle-ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
premier passage avant les rebases
4688799
to
2ac100d
Compare
Kudos, SonarCloud Quality Gate passed! |
2ac100d
to
f1518e5
Compare
cbb244c
to
1991586
Compare
f1518e5
to
fd4b484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
un premier passage
1991586
to
1856439
Compare
6459baa
to
b2ffa51
Compare
9ce5128
to
d4247be
Compare
b66440a
to
6655d87
Compare
SonarCloud Quality Gate failed. |
db40cd6
to
0adc261
Compare
Usage of |
e9d584c
to
d457dbc
Compare
c105912
to
c5ad5bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
can the event queue changes be moved to another PR first?
} | ||
|
||
void cancelLastCall() { _event_queue.cancel(_event_id); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice change! could you make it in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c5ad5bf
to
1368065
Compare
4c255da
to
f32cafb
Compare
a744141
to
88f9b6a
Compare
Co-Authored-By: YannL <yann.locatelli2@gmail.com>
88f9b6a
to
32e6d8a
Compare
Kudos, SonarCloud Quality Gate passed! |
Requirements