mmyster/feature/add core touch sensor #925

MMyster · 2022-06-28T11:20:15Z

✨ (drivers): Add CoreTouchSensor

Need

codecov · 2022-06-28T11:30:20Z

Codecov Report

Merging #925 (24f6655) into develop (f66b540) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 24f6655 differs from pull request most recent head 14245cc. Consider uploading reports for the commit 14245cc to get more accurate results

@@             Coverage Diff             @@
##           develop     #925      +/-   ##
===========================================
+ Coverage    95.98%   96.01%   +0.03%     
===========================================
  Files          127      129       +2     
  Lines         2963     2987      +24     
===========================================
+ Hits          2844     2868      +24     
  Misses         119      119

Impacted Files	Coverage Δ
drivers/CoreTouchSensor/include/CoreTouchSensor.h	`100.00% <100.00%> (ø)`
drivers/CoreTouchSensor/source/CoreTouchSensor.cpp	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2022-06-28T11:34:12Z

File comparision analysis report

🔖 Info

base: develop / 5d6fb17 + mbed-os-6.15.1+fixes + -std=c++20
head: mmyster/feature/add-core-touch-sensor / 5d6fb17 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	168820 (64%)	93324 (35%)	30920 (5%)
os	363560 (23%)	1201112 (76%)	73712 (14%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	363560 (17%)	ø	73712 (14%)	ø
bootloader	✔️	✅	✅	168820 (8%)	ø	30920 (5%)	ø
spike_lk_audio	✔️	✅	✅	122324 (5%)	ø	14568 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	187568 (8%)	ø	48112 (9%)	ø
spike_lk_ble	✔️	✅	✅	225792 (10%)	ø	28056 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	144632 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65712 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	189760 (9%)	ø	50928 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	124188 (5%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	128680 (6%)	ø	14384 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	326968 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	171728 (8%)	ø	47880 (9%)	ø
spike_lk_lcd	✔️	✅	✅	167468 (7%)	ø	47320 (9%)	ø
spike_lk_led_kit	✔️	✅	✅	103992 (4%)	ø	14608 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63736 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62600 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✔️	✅	✅	78564 (3%)	ø	11816 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	103480 (4%)	ø	14608 (2%)	ø
spike_lk_rfid	✔️	✅	✅	80920 (3%)	ø	11520 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	58904 (2%)	ø	11480 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	122804 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	82032 (3%)	ø	13288 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

github-actions · 2022-06-28T11:34:53Z

File comparision analysis report

🔖 Info

base: develop / 5d6fb17 + mbed-os-6.15.1+fixes + -std=c++20
head: mmyster/feature/add-core-touch-sensor / 5d6fb17 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	181260 (69%)	80884 (30%)	37456 (7%)
os	396956 (25%)	1167716 (74%)	80640 (15%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	396956 (18%)	ø	80640 (15%)	ø
bootloader	✔️	✅	✅	181260 (8%)	ø	37456 (7%)	ø
spike_lk_audio	✔️	✅	✅	132380 (6%)	ø	20984 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	196052 (9%)	ø	54528 (10%)	ø
spike_lk_ble	✔️	✅	✅	233676 (11%)	ø	34712 (6%)	ø
spike_lk_bluetooth	✔️	✅	✅	92236 (4%)	ø	18064 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	152200 (7%)	ø	53064 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88352 (4%)	ø	20216 (3%)	ø
spike_lk_command_kit	✔️	✅	✅	199956 (9%)	ø	57856 (11%)	ø
spike_lk_config_kit	✔️	✅	✅	136100 (6%)	ø	20976 (4%)	ø
spike_lk_coreled	✔️	✅	✅	87916 (4%)	ø	20104 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84088 (4%)	ø	18744 (3%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	143648 (6%)	ø	21304 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	331036 (15%)	ø	34072 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	86712 (4%)	ø	18056 (3%)	ø
spike_lk_fs	✔️	✅	✅	171024 (8%)	ø	47968 (9%)	ø
spike_lk_lcd	✔️	✅	✅	177100 (8%)	ø	53992 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115708 (5%)	ø	21024 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84440 (4%)	ø	19248 (3%)	ø
spike_lk_motors	✔️	✅	✅	86008 (4%)	ø	18088 (3%)	ø
spike_lk_qdac	✔️	✅	✅	91508 (4%)	ø	18616 (3%)	ø
spike_lk_reinforcer	✔️	✅	✅	112188 (5%)	ø	21024 (4%)	ø
spike_lk_rfid	✔️	✅	✅	84636 (4%)	ø	18024 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87056 (4%)	ø	19120 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	83944 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84696 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90336 (4%)	ø	18032 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91608 (4%)	ø	18296 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	82176 (3%)	ø	18336 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82584 (3%)	ø	18072 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	144644 (6%)	ø	21896 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100328 (4%)	ø	19080 (3%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87940 (4%)	ø	19960 (3%)	ø
spike_lk_wifi	✔️	✅	✅	130640 (6%)	ø	21368 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84112 (4%)	ø	18920 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83424 (3%)	ø	18144 (3%)	ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

drivers/CoreTouchSensor/include/CoreTouchSensor.h

YannLocatelli · 2022-07-15T10:45:33Z

drivers/CoreTouchSensor/include/CoreTouchSensor.h

+	}
+	auto read() -> int;
+	void setPowerMode(uint8_t power_mode);
+	void adjustSensitivity(uint16_t value, bool saved = false);


saved parameter is linked to the component used.

For now, I think we are ok with it but in long term not sure it will remain.

drivers/CoreTouchSensor/tests/CoreTouchSensor_test.cpp

YannLocatelli

Un spike est le bienvenue~

tests/unit/mocks/mocks/leka/CoreQDAC.h

drivers/CoreTouchSensor/tests/CoreTouchSensor_test.cpp

drivers/CoreTouchSensor/include/CoreTouchSensor.h

YannLocatelli

Dernière remarque, après c'est bon pour moi ✅

drivers/CoreTouchSensor/source/CoreTouchSensor.cpp

ladislas

LGTM! 👍

sonarcloud · 2022-09-05T14:39:02Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch 2 times, most recently from 5983186 to 6efc311 Compare June 28, 2022 13:39

MMyster linked an issue Jun 28, 2022 that may be closed by this pull request

TouchSensorKit - Make Touch Sensor works #825

Closed

5 tasks

MMyster added this to the Next Release milestone Jun 28, 2022

MMyster added the 01 - type: task Something to do label Jun 28, 2022

MMyster self-assigned this Jun 28, 2022

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch 2 times, most recently from f0bdebe to cbb244c Compare July 13, 2022 14:09

This was referenced Jul 13, 2022

mmyster/feature/add touch sensor kit #830

Merged

mmyster/feature/add lk touch sensor kit #926

Merged

YannLocatelli changed the base branch from develop to mmyster/feature/quad-digital-to-analog-converter July 13, 2022 14:19

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch from cbb244c to 1991586 Compare July 13, 2022 15:42

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from 13ba488 to ac18117 Compare July 15, 2022 07:44

YannLocatelli requested changes Jul 15, 2022

View reviewed changes

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch from 1991586 to 1856439 Compare July 15, 2022 13:16

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch 5 times, most recently from 00972cd to e6ca578 Compare July 19, 2022 13:33

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch 3 times, most recently from d4247be to f5ab227 Compare July 20, 2022 10:00

YannLocatelli requested changes Jul 21, 2022

View reviewed changes

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from e6ca578 to ed3cfbb Compare July 21, 2022 14:42

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch from f5ab227 to 2972c86 Compare July 21, 2022 14:44

MMyster mentioned this pull request Jul 22, 2022

mmyster/feature/lk core touch sensor #947

Merged

1 task

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch 3 times, most recently from 54d2188 to e98e385 Compare July 26, 2022 08:46

YannLocatelli requested changes Jul 27, 2022

View reviewed changes

drivers/CoreTouchSensor/source/CoreTouchSensor.cpp Outdated Show resolved Hide resolved

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch 2 times, most recently from 5685ef2 to 02c6812 Compare July 27, 2022 09:50

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from ed3cfbb to c8e19a2 Compare August 1, 2022 14:46

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch from 02c6812 to 137ca2b Compare August 1, 2022 14:46

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch 2 times, most recently from adfa308 to cfeffdf Compare August 18, 2022 16:06

ladislas force-pushed the mmyster/feature/quad-digital-to-analog-converter branch 2 times, most recently from 0109d91 to 0933a53 Compare August 18, 2022 16:16

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch 2 times, most recently from a386303 to f5edd63 Compare August 24, 2022 13:34

MMyster changed the base branch from mmyster/feature/quad-digital-to-analog-converter to develop August 24, 2022 14:25

ladislas approved these changes Sep 5, 2022

View reviewed changes

MMyster force-pushed the mmyster/feature/add-core-touch-sensor branch from dae583a to 24f6655 Compare September 5, 2022 14:11

MMyster and others added 3 commits September 5, 2022 16:18

✨ (interface): Add TouchSensor

54d6c70

✨ (drivers): Add CoreTouchSensor

961b0e8

🤡 (mocks): Mock CoreTouchSensor

14245cc

ladislas force-pushed the mmyster/feature/add-core-touch-sensor branch from 24f6655 to 14245cc Compare September 5, 2022 14:27

ladislas merged commit 5d6fb17 into develop Sep 5, 2022

ladislas deleted the mmyster/feature/add-core-touch-sensor branch September 5, 2022 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mmyster/feature/add core touch sensor #925

mmyster/feature/add core touch sensor #925

MMyster commented Jun 28, 2022 •

edited

Loading

codecov bot commented Jun 28, 2022 •

edited

Loading

github-actions bot commented Jun 28, 2022 •

edited

Loading

github-actions bot commented Jun 28, 2022 •

edited

Loading

YannLocatelli Jul 15, 2022

YannLocatelli left a comment

YannLocatelli left a comment

ladislas left a comment

sonarcloud bot commented Sep 5, 2022

mmyster/feature/add core touch sensor #925

mmyster/feature/add core touch sensor #925

Conversation

MMyster commented Jun 28, 2022 • edited Loading

codecov bot commented Jun 28, 2022 • edited Loading

Codecov Report

github-actions bot commented Jun 28, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Jun 28, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

YannLocatelli Jul 15, 2022

Choose a reason for hiding this comment

YannLocatelli left a comment

Choose a reason for hiding this comment

YannLocatelli left a comment

Choose a reason for hiding this comment

ladislas left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Sep 5, 2022

MMyster commented Jun 28, 2022 •

edited

Loading

codecov bot commented Jun 28, 2022 •

edited

Loading

github-actions bot commented Jun 28, 2022 •

edited

Loading

github-actions bot commented Jun 28, 2022 •

edited

Loading