Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (micro): Correct rms_buffer access and fit logs to the use #434

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

YannLocatelli
Copy link
Member

No description provided.

@YannLocatelli YannLocatelli self-assigned this Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #434 (f27ecd9) into develop (f82bf1d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #434   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        66           
  Lines         1188      1188           
=========================================
  Hits          1188      1188           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82bf1d...f27ecd9. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 19, 2022

File comparision analysis report

🔖 Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / f82bf1d + mbed-os-6.15.1 + -std=c++20
  • head: yann/bug/microphone/array-access / f27ecd9 + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: OFF

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 58328 (2%) ø 11400 (2%) ø
bootloader ✔️ 95024 (4%) ø 26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 234668 (11%) ø 30056 (5%) ø
certs_emc_ble_led_motors ✔️ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ 162616 (7%) ø 22792 (4%) ø
spike_lk_bluetooth ✔️ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ 141064 (6%) ø 24464 (4%) ø
spike_lk_file_manager ✔️ 109588 (5%) ø 13672 (2%) ø
spike_lk_file_reception ✔️ 328916 (15%) ø 19312 (3%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ 136928 (6%) ø 24016 (4%) ø
spike_lk_led ✔️ 65744 (3%) ø 13392 (2%) ø
spike_lk_log_kit ✔️ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ 60280 (2%) ø 11440 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72860 (3%)
72496 (3%)
📉
-364 (0%)
11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_update_process_app_base ✔️ 121572 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77720 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_sensors_microphone (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_sensors_microphone-map.txt	2022-01-20 14:20:22.643238246 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_sensors_microphone-map.txt	2022-01-20 14:20:22.839239561 +0000
@@ -1,17 +1,17 @@
 | Module                   |         .text |       .data |        .bss |
 |--------------------------|---------------|-------------|-------------|
-| [fill]                   |     114(+114) |       8(+8) |     20(+20) |
+| [fill]                   |     156(+156) |       8(+8) |     20(+20) |
 | [lib]/HelloWorld.a       |       94(+94) |       0(+0) |       0(+0) |
 | [lib]/LKCoreMicrophone.a |         4(+4) |       0(+0) |       0(+0) |
 | [lib]/c.a                | 26028(+26028) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a              |   6924(+6924) |       0(+0) |       0(+0) |
 | [lib]/m.a                |       88(+88) |       0(+0) |       0(+0) |
-| [lib]/mbed-os-static.a   | 25336(+25336) |   444(+444) | 8130(+8130) |
+| [lib]/mbed-os-static.a   | 25316(+25316) |   444(+444) | 8130(+8130) |
 | [lib]/misc               |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a            |       32(+32) |       0(+0) |       0(+0) |
-| [lib]/stdc++.a           |   5356(+5356) |       8(+8) |     44(+44) |
-| main.cpp.obj             |     320(+320) |       0(+0) |       0(+0) |
-| Subtotals                | 64484(+64484) | 2936(+2936) | 8280(+8280) |
+| [lib]/stdc++.a           |   4760(+4760) |       8(+8) |     44(+44) |
+| main.cpp.obj             |     766(+766) |       0(+0) |       0(+0) |
+| Subtotals                | 64356(+64356) | 2936(+2936) | 8280(+8280) |
 Total Static RAM memory (data + bss): 11216(+11216) bytes
-Total Flash memory (text + data): 67420(+67420) bytes
+Total Flash memory (text + data): 67292(+67292) bytes
 
Flash used: 72496&nbsp;(3%) / total: 2097152
SRAM used: 11504&nbsp;(2%) / total: 524288

@github-actions
Copy link

github-actions bot commented Jan 19, 2022

File comparision analysis report

🔖 Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / f82bf1d + mbed-os-6.15.1 + -std=c++20
  • head: yann/bug/microphone/array-access / f27ecd9 + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: ON

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 82200 (3%) ø 17472 (3%) ø
bootloader ✔️ 95024 (4%) ø 26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 251132 (11%) ø 36144 (6%) ø
certs_emc_ble_led_motors ✔️ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ 183688 (8%) ø 28856 (5%) ø
spike_lk_bluetooth ✔️ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ 149336 (7%) ø 30464 (5%) ø
spike_lk_file_manager ✔️ 132396 (6%) ø 19912 (3%) ø
spike_lk_file_reception ✔️ 333692 (15%) ø 25272 (4%) ø
spike_lk_flash_memory ✔️ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ 149808 (7%) ø 30088 (5%) ø
spike_lk_led ✔️ 88808 (4%) ø 19400 (3%) ø
spike_lk_log_kit ✔️ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ 85088 (4%) ø 17512 (3%) ø
spike_lk_sensors_light ✔️ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ 85516 (4%)
85336 (4%)
📉
-180 (0%)
17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ 92248 (4%) ø 17632 (3%) ø
spike_lk_update_process_app_base ✔️ 144052 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ 101120 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_sensors_microphone (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_sensors_microphone-map.txt	2022-01-20 14:20:38.675560619 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_sensors_microphone-map.txt	2022-01-20 14:20:38.903557801 +0000
@@ -1,18 +1,18 @@
 | Module                   |         .text |       .data |          .bss |
 |--------------------------|---------------|-------------|---------------|
-| [fill]                   |     144(+144) |       8(+8) |       20(+20) |
+| [fill]                   |     134(+134) |       8(+8) |       20(+20) |
 | [lib]/CriticalSection.a  |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a       |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/LKCoreMicrophone.a |         4(+4) |       0(+0) |         0(+0) |
 | [lib]/c.a                | 26052(+26052) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a              |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                |     448(+448) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a   | 33042(+33042) |   444(+444) |   8178(+8178) |
+| [lib]/mbed-os-static.a   | 33022(+33022) |   444(+444) |   8178(+8178) |
 | [lib]/misc               |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a            |       32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a           |   5864(+5864) |       8(+8) |       44(+44) |
-| main.cpp.obj             |   2516(+2516) |       0(+0) |   5960(+5960) |
+| [lib]/stdc++.a           |   5424(+5424) |       8(+8) |       44(+44) |
+| main.cpp.obj             |   2986(+2986) |       0(+0) |   5960(+5960) |
 | Subtotals                | 75540(+75540) | 2936(+2936) | 14288(+14288) |
 Total Static RAM memory (data + bss): 17224(+17224) bytes
 Total Flash memory (text + data): 78476(+78476) bytes
 
Flash used: 85336&nbsp;(4%) / total: 2097152
SRAM used: 17512&nbsp;(3%) / total: 524288

@ladislas ladislas force-pushed the yann/bug/microphone/array-access branch from 0ba7eb3 to f27ecd9 Compare January 20, 2022 14:13
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ladislas ladislas merged commit 856d285 into develop Jan 20, 2022
@ladislas ladislas deleted the yann/bug/microphone/array-access branch January 20, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants