✨ (ble): Add CoreGattServer #485

YannLocatelli · 2022-02-07T14:51:27Z

Découpage en plusieurs PR: #486 #489 #490

github-actions · 2022-02-07T14:57:42Z

File comparision analysis report

🔖 Info

base: develop / 5b30162 + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/ble/gatt/add-server / b5cde18 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	137588 (52%)	124556 (47%)	29360 (5%)
os	74772 (4%)	1489900 (95%)	12328 (2%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	74772 (3%)	ø	12328 (2%)	ø
bootloader	✔️	✅	✅	137588 (6%)	ø	29360 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	249184 (11%)	ø	29240 (5%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	174568 (8%)	ø	24952 (4%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	148840 (7%)	ø	22528 (4%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	177960 (8%)	ø	24360 (4%)	ø
spike_lk_ble	✔️	❌	❌	169340 (8%) 173252 (8%)	📈 3912 (2%)	23160 (4%) 23336 (4%)	📈 176 (0%)
spike_lk_bluetooth	✔️	✅	✅	73256 (3%)	ø	11448 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	141112 (6%)	ø	24464 (4%)	ø
spike_lk_coreled	✔️	❌	❌	76164 (3%) 75764 (3%)	📉 -400 (0%)	13688 (2%) 13664 (2%)	📉 -24 (0%)
spike_lk_event_queue	✔️	❌	❌	74736 (3%) 73452 (3%)	📉 -1284 (-1%)	12072 (2%) 11776 (2%)	📉 -296 (-2%)
spike_lk_file_reception	✔️	✅	✅	324516 (15%)	ø	27520 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_lcd	✔️	✅	✅	136976 (6%)	ø	24024 (4%)	ø
spike_lk_led	✔️	✅	✅	65744 (3%)	ø	13392 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	68528 (3%)	ø	11912 (2%)	ø
spike_lk_motors	✔️	✅	✅	62528 (2%)	ø	11488 (2%)	ø
spike_lk_rfid	✔️	✅	✅	73072 (3%)	ø	11448 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	63072 (3%)	ø	11984 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	66968 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	121348 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-02-22 20:57:34.973968781 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-02-22 20:57:35.237968835 +0000
@@ -1,16 +1,16 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       322(+322) |     11(+11) |       70(+70) |
-| [lib]/BLEKit.a         |       798(+798) |       0(+0) |         0(+0) |
-| [lib]/CoreEventQueue.a |       204(+204) |       0(+0) |         0(+0) |
+| [fill]                 |       328(+328) |     15(+15) |       66(+66) |
+| [lib]/BLEKit.a         |     1082(+1082) |       0(+0) |         0(+0) |
+| [lib]/CoreEventQueue.a |       358(+358) |       0(+0) |         0(+0) |
 | [lib]/c.a              |   26128(+26128) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |     7084(+7084) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a | 115844(+115844) |   689(+689) | 19084(+19084) |
+| [lib]/mbed-os-static.a | 118728(+118728) |   689(+689) | 19084(+19084) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |     4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj           |       360(+360) |       0(+0) |     420(+420) |
-| Subtotals              | 155076(+155076) | 3184(+3184) | 19688(+19688) |
-Total Static RAM memory (data + bss): 22872(+22872) bytes
-Total Flash memory (text + data): 158260(+158260) bytes
+| main.cpp.obj           |       872(+872) |       4(+4) |     592(+592) |
+| Subtotals              | 158916(+158916) | 3192(+3192) | 19856(+19856) |
+Total Static RAM memory (data + bss): 23048(+23048) bytes
+Total Flash memory (text + data): 162108(+162108) bytes

Flash used: 173252&nbsp;(8%) / total: 2097152
SRAM used: 23336&nbsp;(4%) / total: 524288

spike_lk_coreled (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_coreled-map.txt	2022-02-22 20:57:36.501969091 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_coreled-map.txt	2022-02-22 20:57:36.733969138 +0000
@@ -1,16 +1,16 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     126(+126) |       8(+8) |       26(+26) |
+| [fill]                 |     106(+106) |       8(+8) |       26(+26) |
 | [lib]/CoreSPI.a        |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a     |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/c.a              | 26028(+26028) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   6924(+6924) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a | 26306(+26306) |   444(+444) |   9946(+9946) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |   5356(+5356) |       8(+8) |       44(+44) |
-| main.cpp.obj           |   2026(+2026) |       0(+0) |     362(+362) |
-| Subtotals              | 67108(+67108) | 2936(+2936) | 10464(+10464) |
-Total Static RAM memory (data + bss): 13400(+13400) bytes
-Total Flash memory (text + data): 70044(+70044) bytes
+| main.cpp.obj           |   1662(+1662) |       0(+0) |     338(+338) |
+| Subtotals              | 66724(+66724) | 2936(+2936) | 10440(+10440) |
+Total Static RAM memory (data + bss): 13376(+13376) bytes
+Total Flash memory (text + data): 69660(+69660) bytes

Flash used: 75764&nbsp;(3%) / total: 2097152
SRAM used: 13664&nbsp;(2%) / total: 524288

spike_lk_event_queue (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_event_queue-map.txt	2022-02-22 20:57:37.001969193 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_event_queue-map.txt	2022-02-22 20:57:37.213969236 +0000
@@ -1,15 +1,15 @@
 | Module                 |         .text |       .data |        .bss |
 |------------------------|---------------|-------------|-------------|
-| [fill]                 |     106(+106) |       8(+8) |     20(+20) |
-| [lib]/CoreEventQueue.a |       76(+76) |       0(+0) |       0(+0) |
+| [fill]                 |     120(+120) |       8(+8) |     24(+24) |
+| [lib]/CoreEventQueue.a |     280(+280) |       0(+0) |       0(+0) |
 | [lib]/c.a              | 26028(+26028) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a            |   7084(+7084) |       0(+0) |       0(+0) |
 | [lib]/mbed-os-static.a | 27350(+27350) |   444(+444) | 8098(+8098) |
 | [lib]/misc             |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |       0(+0) |
-| [lib]/stdc++.a         |   4760(+4760) |       8(+8) |     44(+44) |
-| main.cpp.obj           |   1516(+1516) |       0(+0) |   600(+600) |
-| Subtotals              | 67140(+67140) | 2936(+2936) | 8848(+8848) |
-Total Static RAM memory (data + bss): 11784(+11784) bytes
-Total Flash memory (text + data): 70076(+70076) bytes
+| [lib]/stdc++.a         |   4116(+4116) |       8(+8) |     28(+28) |
+| main.cpp.obj           |     982(+982) |       0(+0) |   316(+316) |
+| Subtotals              | 66180(+66180) | 2936(+2936) | 8552(+8552) |
+Total Static RAM memory (data + bss): 11488(+11488) bytes
+Total Flash memory (text + data): 69116(+69116) bytes

Flash used: 73452&nbsp;(3%) / total: 2097152
SRAM used: 11776&nbsp;(2%) / total: 524288

github-actions · 2022-02-07T14:59:00Z

File comparision analysis report

🔖 Info

base: develop / 5b30162 + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/ble/gatt/add-server / b5cde18 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	137588 (52%)	124556 (47%)	29360 (5%)
os	88648 (5%)	1476024 (94%)	18352 (3%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	88648 (4%)	ø	18352 (3%)	ø
bootloader	✔️	✅	✅	137588 (6%)	ø	29360 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	256728 (12%)	ø	35272 (6%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	191600 (9%)	ø	30976 (5%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	165248 (7%)	ø	28680 (5%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	194032 (9%)	ø	30384 (5%)	ø
spike_lk_ble	✔️	❌	❌	178608 (8%) 182584 (8%)	📈 3976 (2%)	29112 (5%) 29288 (5%)	📈 176 (0%)
spike_lk_bluetooth	✔️	✅	✅	91192 (4%)	ø	17472 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	149384 (7%)	ø	30464 (5%)	ø
spike_lk_coreled	✔️	❌	❌	88556 (4%) 88140 (4%)	📉 -416 (0%)	19632 (3%) 19608 (3%)	📉 -24 (0%)
spike_lk_event_queue	✔️	❌	❌	84664 (4%) 83384 (3%)	📉 -1280 (-1%)	18136 (3%) 17728 (3%)	📉 -408 (-2%)
spike_lk_file_reception	✔️	✅	✅	329452 (15%)	ø	33480 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	87352 (4%)	ø	17512 (3%)	ø
spike_lk_lcd	✔️	✅	✅	149792 (7%)	ø	30096 (5%)	ø
spike_lk_led	✔️	✅	✅	88808 (4%)	ø	19400 (3%)	ø
spike_lk_log_kit	✔️	✅	✅	92000 (4%)	ø	18168 (3%)	ø
spike_lk_motors	✔️	✅	✅	86576 (4%)	ø	17552 (3%)	ø
spike_lk_rfid	✔️	✅	✅	91008 (4%)	ø	17472 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	86744 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	84584 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	85336 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90896 (4%)	ø	17496 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	92248 (4%)	ø	17632 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	83224 (3%)	ø	17592 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	143764 (6%)	ø	21352 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100968 (4%)	ø	18472 (3%)	ø
spike_lk_wifi	✔️	✅	✅	131280 (6%)	ø	20832 (3%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84688 (4%)	ø	18448 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	84000 (4%)	ø	17536 (3%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-02-22 20:58:12.741715460 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-02-22 20:58:13.013713446 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       346(+346) |     11(+11) |       74(+74) |
-| [lib]/BLEKit.a          |       798(+798) |       0(+0) |         0(+0) |
-| [lib]/CoreEventQueue.a  |       172(+172) |       0(+0) |         0(+0) |
+| [fill]                  |       380(+380) |     15(+15) |       70(+70) |
+| [lib]/BLEKit.a          |     1082(+1082) |       0(+0) |         0(+0) |
+| [lib]/CoreEventQueue.a  |       326(+326) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   26152(+26152) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 119384(+119384) |   689(+689) | 19120(+19120) |
+| [lib]/mbed-os-static.a  | 122268(+122268) |   689(+689) | 19120(+19120) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |     2504(+2504) |       0(+0) |   6316(+6316) |
-| Subtotals               | 162516(+162516) | 3184(+3184) | 25640(+25640) |
-Total Static RAM memory (data + bss): 28824(+28824) bytes
-Total Flash memory (text + data): 165700(+165700) bytes
+| main.cpp.obj            |     3052(+3052) |       4(+4) |   6488(+6488) |
+| Subtotals               | 166420(+166420) | 3192(+3192) | 25808(+25808) |
+Total Static RAM memory (data + bss): 29000(+29000) bytes
+Total Flash memory (text + data): 169612(+169612) bytes

Flash used: 182584&nbsp;(8%) / total: 2097152
SRAM used: 29288&nbsp;(5%) / total: 524288

spike_lk_coreled (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_coreled-map.txt	2022-02-22 20:58:14.265704176 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_coreled-map.txt	2022-02-22 20:58:14.473702636 +0000
@@ -1,18 +1,18 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     134(+134) |       8(+8) |       30(+30) |
+| [fill]                  |     114(+114) |       8(+8) |       30(+30) |
 | [lib]/CoreSPI.a         |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 26052(+26052) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 33996(+33996) |   444(+444) |   9990(+9990) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5864(+5864) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   4004(+4004) |       0(+0) |   6258(+6258) |
-| Subtotals               | 77908(+77908) | 2936(+2936) | 16408(+16408) |
-Total Static RAM memory (data + bss): 19344(+19344) bytes
-Total Flash memory (text + data): 80844(+80844) bytes
+| main.cpp.obj            |   3640(+3640) |       0(+0) |   6234(+6234) |
+| Subtotals               | 77524(+77524) | 2936(+2936) | 16384(+16384) |
+Total Static RAM memory (data + bss): 19320(+19320) bytes
+Total Flash memory (text + data): 80460(+80460) bytes

Flash used: 88140&nbsp;(4%) / total: 2097152
SRAM used: 19608&nbsp;(3%) / total: 524288

spike_lk_event_queue (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_event_queue-map.txt	2022-02-22 20:58:14.713700859 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_event_queue-map.txt	2022-02-22 20:58:14.901699467 +0000
@@ -1,17 +1,17 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     150(+150) |       8(+8) |       20(+20) |
-| [lib]/CoreEventQueue.a  |       44(+44) |       0(+0) |         0(+0) |
+| [fill]                  |     168(+168) |       8(+8) |       24(+24) |
+| [lib]/CoreEventQueue.a  |     248(+248) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 26052(+26052) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 30906(+30906) |   444(+444) |   8138(+8138) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   4908(+4908) |       0(+0) |   6624(+6624) |
-| Subtotals               | 75220(+75220) | 2936(+2936) | 14912(+14912) |
-Total Static RAM memory (data + bss): 17848(+17848) bytes
-Total Flash memory (text + data): 78156(+78156) bytes
+| main.cpp.obj            |   3662(+3662) |       0(+0) |   6212(+6212) |
+| Subtotals               | 74196(+74196) | 2936(+2936) | 14504(+14504) |
+Total Static RAM memory (data + bss): 17440(+17440) bytes
+Total Flash memory (text + data): 77132(+77132) bytes

Flash used: 83384&nbsp;(3%) / total: 2097152
SRAM used: 17728&nbsp;(3%) / total: 524288

codecov · 2022-02-08T15:23:51Z

Codecov Report

Merging #485 (b5cde18) into develop (c2d810a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #485   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           83        89    +6     
  Lines         1351      1414   +63     
=========================================
+ Hits          1351      1414   +63

Impacted Files	Coverage Δ
libs/BLEKit/include/BLEKit.h	`100.00% <ø> (ø)`
libs/BLEKit/include/CoreGap.h	`100.00% <ø> (ø)`
libs/BLEKit/source/CoreGap.cpp	`100.00% <ø> (ø)`
libs/BLEKit/include/CoreGattServer.h	`100.00% <100.00%> (ø)`
libs/BLEKit/include/CoreGattServerEventHandler.h	`100.00% <100.00%> (ø)`
libs/BLEKit/include/internal/BLEService.h	`100.00% <100.00%> (ø)`
libs/BLEKit/source/BLEKit.cpp	`100.00% <100.00%> (ø)`
libs/BLEKit/source/CoreGattServer.cpp	`100.00% <100.00%> (ø)`
libs/BLEKit/source/CoreGattServerEventHandler.cpp	`100.00% <100.00%> (ø)`
include/interface/drivers/LED.h	`100.00% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d810a...b5cde18. Read the comment docs.

🚧 (ble): Do not use post_init in CoreGap

sonarcloud · 2022-02-22T20:58:25Z

SonarCloud Quality Gate failed.

3 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

89.8% Coverage
0.0% Duplication

YannLocatelli self-assigned this Feb 7, 2022

YannLocatelli changed the title ~~Yann/feature/ble/gatt/add server~~ ✨ (ble): Add CoreGattServer Feb 7, 2022

YannLocatelli force-pushed the yann/feature/ble/gatt/add-server branch 2 times, most recently from a446aad to fec74ad Compare February 8, 2022 14:28

YannLocatelli marked this pull request as ready for review February 8, 2022 14:28

YannLocatelli requested a review from ladislas February 8, 2022 14:28

YannLocatelli force-pushed the yann/feature/ble/gatt/add-server branch from fec74ad to b919c0e Compare February 8, 2022 15:20

YannLocatelli force-pushed the yann/feature/ble/gatt/add-server branch 2 times, most recently from 49bd5db to decca6c Compare February 8, 2022 23:14

YannLocatelli marked this pull request as draft February 9, 2022 11:05

YannLocatelli force-pushed the yann/feature/ble/gatt/add-server branch 3 times, most recently from 933a762 to f4af950 Compare February 9, 2022 15:10

YannLocatelli added 6 commits February 11, 2022 13:27

🏗️ (ble): Add service interface

99b8081

🤡 (ble): Mock BLEService

b8993b9

✨ (ble): Add CoreGattServerEventHandler

e975d48

✨ (ble): Add CoreGattServer

19eebb2

✨ (ble): Add Battery service

2bd6bfd

⚡ (ble): Use CoreGattServer in BLEKit

e0ec59a

🚧 (ble): Do not use post_init in CoreGap

YannLocatelli force-pushed the yann/feature/ble/gatt/add-server branch from f4af950 to e0ec59a Compare February 12, 2022 08:16

YannLocatelli mentioned this pull request Feb 22, 2022

✨ (ble): Add CoreGattServerEventHandler #490

Closed

YannLocatelli added 3 commits February 22, 2022 20:41

🚧 Apply suggestions from oral code review

7aad0e7

🚧 Apply suggestions from oral code review 2

4506e48

🚧 Consequences of previous oral code review

b5cde18

YannLocatelli force-pushed the yann/feature/ble/gatt/add-server branch from 4911be7 to b5cde18 Compare February 22, 2022 20:51

ladislas mentioned this pull request Feb 24, 2022

yann/feature/ble add gatt server #505

Merged

ladislas closed this in 7964c71 Feb 24, 2022

ladislas deleted the yann/feature/ble/gatt/add-server branch February 25, 2022 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ (ble): Add CoreGattServer #485

✨ (ble): Add CoreGattServer #485

YannLocatelli commented Feb 7, 2022 •

edited

Loading

github-actions bot commented Feb 7, 2022 •

edited

Loading

github-actions bot commented Feb 7, 2022 •

edited

Loading

codecov bot commented Feb 8, 2022 •

edited

Loading

sonarcloud bot commented Feb 22, 2022

✨ (ble): Add CoreGattServer #485

✨ (ble): Add CoreGattServer #485

Conversation

YannLocatelli commented Feb 7, 2022 • edited Loading

github-actions bot commented Feb 7, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Feb 7, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

codecov bot commented Feb 8, 2022 • edited Loading

Codecov Report

sonarcloud bot commented Feb 22, 2022

YannLocatelli commented Feb 7, 2022 •

edited

Loading

github-actions bot commented Feb 7, 2022 •

edited

Loading

github-actions bot commented Feb 7, 2022 •

edited

Loading

codecov bot commented Feb 8, 2022 •

edited

Loading