Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yann/feature/ble add gatt server #505

Merged
merged 8 commits into from
Feb 24, 2022
Merged

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Feb 24, 2022

closes #503 #502 #490 #485

@ladislas ladislas force-pushed the yann/feature/ble-add-gatt-server branch from b2b8b4e to 07afb18 Compare February 24, 2022 22:36
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #505 (b2b8b4e) into develop (f0f8cd3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b2b8b4e differs from pull request most recent head 92209c9. Consider uploading reports for the commit 92209c9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #505   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           91        96    +5     
  Lines         1439      1478   +39     
=========================================
+ Hits          1439      1478   +39     
Impacted Files Coverage Δ
libs/BLEKit/include/BLEKit.h 100.00% <ø> (ø)
libs/BLEKit/include/CoreGap.h 100.00% <ø> (ø)
libs/BLEKit/include/CoreGapEventHandler.h 100.00% <ø> (ø)
libs/BLEKit/include/CoreGattServer.h 100.00% <100.00%> (ø)
libs/BLEKit/include/CoreGattServerEventHandler.h 100.00% <100.00%> (ø)
libs/BLEKit/include/internal/BLEService.h 100.00% <100.00%> (ø)
libs/BLEKit/source/BLEKit.cpp 100.00% <100.00%> (ø)
libs/BLEKit/source/CoreGattServer.cpp 100.00% <100.00%> (ø)
libs/BLEKit/source/CoreGattServerEventHandler.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f8cd3...92209c9. Read the comment docs.

@ladislas ladislas force-pushed the yann/feature/ble-add-gatt-server branch from 07afb18 to d34013c Compare February 24, 2022 22:39
@github-actions
Copy link

github-actions bot commented Feb 24, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 137588 (52%) 124556 (47%) 29360 (5%)
os 88648 (5%) 1476024 (94%) 18352 (3%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 88648 (4%) ø 18352 (3%) ø
bootloader ✔️ 137588 (6%) ø 29360 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 256728 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ 178608 (8%)
182392 (8%)
📈
3784 (2%)
29112 (5%)
29304 (5%)
📈
192 (0%)
spike_lk_bluetooth ✔️ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ 149384 (7%) ø 30464 (5%) ø
spike_lk_color_kit ✔️ 88800 (4%) ø 19624 (3%) ø
spike_lk_coreled ✔️ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_reception ✔️ 329452 (15%) ø 33480 (6%) ø
spike_lk_flash_memory ✔️ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ 149792 (7%) ø 30096 (5%) ø
spike_lk_led ✔️ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ 88288 (4%) ø 20216 (3%) ø
spike_lk_log_kit ✔️ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ 86744 (4%) ø 18056 (3%) ø
spike_lk_sensors_light ✔️ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ 92248 (4%) ø 17632 (3%) ø
spike_lk_ticker_timeout ✔️ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ 143764 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_ble (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-02-24 23:03:24.773899672 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-02-24 23:03:25.101899685 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       346(+346) |     11(+11) |       74(+74) |
-| [lib]/BLEKit.a          |       798(+798) |       0(+0) |         0(+0) |
+| [fill]                  |       380(+380) |     15(+15) |       77(+77) |
+| [lib]/BLEKit.a          |     1154(+1154) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   26152(+26152) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 119384(+119384) |   689(+689) | 19120(+19120) |
+| [lib]/mbed-os-static.a  | 122268(+122268) |   689(+689) | 19120(+19120) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |     2504(+2504) |       0(+0) |   6316(+6316) |
-| Subtotals               | 162516(+162516) | 3184(+3184) | 25640(+25640) |
-Total Static RAM memory (data + bss): 28824(+28824) bytes
-Total Flash memory (text + data): 165700(+165700) bytes
+| main.cpp.obj            |     2942(+2942) |       4(+4) |   6497(+6497) |
+| Subtotals               | 166228(+166228) | 3192(+3192) | 25824(+25824) |
+Total Static RAM memory (data + bss): 29016(+29016) bytes
+Total Flash memory (text + data): 169420(+169420) bytes
 
Flash used: 182392&nbsp;(8%) / total: 2097152
SRAM used: 29304&nbsp;(5%) / total: 524288

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 137588 (52%) 124556 (47%) 29360 (5%)
os 74772 (4%) 1489900 (95%) 12328 (2%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 74772 (3%) ø 12328 (2%) ø
bootloader ✔️ 137588 (6%) ø 29360 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 249184 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ 169340 (8%)
173124 (8%)
📈
3784 (2%)
23160 (4%)
23352 (4%)
📈
192 (0%)
spike_lk_bluetooth ✔️ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ 141112 (6%) ø 24464 (4%) ø
spike_lk_color_kit ✔️ 65584 (3%) ø 13624 (2%) ø
spike_lk_coreled ✔️ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ 324516 (15%) ø 27520 (5%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ 136976 (6%) ø 24024 (4%) ø
spike_lk_led ✔️ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ 68680 (3%) ø 14160 (2%) ø
spike_lk_log_kit ✔️ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ 63072 (3%) ø 11984 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ 121348 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_ble (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-02-24 23:03:21.624608081 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-02-24 23:03:21.876611098 +0000
@@ -1,16 +1,16 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       322(+322) |     11(+11) |       70(+70) |
-| [lib]/BLEKit.a         |       798(+798) |       0(+0) |         0(+0) |
+| [fill]                 |       370(+370) |     15(+15) |       73(+73) |
+| [lib]/BLEKit.a         |     1154(+1154) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/c.a              |   26128(+26128) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |     7084(+7084) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a | 115844(+115844) |   689(+689) | 19084(+19084) |
+| [lib]/mbed-os-static.a | 118728(+118728) |   689(+689) | 19084(+19084) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |     4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj           |       360(+360) |       0(+0) |     420(+420) |
-| Subtotals              | 155076(+155076) | 3184(+3184) | 19688(+19688) |
-Total Static RAM memory (data + bss): 22872(+22872) bytes
-Total Flash memory (text + data): 158260(+158260) bytes
+| main.cpp.obj           |       784(+784) |       4(+4) |     601(+601) |
+| Subtotals              | 158788(+158788) | 3192(+3192) | 19872(+19872) |
+Total Static RAM memory (data + bss): 23064(+23064) bytes
+Total Flash memory (text + data): 161980(+161980) bytes
 
Flash used: 173124&nbsp;(8%) / total: 2097152
SRAM used: 23352&nbsp;(4%) / total: 524288

@ladislas ladislas force-pushed the yann/feature/ble-add-gatt-server branch from d34013c to 92209c9 Compare February 24, 2022 22:55
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.0% 92.0% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit 7964c71 into develop Feb 24, 2022
@ladislas ladislas deleted the yann/feature/ble-add-gatt-server branch February 25, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants