REVIEW - ✨ (ble): Add CoreGattServerEventHandler #502

ladislas · 2022-02-23T16:08:02Z

nouvelle implémentation: https://gcc.godbolt.org/z/E8Ghd8bxM

keep specific mbed::Callback overload for mbed::ble compatibility - removes the need of overloads - handles correctly all kind of call situations

codecov · 2022-02-23T16:14:38Z

Codecov Report

Merging #502 (2ede741) into yann/feature/ble/gatt/add-core-gatt-server-event-handler (c2d810a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2ede741 differs from pull request most recent head fba5bab. Consider uploading reports for the commit fba5bab to get more accurate results

@@                                    Coverage Diff                                     @@
##           yann/feature/ble/gatt/add-core-gatt-server-event-handler      #502   +/-   ##
==========================================================================================
  Coverage                                                    100.00%   100.00%           
==========================================================================================
  Files                                                            83        86    +3     
  Lines                                                          1351      1366   +15     
==========================================================================================
+ Hits                                                           1351      1366   +15

Impacted Files	Coverage Δ
libs/BLEKit/include/BLEKit.h	`100.00% <ø> (ø)`
libs/BLEKit/include/CoreGap.h	`100.00% <ø> (ø)`
libs/BLEKit/include/CoreGapEventHandler.h	`100.00% <ø> (ø)`
libs/BLEKit/include/CoreGattServerEventHandler.h	`100.00% <100.00%> (ø)`
libs/BLEKit/include/internal/BLEService.h	`100.00% <100.00%> (ø)`
libs/BLEKit/source/CoreGattServerEventHandler.cpp	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d810a...fba5bab. Read the comment docs.

github-actions · 2022-02-23T16:15:07Z

File comparision analysis report

🔖 Info

base: yann/feature/ble/gatt/add-core-gatt-server-event-handler / 49d79af + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/ble/gatt/add-core-gatt-server-event-handler-LADISLAS_REVIEW / 2ede741 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	137588 (52%)	124556 (47%)	29360 (5%)
os	88648 (5%)	1476024 (94%)	18352 (3%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	88648 (4%)	ø	18352 (3%)	ø
bootloader	✔️	✅	✅	137588 (6%)	ø	29360 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	256728 (12%)	ø	35272 (6%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	191600 (9%)	ø	30976 (5%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	165248 (7%)	ø	28680 (5%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	194032 (9%)	ø	30384 (5%)	ø
spike_lk_ble	✔️	✅	✅	178736 (8%)	ø	29112 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	91192 (4%)	ø	17472 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	149384 (7%)	ø	30464 (5%)	ø
spike_lk_coreled	✔️	✅	✅	88140 (4%)	ø	19608 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	83384 (3%)	ø	17728 (3%)	ø
spike_lk_file_reception	✔️	✅	✅	329452 (15%)	ø	33480 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	87352 (4%)	ø	17512 (3%)	ø
spike_lk_lcd	✔️	✅	✅	149792 (7%)	ø	30096 (5%)	ø
spike_lk_led	✔️	✅	✅	88808 (4%)	ø	19400 (3%)	ø
spike_lk_log_kit	✔️	✅	✅	92000 (4%)	ø	18168 (3%)	ø
spike_lk_motors	✔️	✅	✅	86576 (4%)	ø	17552 (3%)	ø
spike_lk_rfid	✔️	✅	✅	91008 (4%)	ø	17472 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	86744 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	84584 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	85336 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90896 (4%)	ø	17496 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	92248 (4%)	ø	17632 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	83224 (3%)	ø	17592 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	143764 (6%)	ø	21352 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100968 (4%)	ø	18472 (3%)	ø
spike_lk_wifi	✔️	✅	✅	131280 (6%)	ø	20832 (3%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84688 (4%)	ø	18448 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	84000 (4%)	ø	17536 (3%)	ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

github-actions · 2022-02-23T16:15:49Z

File comparision analysis report

🔖 Info

base: yann/feature/ble/gatt/add-core-gatt-server-event-handler / 49d79af + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/ble/gatt/add-core-gatt-server-event-handler-LADISLAS_REVIEW / 2ede741 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	137588 (52%)	124556 (47%)	29360 (5%)
os	74772 (4%)	1489900 (95%)	12328 (2%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	74772 (3%)	ø	12328 (2%)	ø
bootloader	✔️	✅	✅	137588 (6%)	ø	29360 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	249184 (11%)	ø	29240 (5%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	174568 (8%)	ø	24952 (4%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	148840 (7%)	ø	22528 (4%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	177960 (8%)	ø	24360 (4%)	ø
spike_lk_ble	✔️	✅	✅	169532 (8%)	ø	23160 (4%)	ø
spike_lk_bluetooth	✔️	✅	✅	73256 (3%)	ø	11448 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	141112 (6%)	ø	24464 (4%)	ø
spike_lk_coreled	✔️	✅	✅	75764 (3%)	ø	13664 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	73452 (3%)	ø	11776 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	324516 (15%)	ø	27520 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_lcd	✔️	✅	✅	136976 (6%)	ø	24024 (4%)	ø
spike_lk_led	✔️	✅	✅	65744 (3%)	ø	13392 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	68528 (3%)	ø	11912 (2%)	ø
spike_lk_motors	✔️	✅	✅	62528 (2%)	ø	11488 (2%)	ø
spike_lk_rfid	✔️	✅	✅	73072 (3%)	ø	11448 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	63072 (3%)	ø	11984 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	66968 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	121348 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

sonarcloud · 2022-02-23T22:43:17Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

100.0% Coverage
0.0% Duplication

ladislas and others added 16 commits February 14, 2022 15:48

♻️ (eventqueue): Refactor call to use generic variadic function

9a022c9

keep specific mbed::Callback overload for mbed::ble compatibility - removes the need of overloads - handles correctly all kind of call situations

🔀 Merge branch 'ladislas/feature/event-queue-auto-call' into develop

4d7fbfe

✨ (coreled): RGB, add overload opertor +, +=

8412ce6

🔀 Merge branch 'hugo/feature/Add-RGB-struct' into develop

2ae8978

🚚 (CoreLed): Rename show and hide functions

2caf742

🎨 (CoreLed): Add _brightness array

7cd3430

✅ (tests): Add tests for _brightness

68972c9

⚗️ (coreled): Make local lambda variable constexpr

1a5ad22

🔀 Merge branch 'hugo/feature/Add-brightness-array-CoreLED' into develop

5b30162

✨ (libs): Add ColorKit lib

93acb31

🚚 (RGB): Move RGB struct to ColorKit

1b14b35

✨ (libs): Add vivid files to ColorKit

e5dc322

🎨 (libs): Add colorGradient function

c49d6ab

✅ (tests): Add ColorKit tests

c46a91c

✨ (spikes): Add lk_color_kit

e87d706

🔀 Merge branch 'hugo/feature/Add-ColorKit' into develop

36db95f

ladislas force-pushed the yann/feature/ble/gatt/add-core-gatt-server-event-handler-LADISLAS_REVIEW branch from 8737b72 to 2ede741 Compare February 23, 2022 22:37

HPezz and others added 9 commits February 24, 2022 12:31

✨ (libs): Add LedKit lib

a1462f9

🏗️ (interface): Add LEDAnimation interface

d02c740

✨ (spikes): Add lk_led_kit spike

5fee435

✅ (tests): Add LedKit test

3ffca0f

✅ (tests): Add LedAnimation test

5e0a170

🔀 Merge branch 'hugo/feature/Add-Ledkit' into develop

f0f8cd3

🏗️ (ble): Add service interface

ccfbedf

🤡 (ble): Mock BLEService

49b9877

✨ (ble): Add CoreGattServerEventHandler

3d38d42

YannLocatelli and others added 7 commits February 24, 2022 16:22

🚧 Apply suggestions from oral code review

f8120b5

🚧 Apply suggestions from oral code review 2

d2d9adc

🚧 (REVIEW): Fix typo handle --> handler

d0a2cdb

🚧 (REVIEW): Remove method redefinitions shadowing base class GattService

e3f3941

🚧 (REVIEW): Replace header guards with #pragma once

169197e

🚧 (REVIEW): Fix lambda name

4f0b1d9

🚧 (REVIEW): Remove method sendData

fba5bab

ladislas force-pushed the yann/feature/ble/gatt/add-core-gatt-server-event-handler-LADISLAS_REVIEW branch from 2ede741 to fba5bab Compare February 24, 2022 15:22

ladislas mentioned this pull request Feb 24, 2022

yann/feature/ble add gatt server #505

Merged

ladislas closed this in 7964c71 Feb 24, 2022

ladislas deleted the yann/feature/ble/gatt/add-core-gatt-server-event-handler-LADISLAS_REVIEW branch February 25, 2022 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

REVIEW - ✨ (ble): Add CoreGattServerEventHandler #502

REVIEW - ✨ (ble): Add CoreGattServerEventHandler #502

ladislas commented Feb 23, 2022 •

edited

Loading

codecov bot commented Feb 23, 2022 •

edited

Loading

github-actions bot commented Feb 23, 2022 •

edited

Loading

github-actions bot commented Feb 23, 2022 •

edited

Loading

sonarcloud bot commented Feb 23, 2022

REVIEW - ✨ (ble): Add CoreGattServerEventHandler #502

REVIEW - ✨ (ble): Add CoreGattServerEventHandler #502

Conversation

ladislas commented Feb 23, 2022 • edited Loading

codecov bot commented Feb 23, 2022 • edited Loading

Codecov Report

github-actions bot commented Feb 23, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Feb 23, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

sonarcloud bot commented Feb 23, 2022

ladislas commented Feb 23, 2022 •

edited

Loading

codecov bot commented Feb 23, 2022 •

edited

Loading

github-actions bot commented Feb 23, 2022 •

edited

Loading

github-actions bot commented Feb 23, 2022 •

edited

Loading