LADISLAS TESTS yann/feature/ble/gatt/add server #503

ladislas · 2022-02-23T23:05:59Z

🚧 (EXPERIMENT): Use tuple, add onDataReadyToSend + _calback
✨ (ble): Add CoreGattServer
✨ (ble): Add Battery service
⚡ (ble): Use CoreGattServer in BLEKit
🚧 Consequences of previous oral code review
🚧 (EXPERIMENT): Try new gatt server implementation

codecov · 2022-02-23T23:09:23Z

Codecov Report

Merging #503 (da9cc62) into develop (f0f8cd3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #503   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           91        96    +5     
  Lines         1439      1478   +39     
=========================================
+ Hits          1439      1478   +39

Impacted Files	Coverage Δ
libs/BLEKit/include/BLEKit.h	`100.00% <ø> (ø)`
libs/BLEKit/include/CoreGap.h	`100.00% <ø> (ø)`
libs/BLEKit/include/CoreGapEventHandler.h	`100.00% <ø> (ø)`
libs/BLEKit/include/CoreGattServer.h	`100.00% <100.00%> (ø)`
libs/BLEKit/include/CoreGattServerEventHandler.h	`100.00% <100.00%> (ø)`
libs/BLEKit/include/internal/BLEService.h	`100.00% <100.00%> (ø)`
libs/BLEKit/source/BLEKit.cpp	`100.00% <100.00%> (ø)`
libs/BLEKit/source/CoreGattServer.cpp	`100.00% <100.00%> (ø)`
libs/BLEKit/source/CoreGattServerEventHandler.cpp	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f8cd3...da9cc62. Read the comment docs.

github-actions · 2022-02-23T23:11:53Z

File comparision analysis report

🔖 Info

base: develop / f0f8cd3 + mbed-os-6.15.1+fixes + -std=c++20
head: LADISLAS_TESTS-yann/feature/ble/gatt/add-server / da9cc62 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	137588 (52%)	124556 (47%)	29360 (5%)
os	88648 (5%)	1476024 (94%)	18352 (3%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	88648 (4%)	ø	18352 (3%)	ø
bootloader	✔️	✅	✅	137588 (6%)	ø	29360 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	256728 (12%)	ø	35272 (6%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	191600 (9%)	ø	30976 (5%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	165248 (7%)	ø	28680 (5%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	194032 (9%)	ø	30384 (5%)	ø
spike_lk_ble	✔️	❌	❌	178608 (8%) 182392 (8%)	📈 3784 (2%)	29112 (5%) 29304 (5%)	📈 192 (0%)
spike_lk_bluetooth	✔️	✅	✅	91192 (4%)	ø	17472 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	149384 (7%)	ø	30464 (5%)	ø
spike_lk_color_kit	✔️	✅	✅	88800 (4%)	ø	19624 (3%)	ø
spike_lk_coreled	✔️	✅	✅	88556 (4%)	ø	19632 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84664 (4%)	ø	18136 (3%)	ø
spike_lk_file_reception	✔️	✅	✅	329452 (15%)	ø	33480 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	87352 (4%)	ø	17512 (3%)	ø
spike_lk_lcd	✔️	✅	✅	149792 (7%)	ø	30096 (5%)	ø
spike_lk_led	✔️	✅	✅	88808 (4%)	ø	19400 (3%)	ø
spike_lk_led_kit	✔️	✅	✅	88288 (4%)	ø	20216 (3%)	ø
spike_lk_log_kit	✔️	✅	✅	92000 (4%)	ø	18168 (3%)	ø
spike_lk_motors	✔️	✅	✅	86576 (4%)	ø	17552 (3%)	ø
spike_lk_rfid	✔️	✅	✅	91008 (4%)	ø	17472 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	86744 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	84584 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	85336 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90896 (4%)	ø	17496 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	92248 (4%)	ø	17632 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	83224 (3%)	ø	17592 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	143764 (6%)	ø	21352 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100968 (4%)	ø	18472 (3%)	ø
spike_lk_wifi	✔️	✅	✅	131280 (6%)	ø	20832 (3%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84688 (4%)	ø	18448 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	84000 (4%)	ø	17536 (3%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-02-24 16:24:02.147582774 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-02-24 16:24:02.463606393 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       346(+346) |     11(+11) |       74(+74) |
-| [lib]/BLEKit.a          |       798(+798) |       0(+0) |         0(+0) |
+| [fill]                  |       380(+380) |     15(+15) |       77(+77) |
+| [lib]/BLEKit.a          |     1154(+1154) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   26152(+26152) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 119384(+119384) |   689(+689) | 19120(+19120) |
+| [lib]/mbed-os-static.a  | 122268(+122268) |   689(+689) | 19120(+19120) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |     2504(+2504) |       0(+0) |   6316(+6316) |
-| Subtotals               | 162516(+162516) | 3184(+3184) | 25640(+25640) |
-Total Static RAM memory (data + bss): 28824(+28824) bytes
-Total Flash memory (text + data): 165700(+165700) bytes
+| main.cpp.obj            |     2942(+2942) |       4(+4) |   6497(+6497) |
+| Subtotals               | 166228(+166228) | 3192(+3192) | 25824(+25824) |
+Total Static RAM memory (data + bss): 29016(+29016) bytes
+Total Flash memory (text + data): 169420(+169420) bytes

Flash used: 182392&nbsp;(8%) / total: 2097152
SRAM used: 29304&nbsp;(5%) / total: 524288

github-actions · 2022-02-23T23:12:15Z

File comparision analysis report

🔖 Info

base: develop / f0f8cd3 + mbed-os-6.15.1+fixes + -std=c++20
head: LADISLAS_TESTS-yann/feature/ble/gatt/add-server / da9cc62 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	137588 (52%)	124556 (47%)	29360 (5%)
os	74772 (4%)	1489900 (95%)	12328 (2%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	74772 (3%)	ø	12328 (2%)	ø
bootloader	✔️	✅	✅	137588 (6%)	ø	29360 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	249184 (11%)	ø	29240 (5%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	174568 (8%)	ø	24952 (4%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	148840 (7%)	ø	22528 (4%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	177960 (8%)	ø	24360 (4%)	ø
spike_lk_ble	✔️	❌	❌	169340 (8%) 173124 (8%)	📈 3784 (2%)	23160 (4%) 23352 (4%)	📈 192 (0%)
spike_lk_bluetooth	✔️	✅	✅	73256 (3%)	ø	11448 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	141112 (6%)	ø	24464 (4%)	ø
spike_lk_color_kit	✔️	✅	✅	65584 (3%)	ø	13624 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	324516 (15%)	ø	27520 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_lcd	✔️	✅	✅	136976 (6%)	ø	24024 (4%)	ø
spike_lk_led	✔️	✅	✅	65744 (3%)	ø	13392 (2%)	ø
spike_lk_led_kit	✔️	✅	✅	68680 (3%)	ø	14160 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	68528 (3%)	ø	11912 (2%)	ø
spike_lk_motors	✔️	✅	✅	62528 (2%)	ø	11488 (2%)	ø
spike_lk_rfid	✔️	✅	✅	73072 (3%)	ø	11448 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	63072 (3%)	ø	11984 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	66968 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	121348 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-02-24 16:24:56.854417170 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-02-24 16:24:57.098420597 +0000
@@ -1,16 +1,16 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       322(+322) |     11(+11) |       70(+70) |
-| [lib]/BLEKit.a         |       798(+798) |       0(+0) |         0(+0) |
+| [fill]                 |       370(+370) |     15(+15) |       73(+73) |
+| [lib]/BLEKit.a         |     1154(+1154) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/c.a              |   26128(+26128) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |     7084(+7084) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a | 115844(+115844) |   689(+689) | 19084(+19084) |
+| [lib]/mbed-os-static.a | 118728(+118728) |   689(+689) | 19084(+19084) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |     4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj           |       360(+360) |       0(+0) |     420(+420) |
-| Subtotals              | 155076(+155076) | 3184(+3184) | 19688(+19688) |
-Total Static RAM memory (data + bss): 22872(+22872) bytes
-Total Flash memory (text + data): 158260(+158260) bytes
+| main.cpp.obj           |       784(+784) |       4(+4) |     601(+601) |
+| Subtotals              | 158788(+158788) | 3192(+3192) | 19872(+19872) |
+Total Static RAM memory (data + bss): 23064(+23064) bytes
+Total Flash memory (text + data): 161980(+161980) bytes

Flash used: 173124&nbsp;(8%) / total: 2097152
SRAM used: 23352&nbsp;(4%) / total: 524288

…ndData(..) method

sonarcloud · 2022-02-24T16:24:28Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

92.0% Coverage
0.0% Duplication

ladislas force-pushed the LADISLAS_TESTS-yann/feature/ble/gatt/add-server branch from 5613c8c to 020c7dd Compare February 24, 2022 11:52

YannLocatelli changed the base branch from develop to yann/feature/ble/gatt/add-core-gatt-server-event-handler-LADISLAS_REVIEW February 24, 2022 15:21

ladislas force-pushed the yann/feature/ble/gatt/add-core-gatt-server-event-handler-LADISLAS_REVIEW branch from 2ede741 to fba5bab Compare February 24, 2022 15:22

ladislas force-pushed the LADISLAS_TESTS-yann/feature/ble/gatt/add-server branch from 020c7dd to d51213d Compare February 24, 2022 15:23

YannLocatelli changed the base branch from yann/feature/ble/gatt/add-core-gatt-server-event-handler-LADISLAS_REVIEW to develop February 24, 2022 15:27

YannLocatelli and others added 20 commits February 24, 2022 17:13

✨ (ble): Add BLEService

d111a7a

🤡 (ble): Mock BLEService

2f5446f

✨ (ble): Add CoreGattServerEventHandler

e305a73

🚧 (REVIEW): Fix typo handle --> handler

464e433

🚧 (REVIEW): Remove method redefinitions shadowing base class GattService

5ee4d0f

🚧 (REVIEW): Replace header guards with #pragma once

b6d4c55

🚧 (REVIEW): Fix lambda name

c8dd223

🚧 (REVIEW): Remove method sendData

dff4c5d

🚧 (EXPERIMENT): Use tuple, add onDataReadyToSend + _calback

f460ea1

✨ (ble): Add CoreGattServer

be2ca12

✨ (ble): Add Battery service

f3447f7

⚡ (ble): Use CoreGattServer in BLEKit

9afd85a

🚧 (EXPERIMENT): Try new gatt server implementation

8195334

🚧 (EXPERIMENT): Avoid copying, use reference to const

45730c0

🚧 (EXPERIMENT): Make _callback_on_data_ready_to_send private + add se…

6d069c4

…ndData(..) method

🚧 (EXPERIMENT): Pass callback directly

8ee3a75

🚧 (EXPERIMENT): Use std::span for CoreGattServer::write

655870c

🚧 (REVIEW): Replace header guards with #pragma once

a28859b

🚧 (REVIEW): Clean up tests

cd422e9

🚧 (EXPERIMENT): Fix sonarcloud issues

da9cc62

YannLocatelli force-pushed the LADISLAS_TESTS-yann/feature/ble/gatt/add-server branch from d51213d to da9cc62 Compare February 24, 2022 16:17

ladislas mentioned this pull request Feb 24, 2022

yann/feature/ble add gatt server #505

Merged

ladislas closed this in #505 Feb 24, 2022

ladislas closed this in 7964c71 Feb 24, 2022

ladislas deleted the LADISLAS_TESTS-yann/feature/ble/gatt/add-server branch February 25, 2022 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LADISLAS TESTS yann/feature/ble/gatt/add server #503

LADISLAS TESTS yann/feature/ble/gatt/add server #503

ladislas commented Feb 23, 2022 •

edited by YannLocatelli

Loading

codecov bot commented Feb 23, 2022 •

edited

Loading

github-actions bot commented Feb 23, 2022 •

edited

Loading

github-actions bot commented Feb 23, 2022 •

edited

Loading

sonarcloud bot commented Feb 24, 2022

LADISLAS TESTS yann/feature/ble/gatt/add server #503

LADISLAS TESTS yann/feature/ble/gatt/add server #503

Conversation

ladislas commented Feb 23, 2022 • edited by YannLocatelli Loading

codecov bot commented Feb 23, 2022 • edited Loading

Codecov Report

github-actions bot commented Feb 23, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Feb 23, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

sonarcloud bot commented Feb 24, 2022

ladislas commented Feb 23, 2022 •

edited by YannLocatelli

Loading

codecov bot commented Feb 23, 2022 •

edited

Loading

github-actions bot commented Feb 23, 2022 •

edited

Loading

github-actions bot commented Feb 23, 2022 •

edited

Loading