hugo/feature/Add Sleeping animation #504

HPezz · 2022-02-24T10:46:22Z

✨ (animation): Add Sleeping animation
🎨 (spikes): Update lk_led_kit

codecov · 2022-02-24T10:48:29Z

Codecov Report

Merging #504 (f7a7850) into develop (633575a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #504   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           96        96           
  Lines         1471      1471           
=========================================
  Hits          1471      1471

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633575a...f7a7850. Read the comment docs.

github-actions · 2022-02-24T10:52:20Z

File comparision analysis report

🔖 Info

base: develop / 9d8b7b9 + mbed-os-6.15.1+fixes + -std=c++20
head: hugo/feature/Add-Sleeping-animation / 9d8b7b9 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	137588 (52%)	124556 (47%)	29360 (5%)
os	88648 (5%)	1476024 (94%)	18352 (3%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	88648 (4%)	ø	18352 (3%)	ø
bootloader	✔️	✅	✅	137588 (6%)	ø	29360 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	256728 (12%)	ø	35272 (6%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	191600 (9%)	ø	30976 (5%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	165248 (7%)	ø	28680 (5%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	194032 (9%)	ø	30384 (5%)	ø
spike_lk_ble	✔️	✅	✅	182392 (8%)	ø	29304 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	91192 (4%)	ø	17472 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	149384 (7%)	ø	30464 (5%)	ø
spike_lk_color_kit	✔️	✅	✅	88800 (4%)	ø	19624 (3%)	ø
spike_lk_coreled	✔️	✅	✅	88556 (4%)	ø	19632 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84664 (4%)	ø	18136 (3%)	ø
spike_lk_file_reception	✔️	✅	✅	329452 (15%)	ø	33480 (6%)	ø
spike_lk_filesystem_kit	✔️	✅	✅	125948 (6%)	ø	20280 (3%)	ø
spike_lk_flash_memory	✔️	✅	✅	87352 (4%)	ø	17512 (3%)	ø
spike_lk_lcd	✔️	✅	✅	149792 (7%)	ø	30096 (5%)	ø
spike_lk_led	✔️	✅	✅	88808 (4%)	ø	19400 (3%)	ø
spike_lk_led_kit	✔️	❌	❌	93900 (4%) 94636 (4%)	📈 736 (0%)	20232 (3%) 20248 (3%)	📈 16 (0%)
spike_lk_log_kit	✔️	✅	✅	92000 (4%)	ø	18168 (3%)	ø
spike_lk_motors	✔️	✅	✅	86576 (4%)	ø	17552 (3%)	ø
spike_lk_rfid	✔️	✅	✅	91008 (4%)	ø	17472 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	86744 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	84584 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	85336 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90896 (4%)	ø	17496 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	92248 (4%)	ø	17632 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	83224 (3%)	ø	17592 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	143764 (6%)	ø	21352 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100968 (4%)	ø	18472 (3%)	ø
spike_lk_wifi	✔️	✅	✅	131280 (6%)	ø	20832 (3%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84688 (4%)	ø	18448 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	84000 (4%)	ø	17536 (3%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_led_kit (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_led_kit-map.txt	2022-03-09 14:42:44.470467419 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_led_kit-map.txt	2022-03-09 14:42:44.638474703 +0000
@@ -1,20 +1,20 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     158(+158) |       8(+8) |       32(+32) |
+| [fill]                  |     154(+154) |       8(+8) |       32(+32) |
 | [lib]/ColorKit.a        |     864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/LedKit.a          |   3382(+3382) |       0(+0) |         0(+0) |
+| [lib]/LedKit.a          |   4022(+4022) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 26052(+26052) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 34292(+34292) |   444(+444) |   9990(+9990) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5864(+5864) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   4418(+4418) |       0(+0) |   6856(+6856) |
-| Subtotals               | 83092(+83092) | 2936(+2936) | 17008(+17008) |
-Total Static RAM memory (data + bss): 19944(+19944) bytes
-Total Flash memory (text + data): 86028(+86028) bytes
+| main.cpp.obj            |   4486(+4486) |       0(+0) |   6872(+6872) |
+| Subtotals               | 83796(+83796) | 2936(+2936) | 17024(+17024) |
+Total Static RAM memory (data + bss): 19960(+19960) bytes
+Total Flash memory (text + data): 86732(+86732) bytes

Flash used: 94636&nbsp;(4%) / total: 2097152
SRAM used: 20248&nbsp;(3%) / total: 524288

github-actions · 2022-02-24T10:53:23Z

File comparision analysis report

🔖 Info

base: develop / 9d8b7b9 + mbed-os-6.15.1+fixes + -std=c++20
head: hugo/feature/Add-Sleeping-animation / 9d8b7b9 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	137588 (52%)	124556 (47%)	29360 (5%)
os	74772 (4%)	1489900 (95%)	12328 (2%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	74772 (3%)	ø	12328 (2%)	ø
bootloader	✔️	✅	✅	137588 (6%)	ø	29360 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	249184 (11%)	ø	29240 (5%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	174568 (8%)	ø	24952 (4%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	148840 (7%)	ø	22528 (4%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	177960 (8%)	ø	24360 (4%)	ø
spike_lk_ble	✔️	✅	✅	173124 (8%)	ø	23352 (4%)	ø
spike_lk_bluetooth	✔️	✅	✅	73256 (3%)	ø	11448 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	141112 (6%)	ø	24464 (4%)	ø
spike_lk_color_kit	✔️	✅	✅	65584 (3%)	ø	13624 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	324516 (15%)	ø	27520 (5%)	ø
spike_lk_filesystem_kit	✔️	✅	✅	102036 (4%)	ø	14048 (2%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_lcd	✔️	✅	✅	136976 (6%)	ø	24024 (4%)	ø
spike_lk_led	✔️	✅	✅	65744 (3%)	ø	13392 (2%)	ø
spike_lk_led_kit	✔️	❌	❌	85884 (4%) 86620 (4%)	📈 736 (0%)	14296 (2%) 14312 (2%)	📈 16 (0%)
spike_lk_log_kit	✔️	✅	✅	68528 (3%)	ø	11912 (2%)	ø
spike_lk_motors	✔️	✅	✅	62528 (2%)	ø	11488 (2%)	ø
spike_lk_rfid	✔️	✅	✅	73072 (3%)	ø	11448 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	63072 (3%)	ø	11984 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	66968 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	121348 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_led_kit (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_led_kit-map.txt	2022-03-09 14:42:13.322284742 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_led_kit-map.txt	2022-03-09 14:42:13.506281936 +0000
@@ -1,19 +1,19 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     148(+148) |       8(+8) |       28(+28) |
+| [fill]                 |     144(+144) |       8(+8) |       28(+28) |
 | [lib]/ColorKit.a       |     864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a        |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a     |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/LedKit.a         |   3382(+3382) |       0(+0) |         0(+0) |
+| [lib]/LedKit.a         |   4022(+4022) |       0(+0) |         0(+0) |
 | [lib]/c.a              | 26028(+26028) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/m.a              |     204(+204) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a | 30752(+30752) |   444(+444) |   9954(+9954) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |   5356(+5356) |       8(+8) |       44(+44) |
-| main.cpp.obj           |   2452(+2452) |       0(+0) |     960(+960) |
-| Subtotals              | 76612(+76612) | 2936(+2936) | 11072(+11072) |
-Total Static RAM memory (data + bss): 14008(+14008) bytes
-Total Flash memory (text + data): 79548(+79548) bytes
+| main.cpp.obj           |   2520(+2520) |       0(+0) |     976(+976) |
+| Subtotals              | 77316(+77316) | 2936(+2936) | 11088(+11088) |
+Total Static RAM memory (data + bss): 14024(+14024) bytes
+Total Flash memory (text + data): 80252(+80252) bytes

Flash used: 86620&nbsp;(4%) / total: 2097152
SRAM used: 14312&nbsp;(2%) / total: 524288

ladislas

Première review, c'est cool 👍

libs/LedKit/include/internal/Sleeping.h

libs/LedKit/source/Sleeping.cpp

libs/LedKit/include/internal/Sleeping.h

sonarcloud · 2022-03-09T14:37:11Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

HPezz force-pushed the hugo/feature/Add-Sleeping-animation branch 5 times, most recently from 186c908 to 3e9608d Compare February 24, 2022 15:13

ladislas requested changes Mar 2, 2022

View reviewed changes

HPezz force-pushed the hugo/feature/Add-Sleeping-animation branch 2 times, most recently from 50236d3 to 0f25498 Compare March 3, 2022 19:40

HPezz marked this pull request as draft March 4, 2022 08:53

HPezz force-pushed the hugo/feature/Add-Sleeping-animation branch 2 times, most recently from 9f0df1f to ed18b13 Compare March 4, 2022 13:35

HPezz marked this pull request as ready for review March 4, 2022 13:55

HPezz force-pushed the hugo/feature/Add-Sleeping-animation branch 4 times, most recently from 14bd0fe to f7a7850 Compare March 8, 2022 16:31

HPezz added 2 commits March 9, 2022 15:28

✨ (animation): Add Sleeping animation

832f625

🎨 (spikes): Update lk_led_kit

fe97836

ladislas force-pushed the hugo/feature/Add-Sleeping-animation branch from f7a7850 to fe97836 Compare March 9, 2022 14:30

ladislas merged commit 9d8b7b9 into develop Mar 9, 2022

ladislas deleted the hugo/feature/Add-Sleeping-animation branch March 9, 2022 14:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hugo/feature/Add Sleeping animation #504

hugo/feature/Add Sleeping animation #504

HPezz commented Feb 24, 2022 •

edited

Loading

codecov bot commented Feb 24, 2022 •

edited

Loading

github-actions bot commented Feb 24, 2022 •

edited

Loading

github-actions bot commented Feb 24, 2022 •

edited

Loading

ladislas left a comment

sonarcloud bot commented Mar 9, 2022

hugo/feature/Add Sleeping animation #504

hugo/feature/Add Sleeping animation #504

Conversation

HPezz commented Feb 24, 2022 • edited Loading

codecov bot commented Feb 24, 2022 • edited Loading

Codecov Report

github-actions bot commented Feb 24, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Feb 24, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

ladislas left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Mar 9, 2022

HPezz commented Feb 24, 2022 •

edited

Loading

codecov bot commented Feb 24, 2022 •

edited

Loading

github-actions bot commented Feb 24, 2022 •

edited

Loading

github-actions bot commented Feb 24, 2022 •

edited

Loading