Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo/feature/Add Reinforcers animations #560

Merged
merged 5 commits into from
Mar 15, 2022
Merged

hugo/feature/Add Reinforcers animations #560

merged 5 commits into from
Mar 15, 2022

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Mar 11, 2022 •
edited
Loading

  • ✨ (reinforcer): Add Yellow reinforcer and create lk_reinforcer
  • ✨ (reinforcer): Add SpinBlink reinforcer
  • ✨ (reinforcer): Add Fire reinforcer
  • ✨ (reinforcer): Add Birds reinforcer
  • ✨ (reinforcer): Add Rainbow reinforcer

@codecov
Copy link

codecov bot commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #560 (3b134fa) into develop (d12a9da) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #560   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         1685      1685           
=========================================
  Hits          1685      1685

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 140204 (53%) 121940 (46%) 29512 (5%)
os 213016 (13%) 1351656 (86%) 25136 (4%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 213016 (10%) ø 25136 (4%) ø
bootloader ✔️ ✅ ✅ 140204 (6%) ø 29512 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 250624 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ ✅ ✅ 174508 (8%) ø 24360 (4%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 141176 (6%) ø 24464 (4%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65584 (3%) ø 13624 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326904 (15%) ø 27576 (5%) ø
spike_lk_filesystem_kit ✔️ ✅ ✅ 103476 (4%) ø 14048 (2%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 137552 (6%) ø 24016 (4%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ ✅ ✅ 100428 (4%) ø 14640 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✨ - - 73032 (3%) - 14240 (2%) -
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 58560 (2%) ø 11424 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 122724 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_reinforcer (click to expand) 


Flash used: 73032 (3%) / total: 2097152
SRAM used: 14240 (2%) / total: 524288

@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 140204 (53%) 121940 (46%) 29512 (5%)
os 222508 (14%) 1342164 (85%) 31144 (5%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 222508 (10%) ø 31144 (5%) ø
bootloader ✔️ ✅ ✅ 140204 (6%) ø 29512 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 258168 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ ✅ ✅ 183968 (8%) ø 30376 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 149448 (7%) ø 30464 (5%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88800 (4%) ø 19624 (3%) ø
spike_lk_coreled ✔️ ✅ ✅ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331612 (15%) ø 33536 (6%) ø
spike_lk_filesystem_kit ✔️ ✅ ✅ 127580 (6%) ø 20216 (3%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 150432 (7%) ø 30088 (5%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ ✅ ✅ 109636 (5%) ø 20648 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86576 (4%) ø 17552 (3%) ø
spike_lk_reinforcer ✨ - - 91872 (4%) - 20232 (3%) -
spike_lk_rfid ✔️ ✅ ✅ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87600 (4%) ø 18584 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 82400 (3%) ø 17544 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 145204 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_reinforcer (click to expand) 


Flash used: 91872 (4%) / total: 2097152
SRAM used: 20232 (3%) / total: 524288

@HPezz HPezz force-pushed the hugo/feature/Add-Reinforcers-animations branch 3 times, most recently from b9fe929 to b7a597a Compare March 14, 2022 15:20
ladislas
ladislas approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

j'avoue que j'ai pas lue tout en détail, le principal c'est que ça marche avec la vidéo de Leka heureux :)

pour Yellow tu me remontreras lequel c'est, je pense qu'on changera le nom.

@HPezz HPezz force-pushed the hugo/feature/Add-Reinforcers-animations branch 3 times, most recently from 4bb3e59 to 4abfdcc Compare March 15, 2022 11:51
@HPezz HPezz force-pushed the hugo/feature/Add-Reinforcers-animations branch from 4abfdcc to 6bfaf57 Compare March 15, 2022 16:02
@HPezz HPezz force-pushed the hugo/feature/Add-Reinforcers-animations branch from 6bfaf57 to 3b134fa Compare March 15, 2022 16:18
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ladislas ladislas merged commit d977989 into develop Mar 15, 2022
@ladislas ladislas deleted the hugo/feature/Add-Reinforcers-animations branch March 15, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HPezz @ladislas