✨ (drivers): Add CoreDACExpander #828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #828 +/- ##
===========================================
+ Coverage 95.50% 95.59% +0.08%
===========================================
Files 116 118 +2
Lines 2649 2703 +54
===========================================
+ Hits 2530 2584 +54
Misses 119 119
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
MMyster
force-pushed
the
mmyster/feature/add-core-dac-expander
branch
from
d68ff5f
to
ad635a2
Compare
MMyster
force-pushed
the
mmyster/feature/add-core-dac-expander
branch
from
ad635a2
to
7fa9668
Compare
|
|
||
| namespace leka::interface { | ||
|
|
||
| class DACTouch |
There was a problem hiding this comment.
Il y a 2 choses qui se mélange ici et je pense qu'il serait important de les séparer:
- La partie DAC ou nommé AnalogOut sous mbed
- La calibration du capteur de toucher, ici grâce à une entrée analogique
A cela, tu as ajouté le fonctionnement du driver utilisé aujourd'hui:
- voltage reference
- powermode
- gain
- ...
Or un driver, que ce soit le DAC ou la calibration du capteur de toucher, ne devrait pas présenter des fonctions spécifique à un matériel mais se doivent être générique et c'est l'implémentation qui va adapter le matériel pour qu'il soit conforme au driver, et ici à l'interface.
There was a problem hiding this comment.
je rejoins @YannLocatelli !
il faut bien séparer les concepts:
- le
io_expander::AnalogOut - le calibrateur qui utilise le AnalogOut
5 tasks
ladislas
requested changes
Jun 23, 2022
|
|
||
| namespace command { | ||
|
|
||
| inline constexpr uint8_t writeAllInputRegister = 0x00; |
There was a problem hiding this comment.
même chose que dans #792 pour ici et pour tous les autres:
Suggested change
| inline constexpr uint8_t writeAllInputRegister = 0x00; | |
| inline constexpr auto writeAllInputRegister = uint8_t {0x00}; |
| void CoreDACTouchMCP4728::writeToAllInputRegister(std::array<uint8_t, 2> value) | ||
| { | ||
| auto command = std::array<uint8_t, 2> {}; | ||
| command.at(0) = static_cast<uint8_t>((0xC0 & mcp4728::command::writeAllInputRegister) | (0x3F & value.at(0))); |
There was a problem hiding this comment.
les & et | je comprends pas ce que ça fait.
est-ce que tu peux avoir une petite fonction privée avec un nom explicite de l'opération.
| { | ||
| auto command = std::array<uint8_t, 3> {}; | ||
| command.at(0) = | ||
| static_cast<uint8_t>((0xF8 & mcp4728::command::writeSpecificInputRegister) | (0x07 & ((0x03 & channel) << 1))); |
There was a problem hiding this comment.
pareil ici, pourquoi 0xF8 & et pas autre chose?
pourquoi (0x07 & ((0x03 & channel) << 1))) et pas autre chose.
faut que le nom de l'opération soit explicite
There was a problem hiding this comment.
et pareil pour les autres en dessous qui sont parfois les mêmes.
|
|
||
| namespace leka::interface { | ||
|
|
||
| class DACTouch |
There was a problem hiding this comment.
je rejoins @YannLocatelli !
il faut bien séparer les concepts:
- le
io_expander::AnalogOut - le calibrateur qui utilise le AnalogOut
5 tasks
MMyster
force-pushed
the
mmyster/feature/add-core-dac-expander
branch
2 times, most recently
from
00778d5
to
ccf94ac
Compare
MMyster
force-pushed
the
mmyster/feature/add-core-dac-expander
branch
from
ccf94ac
to
05b6441
Compare
|
Kudos, SonarCloud Quality Gate passed! |
5 tasks
|
A supprimer/fermer : se référer à |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.