-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hugo/feature/Update RC SM and OS to Gamekit #986
Conversation
HPezz
commented
Aug 30, 2022
•
edited
Loading
edited
- Sortir MagicCardAvailable et RFIDKit de l'OS
- Testé sur le robot (fonctionnel sur Hugo's robot 06/09 à 18h avec la nouvelle implémentation de l'update de la callback RFID)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
premier passage, ça me semble bien mais je revois demain de nouveau :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
petits changements de naming
6c5d334
to
4d4b80b
Compare
80b9856
to
48caf5d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #986 +/- ##
===========================================
+ Coverage 95.97% 95.98% +0.01%
===========================================
Files 131 131
Lines 3028 3062 +34
===========================================
+ Hits 2906 2939 +33
- Misses 122 123 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
ff230cc
to
86c5a04
Compare
a5c4571
to
2138705
Compare
86c5a04
to
aa1d602
Compare
2138705
to
8fe7ba0
Compare
aa1d602
to
354a388
Compare
La PR de la branche de base a été closed, est-ce que tu peux repointer sur une branche en cours pour que les commits soient à jour? Merci~ |
354a388
to
4cb5bf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci pour tout le travail réalisé
libs/RobotKit/tests/RobotController_test_stateAutonomousGames.cpp
Outdated
Show resolved
Hide resolved
libs/RobotKit/tests/RobotController_test_stateAutonomousGames.cpp
Outdated
Show resolved
Hide resolved
libs/RobotKit/tests/RobotController_test_stateAutonomousGames.cpp
Outdated
Show resolved
Hide resolved
7a5518a
to
98b2a58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1er passage avant d'en causer demain :)
bon boulot! c'est très cool 👍
sm.process_event(lksm::event::autonomous_activity_requested {}); | ||
|
||
EXPECT_TRUE(sm.is(lksm::state::autonomous_activity)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
il commence à y avoir trop de tests dans le même fichier, il faudrait séparer
44866ac
to
3e1751a
Compare
3e1751a
to
d91bbbf
Compare
d91bbbf
to
dc9466c
Compare
Kudos, SonarCloud Quality Gate passed! |