Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo/feature/Update RC SM and OS to Gamekit #986

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Aug 30, 2022

  • Sortir MagicCardAvailable et RFIDKit de l'OS
  • Testé sur le robot (fonctionnel sur Hugo's robot 06/09 à 18h avec la nouvelle implémentation de l'update de la callback RFID)

@HPezz HPezz changed the base branch from develop to hugo/feature/Update-GameKit-and-add-first-Game August 30, 2022 14:54
@HPezz HPezz self-assigned this Aug 30, 2022
@HPezz HPezz added the 01 - type: task Something to do label Aug 30, 2022
@HPezz HPezz added this to the Next Release milestone Aug 30, 2022
@HPezz HPezz linked an issue Aug 30, 2022 that may be closed by this pull request
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

premier passage, ça me semble bien mais je revois demain de nouveau :)

app/os/main.cpp Outdated Show resolved Hide resolved
libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved
libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petits changements de naming

libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved
libs/RobotKit/include/StateMachine.h Outdated Show resolved Hide resolved
@HPezz HPezz force-pushed the hugo/feature/Update-GameKit-and-add-first-Game branch 2 times, most recently from 6c5d334 to 4d4b80b Compare September 1, 2022 13:11
@HPezz HPezz force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch from 80b9856 to 48caf5d Compare September 1, 2022 14:03
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #986 (dc9466c) into develop (03f84f0) will increase coverage by 0.01%.
The diff coverage is 98.07%.

@@             Coverage Diff             @@
##           develop     #986      +/-   ##
===========================================
+ Coverage    95.97%   95.98%   +0.01%     
===========================================
  Files          131      131              
  Lines         3028     3062      +34     
===========================================
+ Hits          2906     2939      +33     
- Misses         122      123       +1     
Impacted Files Coverage Δ
libs/BehaviorKit/include/BehaviorKit.h 100.00% <ø> (ø)
libs/RobotKit/include/RobotController.h 94.50% <95.45%> (+0.05%) ⬆️
libs/BehaviorKit/source/BehaviorKit.cpp 100.00% <100.00%> (ø)
libs/RobotKit/include/StateMachine.h 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 168820 (64%) 93324 (35%) 30920 (5%)
os 373616 (23%) 1191056 (76%) 74448 (14%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 364520 (17%)
373616 (17%)
📈
9096 (2%)
73736 (14%)
74448 (14%)
📈
712 (0%)
bootloader ✔️ 168820 (8%) ø 30920 (5%) ø
spike_lk_audio ✔️ 122324 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ 186848 (8%) ø 48112 (9%) ø
spike_lk_ble ✔️ 225792 (10%) ø 28056 (5%) ø
spike_lk_bluetooth ✔️ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ 144632 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ 189632 (9%) ø 50936 (9%) ø
spike_lk_config_kit ✔️ 124188 (5%) ø 14312 (2%) ø
spike_lk_coreled ✔️ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ 128680 (6%) ø 14384 (2%) ø
spike_lk_file_reception ✔️ 326968 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ 171728 (8%) ø 47880 (9%) ø
spike_lk_lcd ✔️ 167468 (7%) ø 47320 (9%) ø
spike_lk_led_kit ✔️ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ 62600 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ 78564 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ 80920 (3%) ø 11520 (2%) ø
spike_lk_sensors_battery ✔️ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ 58904 (2%) ø 11480 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ 122804 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ 82032 (3%) ø 13288 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-09-06 22:10:50.302882104 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-09-06 22:10:50.770885515 +0000
@@ -1,47 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       544(+544) |     22(+22) |     196(+196) |
+| [fill]                     |       574(+574) |     22(+22) |     207(+207) |
+| [lib]/ActivityKit.a        |       782(+782) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
-| [lib]/BehaviorKit.a        |     1814(+1814) |       0(+0) |         0(+0) |
+| [lib]/BehaviorKit.a        |     1854(+1854) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7920(+7920) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
-| [lib]/RFIDKit.a            |     1058(+1058) |       0(+0) |         8(+8) |
+| [lib]/RFIDKit.a            |     1062(+1062) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1470(+1470) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       638(+638) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
-| [lib]/c.a                  |   43396(+43396) | 2572(+2572) |       97(+97) |
+| [lib]/c.a                  |   43284(+43284) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
-| [lib]/m.a                  |       204(+204) |       0(+0) |         0(+0) |
+| [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 170856(+170856) |   769(+769) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a             |   10312(+10312) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   50318(+50318) |   548(+548) | 18306(+18306) |
-| Subtotals                  | 325832(+325832) | 3944(+3944) | 69464(+69464) |
-Total Static RAM memory (data + bss): 73408(+73408) bytes
-Total Flash memory (text + data): 329776(+329776) bytes
+| [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
+| main.cpp.obj               |   56410(+56410) |   548(+548) | 19007(+19007) |
+| Subtotals                  | 333400(+333400) | 3944(+3944) | 70176(+70176) |
+Total Static RAM memory (data + bss): 74120(+74120) bytes
+Total Flash memory (text + data): 337344(+337344) bytes
 
Flash used: 373616&nbsp;(17%) / total: 2097152
SRAM used: 74448&nbsp;(14%) / total: 524288

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 181260 (69%) 80884 (30%) 37456 (7%)
os 411708 (26%) 1152964 (73%) 81376 (15%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 397916 (18%)
411708 (19%)
📈
13792 (3%)
80664 (15%)
81376 (15%)
📈
712 (0%)
bootloader ✔️ 181260 (8%) ø 37456 (7%) ø
spike_lk_audio ✔️ 132380 (6%) ø 20984 (4%) ø
spike_lk_behavior_kit ✔️ 195348 (9%) ø 54528 (10%) ø
spike_lk_ble ✔️ 233676 (11%) ø 34712 (6%) ø
spike_lk_bluetooth ✔️ 92236 (4%) ø 18064 (3%) ø
spike_lk_cg_animations ✔️ 152200 (7%) ø 53064 (10%) ø
spike_lk_color_kit ✔️ 88352 (4%) ø 20216 (3%) ø
spike_lk_command_kit ✔️ 199828 (9%) ø 57864 (11%) ø
spike_lk_config_kit ✔️ 136100 (6%) ø 20976 (4%) ø
spike_lk_coreled ✔️ 87916 (4%) ø 20104 (3%) ø
spike_lk_event_queue ✔️ 84088 (4%) ø 18744 (3%) ø
spike_lk_file_manager_kit ✔️ 143648 (6%) ø 21304 (4%) ø
spike_lk_file_reception ✔️ 331036 (15%) ø 34072 (6%) ø
spike_lk_flash_memory ✔️ 86712 (4%) ø 18056 (3%) ø
spike_lk_fs ✔️ 171024 (8%) ø 47968 (9%) ø
spike_lk_lcd ✔️ 177100 (8%) ø 53992 (10%) ø
spike_lk_led_kit ✔️ 115708 (5%) ø 21024 (4%) ø
spike_lk_log_kit ✔️ 84440 (4%) ø 19248 (3%) ø
spike_lk_motors ✔️ 86008 (4%) ø 18088 (3%) ø
spike_lk_qdac ✔️ 91508 (4%) ø 18616 (3%) ø
spike_lk_reinforcer ✔️ 112188 (5%) ø 21024 (4%) ø
spike_lk_rfid ✔️ 84636 (4%) ø 18024 (3%) ø
spike_lk_sensors_battery ✔️ 87056 (4%) ø 19120 (3%) ø
spike_lk_sensors_light ✔️ 83944 (4%) ø 18056 (3%) ø
spike_lk_sensors_microphone ✔️ 84696 (4%) ø 18056 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90336 (4%) ø 18032 (3%) ø
spike_lk_sensors_touch ✔️ 91608 (4%) ø 18296 (3%) ø
spike_lk_serial_number ✔️ 82176 (3%) ø 18336 (3%) ø
spike_lk_ticker_timeout ✔️ 82584 (3%) ø 18072 (3%) ø
spike_lk_update_process_app_base ✔️ 144644 (6%) ø 21896 (4%) ø
spike_lk_update_process_app_update ✔️ 100328 (4%) ø 19080 (3%) ø
spike_lk_watchdog_isr ✔️ 87940 (4%) ø 19960 (3%) ø
spike_lk_wifi ✔️ 130640 (6%) ø 21368 (4%) ø
spike_mbed_blinky ✔️ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84112 (4%) ø 18920 (3%) ø
spike_stl_cxxsupport ✔️ 83424 (3%) ø 18144 (3%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-09-06 22:09:04.691563966 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-09-06 22:09:05.087559535 +0000
@@ -1,47 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       542(+542) |     22(+22) |     217(+217) |
+| [fill]                     |       560(+560) |     22(+22) |     228(+228) |
+| [lib]/ActivityKit.a        |       782(+782) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
-| [lib]/BehaviorKit.a        |     1814(+1814) |       0(+0) |         0(+0) |
+| [lib]/BehaviorKit.a        |     1854(+1854) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7920(+7920) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
-| [lib]/RFIDKit.a            |     1058(+1058) |       0(+0) |         8(+8) |
+| [lib]/RFIDKit.a            |     1062(+1062) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1470(+1470) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       638(+638) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   42180(+42180) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 172108(+172108) |   769(+769) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   81392(+81392) |   548(+548) | 25125(+25125) |
-| Subtotals                  | 357720(+357720) | 3944(+3944) | 76392(+76392) |
-Total Static RAM memory (data + bss): 80336(+80336) bytes
-Total Flash memory (text + data): 361664(+361664) bytes
+| main.cpp.obj               |   93860(+93860) |   548(+548) | 25826(+25826) |
+| Subtotals                  | 371032(+371032) | 3944(+3944) | 77104(+77104) |
+Total Static RAM memory (data + bss): 81048(+81048) bytes
+Total Flash memory (text + data): 374976(+374976) bytes
 
Flash used: 411708&nbsp;(19%) / total: 2097152
SRAM used: 81376&nbsp;(15%) / total: 524288

@HPezz HPezz force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch 2 times, most recently from ff230cc to 86c5a04 Compare September 1, 2022 14:39
@HPezz HPezz force-pushed the hugo/feature/Update-GameKit-and-add-first-Game branch 3 times, most recently from a5c4571 to 2138705 Compare September 1, 2022 15:20
@HPezz HPezz force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch from 86c5a04 to aa1d602 Compare September 1, 2022 15:21
@HPezz HPezz force-pushed the hugo/feature/Update-GameKit-and-add-first-Game branch from 2138705 to 8fe7ba0 Compare September 1, 2022 15:28
@HPezz HPezz force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch from aa1d602 to 354a388 Compare September 1, 2022 15:33
@YannLocatelli
Copy link
Member

YannLocatelli commented Sep 2, 2022

La PR de la branche de base a été closed, est-ce que tu peux repointer sur une branche en cours pour que les commits soient à jour? Merci~

@HPezz HPezz changed the base branch from hugo/feature/Update-GameKit-and-add-first-Game to develop September 2, 2022 08:32
@HPezz HPezz force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch from 354a388 to 4cb5bf7 Compare September 2, 2022 08:32
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour tout le travail réalisé

libs/RobotKit/CMakeLists.txt Outdated Show resolved Hide resolved
app/os/main.cpp Outdated Show resolved Hide resolved
app/os/main.cpp Outdated Show resolved Hide resolved
app/os/main.cpp Outdated Show resolved Hide resolved
libs/RobotKit/include/StateMachine.h Outdated Show resolved Hide resolved
libs/RobotKit/tests/StateMachine_test.cpp Outdated Show resolved Hide resolved
@HPezz HPezz force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch 4 times, most recently from 7a5518a to 98b2a58 Compare September 5, 2022 14:33
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1er passage avant d'en causer demain :)
bon boulot! c'est très cool 👍

app/os/main.cpp Outdated Show resolved Hide resolved
app/os/main.cpp Outdated Show resolved Hide resolved
libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved
libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved
libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved
libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved
libs/RobotKit/include/StateMachine.h Outdated Show resolved Hide resolved
libs/RobotKit/include/StateMachine.h Outdated Show resolved Hide resolved
libs/RobotKit/include/StateMachine.h Outdated Show resolved Hide resolved
sm.process_event(lksm::event::autonomous_activity_requested {});

EXPECT_TRUE(sm.is(lksm::state::autonomous_activity));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il commence à y avoir trop de tests dans le même fichier, il faudrait séparer

@HPezz HPezz force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch 5 times, most recently from 44866ac to 3e1751a Compare September 6, 2022 16:51
@ladislas ladislas force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch from 3e1751a to d91bbbf Compare September 6, 2022 21:42
@ladislas ladislas force-pushed the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch from d91bbbf to dc9466c Compare September 6, 2022 21:56
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit ccc2f33 into develop Sep 6, 2022
@ladislas ladislas deleted the hugo/feature/Update-RC-SM-and-OS-to-Gamekit branch September 6, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - type: task Something to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFID - Read & process any MagicCard
3 participants